[U-Boot] [PATCH] net: zynq_gem: Initialize phyreg variable

[U-Boot] [PATCH] net: zynq_gem: Initialize phyreg variable

[Michal Simek]

In case of phyread()/phy_setup_op() timeout code is working with
uninitialized phyreg variable. Initialize this variable to make sure
that code it not working with random value.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/zynq_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
index d1436807ffb9..14564e365e6e 100644
--- a/drivers/net/zynq_gem.c
+++ b/drivers/net/zynq_gem.c
@@ -244,7 +244,7 @@ static int phywrite(struct zynq_gem_priv *priv, u32 phy_addr,
 static int phy_detection(struct udevice *dev)
 {
 	int i;
-	u16 phyreg;
+	u16 phyreg = 0;
 	struct zynq_gem_priv *priv = dev->priv;
 
 	if (priv->phyaddr != -1) {
-- 
1.9.1

[U-Boot] [PATCH] net: zynq_gem: Initialize phyreg variable

[Joe Hershberger]

On Wed, Jun 13, 2018 at 3:33 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> In case of phyread()/phy_setup_op() timeout code is working with
> uninitialized phyreg variable. Initialize this variable to make sure
> that code it not working with random value.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

[U-Boot] net: zynq_gem: Initialize phyreg variable

[Joe Hershberger]

Hi Michal,

https://patchwork.ozlabs.org/patch/928754/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git

Thanks!
-Joe