* [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
@ 2020-06-15 16:10 Andy Shevchenko
2020-08-05 9:39 ` Wolfram Sang
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Andy Shevchenko @ 2020-06-15 16:10 UTC (permalink / raw)
To: Seth Heasley, Neil Horman, linux-i2c, Wolfram Sang; +Cc: Andy Shevchenko
Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-ismt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 2f95e25a10f7..cdba77f9ecb1 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -77,6 +77,7 @@
#define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
#define PCI_DEVICE_ID_INTEL_CDF_SMT 0x18ac
#define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
+#define PCI_DEVICE_ID_INTEL_EBG_SMT 0x1bff
#define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
#define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
@@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
{ 0, }
};
--
2.27.0.rc2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-06-15 16:10 [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH Andy Shevchenko
@ 2020-08-05 9:39 ` Wolfram Sang
2020-08-28 15:02 ` Andy Shevchenko
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-08-05 9:39 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Seth Heasley, Neil Horman, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
On Mon, Jun 15, 2020 at 07:10:01PM +0300, Andy Shevchenko wrote:
> Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Seth, Neil?
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 2f95e25a10f7..cdba77f9ecb1 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -77,6 +77,7 @@
> #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> #define PCI_DEVICE_ID_INTEL_CDF_SMT 0x18ac
> #define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
> +#define PCI_DEVICE_ID_INTEL_EBG_SMT 0x1bff
> #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
>
> #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
> @@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> { 0, }
> };
> --
> 2.27.0.rc2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-06-15 16:10 [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH Andy Shevchenko
2020-08-05 9:39 ` Wolfram Sang
@ 2020-08-28 15:02 ` Andy Shevchenko
2020-09-21 10:03 ` Wolfram Sang
2020-09-14 9:43 ` Seth Heasley (Linux)
2020-09-21 10:00 ` Wolfram Sang
3 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2020-08-28 15:02 UTC (permalink / raw)
To: Seth Heasley, Neil Horman, linux-i2c, Wolfram Sang
On Mon, Jun 15, 2020 at 07:10:01PM +0300, Andy Shevchenko wrote:
> Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
Seth, Neil, any tag for this?
Wolfram, this is an ID and I don't think silence from maintainers prevent us to
add it. What do you think?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-06-15 16:10 [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH Andy Shevchenko
2020-08-05 9:39 ` Wolfram Sang
2020-08-28 15:02 ` Andy Shevchenko
@ 2020-09-14 9:43 ` Seth Heasley (Linux)
2020-09-21 10:05 ` Wolfram Sang
2020-09-21 10:00 ` Wolfram Sang
3 siblings, 1 reply; 7+ messages in thread
From: Seth Heasley (Linux) @ 2020-09-14 9:43 UTC (permalink / raw)
To: Andy Shevchenko, Seth Heasley, Neil Horman, linux-i2c, Wolfram Sang
Hi Andy,
Sorry for the slow response.
> Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Seth Heasley <seth.heasley@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-
> ismt.c
> index 2f95e25a10f7..cdba77f9ecb1 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -77,6 +77,7 @@
> #define PCI_DEVICE_ID_INTEL_S1200_SMT1 0x0c5a
> #define PCI_DEVICE_ID_INTEL_CDF_SMT 0x18ac
> #define PCI_DEVICE_ID_INTEL_DNV_SMT 0x19ac
> +#define PCI_DEVICE_ID_INTEL_EBG_SMT 0x1bff
> #define PCI_DEVICE_ID_INTEL_AVOTON_SMT 0x1f15
>
> #define ISMT_DESC_ENTRIES 2 /* number of descriptor entries */
> @@ -184,6 +185,7 @@ static const struct pci_device_id ismt_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_S1200_SMT1) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMT)
> },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMT)
> },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMT)
> },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_AVOTON_SMT) },
> { 0, }
> };
-Seth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-06-15 16:10 [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH Andy Shevchenko
` (2 preceding siblings ...)
2020-09-14 9:43 ` Seth Heasley (Linux)
@ 2020-09-21 10:00 ` Wolfram Sang
3 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-09-21 10:00 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Seth Heasley, Neil Horman, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
On Mon, Jun 15, 2020 at 07:10:01PM +0300, Andy Shevchenko wrote:
> Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-08-28 15:02 ` Andy Shevchenko
@ 2020-09-21 10:03 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-09-21 10:03 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Seth Heasley, Neil Horman, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Fri, Aug 28, 2020 at 06:02:39PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 15, 2020 at 07:10:01PM +0300, Andy Shevchenko wrote:
> > Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
>
> Seth, Neil, any tag for this?
> Wolfram, this is an ID and I don't think silence from maintainers prevent us to
> add it. What do you think?
Only as a very last resort. If there are dedicated driver maintainers,
the drivers are their authority. If I apply trivial patches on my own,
then there may be confusion about what is a trivial patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH
2020-09-14 9:43 ` Seth Heasley (Linux)
@ 2020-09-21 10:05 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-09-21 10:05 UTC (permalink / raw)
To: Seth Heasley (Linux)
Cc: Andy Shevchenko, Seth Heasley, Neil Horman, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Mon, Sep 14, 2020 at 02:43:56AM -0700, Seth Heasley (Linux) wrote:
> Hi Andy,
>
> Sorry for the slow response.
>
> > Add PCI ID for the Intel Emmitsburg PCH iSMT SMBus controller.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Seth Heasley <seth.heasley@linux.intel.com>
Thanks! One favor I am asking: Would you mind using "Reviewed-by" in the
future? It is more apropriate and also for easier for my tools to detect
when a patch was reviewed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-09-21 10:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 16:10 [PATCH v1] i2c: ismt: Add support for Intel Emmitsburg PCH Andy Shevchenko
2020-08-05 9:39 ` Wolfram Sang
2020-08-28 15:02 ` Andy Shevchenko
2020-09-21 10:03 ` Wolfram Sang
2020-09-14 9:43 ` Seth Heasley (Linux)
2020-09-21 10:05 ` Wolfram Sang
2020-09-21 10:00 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.