* [PATCH] video: ARM CLCD: constify amba_id
@ 2017-08-23 17:37 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-23 17:25 UTC (permalink / raw)
To: linux, b.zolnierkie; +Cc: linux-kernel, linux-fbdev
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/amba-clcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index ffc2c33c..36d2519 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -1035,7 +1035,7 @@ static struct clcd_vendor_data vendor_nomadik = {
.init_panel = nomadik_clcd_init_panel,
};
-static struct amba_id clcdfb_id_table[] = {
+static const struct amba_id clcdfb_id_table[] = {
{
.id = 0x00041110,
.mask = 0x000ffffe,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: ARM CLCD: constify amba_id
@ 2017-08-23 17:37 ` Arvind Yadav
0 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-23 17:37 UTC (permalink / raw)
To: linux, b.zolnierkie; +Cc: linux-kernel, linux-fbdev
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/amba-clcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index ffc2c33c..36d2519 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -1035,7 +1035,7 @@ static struct clcd_vendor_data vendor_nomadik = {
.init_panel = nomadik_clcd_init_panel,
};
-static struct amba_id clcdfb_id_table[] = {
+static const struct amba_id clcdfb_id_table[] = {
{
.id = 0x00041110,
.mask = 0x000ffffe,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] video: ARM CLCD: constify amba_id
2017-08-23 17:37 ` Arvind Yadav
@ 2017-09-04 12:59 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-09-04 12:59 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux, linux-kernel, linux-fbdev
On Wednesday, August 23, 2017 10:55:26 PM Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: ARM CLCD: constify amba_id
@ 2017-09-04 12:59 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-09-04 12:59 UTC (permalink / raw)
To: Arvind Yadav; +Cc: linux, linux-kernel, linux-fbdev
On Wednesday, August 23, 2017 10:55:26 PM Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-04 12:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170823172539epcas2p4bf9c8256b20d614907bc572c0bf60926@epcas2p4.samsung.com>
2017-08-23 17:25 ` [PATCH] video: ARM CLCD: constify amba_id Arvind Yadav
2017-08-23 17:37 ` Arvind Yadav
2017-09-04 12:59 ` Bartlomiej Zolnierkiewicz
2017-09-04 12:59 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.