* [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
@ 2019-03-04 10:32 Thomas Huth
2019-03-04 11:08 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2019-03-04 10:32 UTC (permalink / raw)
To: qemu-devel, Ed Maste, Li-Wen Hsu
Cc: Peter Maydell, Alex Bennée, Philippe Mathieu-Daudé
cirrus-ci.com also has the possibility to run CI tasks on macOS.
Since most of the QEMU developers do not have access to macOS yet,
let's add a CI pipeline for this operating system here, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
You can see an example here: https://cirrus-ci.com/task/5099494325616640
.cirrus.yml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/.cirrus.yml b/.cirrus.yml
index 303fe72..e3d375b 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -14,3 +14,15 @@ freebsd_12_task:
- ../configure || { cat config.log; exit 1; }
- gmake -j8
- gmake -j8 V=1 check
+
+macos_task:
+ osx_instance:
+ image: high-sierra-base
+ env:
+ CIRRUS_CLONE_DEPTH: 1
+ install_script:
+ - brew install pkg-config glib pixman make sdl2
+ script:
+ - ./configure || { cat config.log; exit 1; }
+ - gmake -j$(sysctl -n hw.ncpu)
+ - gmake check -j$(sysctl -n hw.ncpu)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-04 10:32 [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task Thomas Huth
@ 2019-03-04 11:08 ` Philippe Mathieu-Daudé
2019-03-04 11:39 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-03-04 11:08 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Ed Maste, Li-Wen Hsu
Cc: Peter Maydell, Alex Bennée, Philippe Mathieu-Daudé
On 3/4/19 11:32 AM, Thomas Huth wrote:
> cirrus-ci.com also has the possibility to run CI tasks on macOS.
> Since most of the QEMU developers do not have access to macOS yet,
> let's add a CI pipeline for this operating system here, too.
Can we get report of failures? (IRC, mail to ML, patchew icon)
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> You can see an example here: https://cirrus-ci.com/task/5099494325616640
>
> .cirrus.yml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 303fe72..e3d375b 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -14,3 +14,15 @@ freebsd_12_task:
> - ../configure || { cat config.log; exit 1; }
> - gmake -j8
> - gmake -j8 V=1 check
> +
> +macos_task:
> + osx_instance:
> + image: high-sierra-base
> + env:
> + CIRRUS_CLONE_DEPTH: 1
> + install_script:
> + - brew install pkg-config glib pixman make sdl2
> + script:
> + - ./configure || { cat config.log; exit 1; }
> + - gmake -j$(sysctl -n hw.ncpu)
> + - gmake check -j$(sysctl -n hw.ncpu)
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-04 11:08 ` Philippe Mathieu-Daudé
@ 2019-03-04 11:39 ` Thomas Huth
2019-03-07 19:28 ` Ed Maste
2019-03-07 20:26 ` Ed Maste
2019-03-07 21:10 ` Paolo Bonzini
2 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2019-03-04 11:39 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Ed Maste, Li-Wen Hsu
Cc: Peter Maydell, Alex Bennée, Philippe Mathieu-Daudé
On 04/03/2019 12.08, Philippe Mathieu-Daudé wrote:
> On 3/4/19 11:32 AM, Thomas Huth wrote:
>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>> Since most of the QEMU developers do not have access to macOS yet,
>> let's add a CI pipeline for this operating system here, too.
>
> Can we get report of failures? (IRC, mail to ML, patchew icon)
Honestly, I've got no clue ... this is the only help text that I've
found so far:
https://cirrus-ci.org/guide/notifications/
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-04 11:39 ` Thomas Huth
@ 2019-03-07 19:28 ` Ed Maste
0 siblings, 0 replies; 10+ messages in thread
From: Ed Maste @ 2019-03-07 19:28 UTC (permalink / raw)
To: Thomas Huth
Cc: Philippe Mathieu-Daudé,
qemu-devel, Li-Wen Hsu, Peter Maydell, Alex Bennée,
Philippe Mathieu-Daudé
On Mon, 4 Mar 2019 at 06:39, Thomas Huth <thuth@redhat.com> wrote:
> >
> > Can we get report of failures? (IRC, mail to ML, patchew icon)
>
> Honestly, I've got no clue ... this is the only help text that I've
> found so far:
>
> https://cirrus-ci.org/guide/notifications/
I asked on twitter and was pointed at that same link, which in turn
leads to https://github.com/cirrus-actions/email but I'm not quite
sure what to do with it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-04 11:08 ` Philippe Mathieu-Daudé
2019-03-04 11:39 ` Thomas Huth
@ 2019-03-07 20:26 ` Ed Maste
2019-03-07 20:30 ` Thomas Huth
2019-03-07 21:10 ` Paolo Bonzini
2 siblings, 1 reply; 10+ messages in thread
From: Ed Maste @ 2019-03-07 20:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, qemu-devel, Li-Wen Hsu, Peter Maydell,
Alex Bennée, Philippe Mathieu-Daudé
On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 3/4/19 11:32 AM, Thomas Huth wrote:
> > cirrus-ci.com also has the possibility to run CI tasks on macOS.
> > Since most of the QEMU developers do not have access to macOS yet,
> > let's add a CI pipeline for this operating system here, too.
>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Ed Maste <emaste@freebsd.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-07 20:26 ` Ed Maste
@ 2019-03-07 20:30 ` Thomas Huth
2019-03-07 21:52 ` Li-Wen Hsu
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Huth @ 2019-03-07 20:30 UTC (permalink / raw)
To: Ed Maste, Philippe Mathieu-Daudé
Cc: qemu-devel, Li-Wen Hsu, Peter Maydell, Alex Bennée,
Philippe Mathieu-Daudé
On 07/03/2019 21.26, Ed Maste wrote:
> On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> On 3/4/19 11:32 AM, Thomas Huth wrote:
>>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>>> Since most of the QEMU developers do not have access to macOS yet,
>>> let's add a CI pipeline for this operating system here, too.
>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Acked-by: Ed Maste <emaste@freebsd.org>
Thanks! I can take this patch through my qtest tree.
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-04 11:08 ` Philippe Mathieu-Daudé
2019-03-04 11:39 ` Thomas Huth
2019-03-07 20:26 ` Ed Maste
@ 2019-03-07 21:10 ` Paolo Bonzini
2019-03-08 7:16 ` Thomas Huth
2 siblings, 1 reply; 10+ messages in thread
From: Paolo Bonzini @ 2019-03-07 21:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé,
Thomas Huth, qemu-devel, Ed Maste, Li-Wen Hsu
Cc: Peter Maydell, Alex Bennée, Philippe Mathieu-Daudé
On 04/03/19 12:08, Philippe Mathieu-Daudé wrote:
> +macos_task:
> + osx_instance:
> + image: high-sierra-base
> + env:
> + CIRRUS_CLONE_DEPTH: 1
> + install_script:
> + - brew install pkg-config glib pixman make sdl2
Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid
Apple's obsolete /usr/bin/python (also needs something like
--python=/usr/local/bin/python3 in ./configure below).
Thanks,
Paolo
> + script:
> + - ./configure || { cat config.log; exit 1; }
> + - gmake -j$(sysctl -n hw.ncpu)
> + - gmake check -j$(sysctl -n hw.ncpu)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-07 20:30 ` Thomas Huth
@ 2019-03-07 21:52 ` Li-Wen Hsu
2019-03-08 7:19 ` Thomas Huth
0 siblings, 1 reply; 10+ messages in thread
From: Li-Wen Hsu @ 2019-03-07 21:52 UTC (permalink / raw)
To: Thomas Huth
Cc: Ed Maste, Philippe Mathieu-Daudé,
qemu-devel, Peter Maydell, Alex Bennée,
Philippe Mathieu-Daudé
On Fri, Mar 8, 2019 at 4:30 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 07/03/2019 21.26, Ed Maste wrote:
> > On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> >>
> >> On 3/4/19 11:32 AM, Thomas Huth wrote:
> >>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
> >>> Since most of the QEMU developers do not have access to macOS yet,
> >>> let's add a CI pipeline for this operating system here, too.
> >>
> >>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Acked-by: Ed Maste <emaste@freebsd.org>
>
> Thanks! I can take this patch through my qtest tree.
Hi Thomas,
Sorry for the late reply, I checked and tested the patch, it works
fine. BTW, may I suggest:
>From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base
is lasted as "Not maintained", how about change to mojave-base?
Also, perhaps we can put the common:
env:
CIRRUS_CLONE_DEPTH: 1
in the global area?
Thanks,
Li-wen
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-07 21:10 ` Paolo Bonzini
@ 2019-03-08 7:16 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-03-08 7:16 UTC (permalink / raw)
To: Paolo Bonzini, Philippe Mathieu-Daudé,
qemu-devel, Ed Maste, Li-Wen Hsu
Cc: Peter Maydell, Alex Bennée, Philippe Mathieu-Daudé
On 07/03/2019 22.10, Paolo Bonzini wrote:
> On 04/03/19 12:08, Philippe Mathieu-Daudé wrote:
>> +macos_task:
>> + osx_instance:
>> + image: high-sierra-base
>> + env:
>> + CIRRUS_CLONE_DEPTH: 1
>> + install_script:
>> + - brew install pkg-config glib pixman make sdl2
>
> Could you also install Python 3 ("python" in Homebrew is 3.7) and avoid
> Apple's obsolete /usr/bin/python (also needs something like
> --python=/usr/local/bin/python3 in ./configure below).
Yes, can do.
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task
2019-03-07 21:52 ` Li-Wen Hsu
@ 2019-03-08 7:19 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-03-08 7:19 UTC (permalink / raw)
To: Li-Wen Hsu
Cc: Ed Maste, Philippe Mathieu-Daudé,
qemu-devel, Peter Maydell, Alex Bennée,
Philippe Mathieu-Daudé
On 07/03/2019 22.52, Li-Wen Hsu wrote:
> On Fri, Mar 8, 2019 at 4:30 AM Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 07/03/2019 21.26, Ed Maste wrote:
>>> On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>>>
>>>> On 3/4/19 11:32 AM, Thomas Huth wrote:
>>>>> cirrus-ci.com also has the possibility to run CI tasks on macOS.
>>>>> Since most of the QEMU developers do not have access to macOS yet,
>>>>> let's add a CI pipeline for this operating system here, too.
>>>>
>>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Acked-by: Ed Maste <emaste@freebsd.org>
>>
>> Thanks! I can take this patch through my qtest tree.
>
> Hi Thomas,
>
> Sorry for the late reply, I checked and tested the patch, it works
> fine. BTW, may I suggest:
>
> From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base
> is lasted as "Not maintained", how about change to mojave-base?
Definitely! Not sure how I could have missed that... I was either blind,
or, how I remember it, the high-sierra-base image was not marked as
unmaintained yet and marked as the only image that had the brew system
pre-installed back then. Anyway, I've now switched to mojave-base and it
seems to work fine, too.
> Also, perhaps we can put the common:
>
> env:
> CIRRUS_CLONE_DEPTH: 1
>
> in the global area?
Sure! I'll do that in v2.
Thanks for the review,
Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-03-08 7:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 10:32 [Qemu-devel] [PATCH] cirrus.yml: Add macOS continuous integration task Thomas Huth
2019-03-04 11:08 ` Philippe Mathieu-Daudé
2019-03-04 11:39 ` Thomas Huth
2019-03-07 19:28 ` Ed Maste
2019-03-07 20:26 ` Ed Maste
2019-03-07 20:30 ` Thomas Huth
2019-03-07 21:52 ` Li-Wen Hsu
2019-03-08 7:19 ` Thomas Huth
2019-03-07 21:10 ` Paolo Bonzini
2019-03-08 7:16 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.