All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] media: davinci: vpif_capture: fix potential double free
@ 2020-07-23 20:15 ` Markus Elfring
  0 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2020-07-23 20:15 UTC (permalink / raw)
  To: Evgeny Novikov, ldv-project, linux-media
  Cc: linux-kernel, kernel-janitors, Mauro Carvalho Chehab, Prabhakar Lad

> In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
> and unregisters the V4L2 device. But then this is done again by
> vpif_probe() itself. The patch removes the cleaning from
> vpif_probe_complete().

* An imperative wording can be preferred for the change description,
  can't it?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] media: davinci: vpif_capture: fix potential double free
@ 2020-07-23 17:04 Evgeny Novikov
  2020-07-24 14:16 ` Lad, Prabhakar
  0 siblings, 1 reply; 9+ messages in thread
From: Evgeny Novikov @ 2020-07-23 17:04 UTC (permalink / raw)
  To: Lad, Prabhakar
  Cc: Evgeny Novikov, Mauro Carvalho Chehab, linux-media, linux-kernel,
	ldv-project

In case of errors vpif_probe_complete() releases memory for vpif_obj.sd
and unregisters the V4L2 device. But then this is done again by
vpif_probe() itself. The patch removes the cleaning from
vpif_probe_complete().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
 drivers/media/platform/davinci/vpif_capture.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index d9ec439faefa..72a0e94e2e21 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -1482,8 +1482,6 @@ static int vpif_probe_complete(void)
 		/* Unregister video device */
 		video_unregister_device(&ch->video_dev);
 	}
-	kfree(vpif_obj.sd);
-	v4l2_device_unregister(&vpif_obj.v4l2_dev);
 
 	return err;
 }
-- 
2.16.4


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-08-02 18:38 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 20:15 [PATCH] media: davinci: vpif_capture: fix potential double free Markus Elfring
2020-07-23 20:15 ` Markus Elfring
2020-07-24 20:08 ` Evgeny Novikov
2020-07-24 20:08   ` Evgeny Novikov
  -- strict thread matches above, loose matches on Subject: below --
2020-07-23 17:04 Evgeny Novikov
2020-07-24 14:16 ` Lad, Prabhakar
2020-07-24 20:00   ` Evgeny Novikov
2020-07-24 22:05     ` Lad, Prabhakar
2020-08-02 18:38       ` Evgeny Novikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.