From: Neil Armstrong <narmstrong@baylibre.com> To: Fabio Estevam <festevam@gmail.com> Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, linux-kernel <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/4] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support Date: Wed, 22 Nov 2017 10:14:36 +0100 [thread overview] Message-ID: <b1a1ac14-5ff3-08bf-a3ee-27dd7641c7fe@baylibre.com> (raw) In-Reply-To: <CAOMZO5BDQxZxHX_dn63QvbwfaVjERQtBqCp3FCT9Q6zvsrgn4w@mail.gmail.com> Hi Fabio, On 21/11/2017 17:54, Fabio Estevam wrote: > On Tue, Nov 21, 2017 at 2:28 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: > >> + reg_wl18xx_vmmc: regulator-wl18xx { >> + compatible = "regulator-fixed"; >> + regulator-name = "vwl1807"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + gpio = <&gpio7 8 0>; > > GPIO_ACTIVE_HIGH please. OK > >> +&can2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_flexcan2>; >> + status = "disabled"; >> +}; >> + >> +&cpu0 { >> + arm-supply = <&sw1a_reg>; >> + soc-supply = <&sw1c_reg>; >> + operating-points = < >> + /* kHz uV */ >> + 1200000 1350000 >> + 996000 1250000 >> + 852000 1250000 >> + 792000 1175000 >> + 396000 1175000 >> + >; >> + fsl,soc-operating-points = < >> + /* ARM kHz SOC-PU uV */ >> + 1200000 1275000 >> + 996000 1250000 >> + 852000 1250000 >> + 792000 1175000 >> + 396000 1175000 >> + >; > > > Don't the standard operating points described at imx6q.dtsi work on this board? > > If not, please add a comment explaining why you need custom operating > points here. It should, I will remove them, anyway it will conflict with the ones in imx6dl.dtsi. > >> + pinctrl_flexcan1: flexcan1grp { >> + fsl,pins = < >> + MX6QDL_PAD_GPIO_7__FLEXCAN1_TX 0x80000000 >> + MX6QDL_PAD_GPIO_8__FLEXCAN1_RX 0x80000000 > > Please avoid 0x80000000 and use the real IOMUX values instead. Ok, will replace with 0x1b0b0 > >> + >; >> + }; >> + >> + pinctrl_flexcan2: flexcan2grp { >> + fsl,pins = < >> + MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x80000000 >> + MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x80000000 > > Please avoid 0x80000000 and use the real IOMUX values instead. > Same here. Thanks, Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support Date: Wed, 22 Nov 2017 10:14:36 +0100 [thread overview] Message-ID: <b1a1ac14-5ff3-08bf-a3ee-27dd7641c7fe@baylibre.com> (raw) In-Reply-To: <CAOMZO5BDQxZxHX_dn63QvbwfaVjERQtBqCp3FCT9Q6zvsrgn4w@mail.gmail.com> Hi Fabio, On 21/11/2017 17:54, Fabio Estevam wrote: > On Tue, Nov 21, 2017 at 2:28 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: > >> + reg_wl18xx_vmmc: regulator-wl18xx { >> + compatible = "regulator-fixed"; >> + regulator-name = "vwl1807"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + gpio = <&gpio7 8 0>; > > GPIO_ACTIVE_HIGH please. OK > >> +&can2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_flexcan2>; >> + status = "disabled"; >> +}; >> + >> +&cpu0 { >> + arm-supply = <&sw1a_reg>; >> + soc-supply = <&sw1c_reg>; >> + operating-points = < >> + /* kHz uV */ >> + 1200000 1350000 >> + 996000 1250000 >> + 852000 1250000 >> + 792000 1175000 >> + 396000 1175000 >> + >; >> + fsl,soc-operating-points = < >> + /* ARM kHz SOC-PU uV */ >> + 1200000 1275000 >> + 996000 1250000 >> + 852000 1250000 >> + 792000 1175000 >> + 396000 1175000 >> + >; > > > Don't the standard operating points described at imx6q.dtsi work on this board? > > If not, please add a comment explaining why you need custom operating > points here. It should, I will remove them, anyway it will conflict with the ones in imx6dl.dtsi. > >> + pinctrl_flexcan1: flexcan1grp { >> + fsl,pins = < >> + MX6QDL_PAD_GPIO_7__FLEXCAN1_TX 0x80000000 >> + MX6QDL_PAD_GPIO_8__FLEXCAN1_RX 0x80000000 > > Please avoid 0x80000000 and use the real IOMUX values instead. Ok, will replace with 0x1b0b0 > >> + >; >> + }; >> + >> + pinctrl_flexcan2: flexcan2grp { >> + fsl,pins = < >> + MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x80000000 >> + MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x80000000 > > Please avoid 0x80000000 and use the real IOMUX values instead. > Same here. Thanks, Neil
next prev parent reply other threads:[~2017-11-22 9:14 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-21 16:28 [PATCH 0/4] ARM: Add Variscite DART-MX6 SoM and Carrier-board support Neil Armstrong 2017-11-21 16:28 ` Neil Armstrong 2017-11-21 16:28 ` [PATCH 1/4] ARM: dts: imx6qdl-pinfunc: Add missing MX6QDL_PAD_ENET_RXD0__OSC32K_32K_OUT Neil Armstrong 2017-11-21 16:28 ` Neil Armstrong 2017-11-21 16:59 ` Fabio Estevam 2017-11-21 16:59 ` Fabio Estevam 2017-11-21 16:28 ` [PATCH 2/4] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support Neil Armstrong 2017-11-21 16:28 ` Neil Armstrong 2017-11-21 16:54 ` Fabio Estevam 2017-11-21 16:54 ` Fabio Estevam 2017-11-22 9:14 ` Neil Armstrong [this message] 2017-11-22 9:14 ` Neil Armstrong 2017-11-21 16:28 ` [PATCH 3/4] ARM: dts: imx6q: Add Variscite DART-MX6 Carrier-board support Neil Armstrong 2017-11-21 16:28 ` Neil Armstrong 2017-11-21 16:45 ` Fabio Estevam 2017-11-21 16:45 ` Fabio Estevam 2017-11-22 10:51 ` Neil Armstrong 2017-11-22 10:51 ` Neil Armstrong 2017-11-21 16:28 ` [PATCH 4/4] ARM: configs: Add missing config for DART-MX6 SoM Neil Armstrong 2017-11-21 16:28 ` Neil Armstrong 2017-11-21 16:54 ` Fabio Estevam 2017-11-21 16:54 ` Fabio Estevam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b1a1ac14-5ff3-08bf-a3ee-27dd7641c7fe@baylibre.com \ --to=narmstrong@baylibre.com \ --cc=fabio.estevam@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.