From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v5] checkpatch: add new warnings to author signoff checks.
Date: Wed, 07 Oct 2020 11:44:46 -0700 [thread overview]
Message-ID: <b1f15283f770c71923920fef8fc6c643433d1ef9.camel@perches.com> (raw)
In-Reply-To: <CABJPP5B_nscUwm4m+PySN67Cp=i1aR8KXKRuAf2YdAj_950j2Q@mail.gmail.com>
On Thu, 2020-10-08 at 00:08 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 7, 2020 at 11:48 PM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2020-10-07 at 12:08 +0530, Dwaipayan Ray wrote:
> > > On Wed, Oct 7, 2020 at 12:03 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> > > > The author signed-off-by checks are currently very vague.
> > > > Cases like same name or same address are not handled separately.
> >
> > Likely now, the type should be changed from NO_AUTHOR_SIGN_OFF
> > to a single something else for all the other types of messages.
> >
> >
> Since BAD_SIGNOFF is being used for a different context, then
> probably BAD_AUTHOR_SIGNOFF.
>
> Should this work or anything else you have in mind?
That may be a bit too strong a wording as these aren't
significant/bad defects.
Maybe something like FROM_SIGNOFF_MISMATCH.
It's not anything that would reject the patch.
It's a pity type uses both SIGNOFF and SIGN_OFF.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v5] checkpatch: add new warnings to author signoff checks.
Date: Wed, 07 Oct 2020 11:44:46 -0700 [thread overview]
Message-ID: <b1f15283f770c71923920fef8fc6c643433d1ef9.camel@perches.com> (raw)
In-Reply-To: <CABJPP5B_nscUwm4m+PySN67Cp=i1aR8KXKRuAf2YdAj_950j2Q@mail.gmail.com>
On Thu, 2020-10-08 at 00:08 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 7, 2020 at 11:48 PM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2020-10-07 at 12:08 +0530, Dwaipayan Ray wrote:
> > > On Wed, Oct 7, 2020 at 12:03 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> > > > The author signed-off-by checks are currently very vague.
> > > > Cases like same name or same address are not handled separately.
> >
> > Likely now, the type should be changed from NO_AUTHOR_SIGN_OFF
> > to a single something else for all the other types of messages.
> >
> >
> Since BAD_SIGNOFF is being used for a different context, then
> probably BAD_AUTHOR_SIGNOFF.
>
> Should this work or anything else you have in mind?
That may be a bit too strong a wording as these aren't
significant/bad defects.
Maybe something like FROM_SIGNOFF_MISMATCH.
It's not anything that would reject the patch.
It's a pity type uses both SIGNOFF and SIGN_OFF.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-07 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 6:33 [PATCH v5] checkpatch: add new warnings to author signoff checks Dwaipayan Ray
2020-10-07 6:33 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-07 6:38 ` Dwaipayan Ray
2020-10-07 6:38 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-07 18:18 ` Joe Perches
2020-10-07 18:18 ` [Linux-kernel-mentees] " Joe Perches
2020-10-07 18:38 ` Dwaipayan Ray
2020-10-07 18:38 ` [Linux-kernel-mentees] " Dwaipayan Ray
2020-10-07 18:44 ` Joe Perches [this message]
2020-10-07 18:44 ` Joe Perches
2020-10-07 18:53 ` Dwaipayan Ray
2020-10-07 18:53 ` [Linux-kernel-mentees] " Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1f15283f770c71923920fef8fc6c643433d1ef9.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.