* [Qemu-devel] [PATCH] virt: Fix broken indentation
@ 2018-12-12 0:31 Eduardo Habkost
2018-12-12 9:34 ` Thomas Huth
2018-12-12 11:38 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2018-12-12 0:31 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Peter Maydell, qemu-arm
I introduced indentation using tabs instead of spaces in another
commit. Peter reported the problem, and I failed to fix that
before sending my pull request.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: 951597607696 ("virt: Eliminate separate instance_init functions")
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 17f1b49d11..5b678237b7 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1854,7 +1854,7 @@ static const TypeInfo virt_machine_info = {
.instance_size = sizeof(VirtMachineState),
.class_size = sizeof(VirtMachineClass),
.class_init = virt_machine_class_init,
- .instance_init = virt_instance_init,
+ .instance_init = virt_instance_init,
.interfaces = (InterfaceInfo[]) {
{ TYPE_HOTPLUG_HANDLER },
{ }
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virt: Fix broken indentation
2018-12-12 0:31 [Qemu-devel] [PATCH] virt: Fix broken indentation Eduardo Habkost
@ 2018-12-12 9:34 ` Thomas Huth
2018-12-12 11:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2018-12-12 9:34 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel; +Cc: qemu-trivial, Peter Maydell, qemu-arm
On 2018-12-12 01:31, Eduardo Habkost wrote:
> I introduced indentation using tabs instead of spaces in another
> commit. Peter reported the problem, and I failed to fix that
> before sending my pull request.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: 951597607696 ("virt: Eliminate separate instance_init functions")
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> hw/arm/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 17f1b49d11..5b678237b7 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1854,7 +1854,7 @@ static const TypeInfo virt_machine_info = {
> .instance_size = sizeof(VirtMachineState),
> .class_size = sizeof(VirtMachineClass),
> .class_init = virt_machine_class_init,
> - .instance_init = virt_instance_init,
> + .instance_init = virt_instance_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_HOTPLUG_HANDLER },
> { }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virt: Fix broken indentation
2018-12-12 0:31 [Qemu-devel] [PATCH] virt: Fix broken indentation Eduardo Habkost
2018-12-12 9:34 ` Thomas Huth
@ 2018-12-12 11:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-12-12 11:38 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel; +Cc: qemu-trivial, Peter Maydell, qemu-arm
On 12/12/18 1:31 AM, Eduardo Habkost wrote:
> I introduced indentation using tabs instead of spaces in another
> commit. Peter reported the problem, and I failed to fix that
> before sending my pull request.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: 951597607696 ("virt: Eliminate separate instance_init functions")
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/virt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 17f1b49d11..5b678237b7 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1854,7 +1854,7 @@ static const TypeInfo virt_machine_info = {
> .instance_size = sizeof(VirtMachineState),
> .class_size = sizeof(VirtMachineClass),
> .class_init = virt_machine_class_init,
> - .instance_init = virt_instance_init,
> + .instance_init = virt_instance_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_HOTPLUG_HANDLER },
> { }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 0:31 [Qemu-devel] [PATCH] virt: Fix broken indentation Eduardo Habkost
2018-12-12 9:34 ` Thomas Huth
2018-12-12 11:38 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.