* [Xen-devel] [PATCH] golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot
@ 2019-11-14 22:44 Nick Rosbrook
2019-11-15 9:26 ` George Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Nick Rosbrook @ 2019-11-14 22:44 UTC (permalink / raw)
To: xen-devel; +Cc: Nick Rosbrook, Ian Jackson, George Dunlap, Wei Liu
From: Nick Rosbrook <rosbrookn@ainfosec.com>
These functions now have a third parameter of type const *libxl_asyncop_how.
Pass nil for this argument to fix compilation and maintain the
synchronous behavior.
Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
---
tools/golang/xenlight/xenlight.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go
index 59b8186a64..902cbb839e 100644
--- a/tools/golang/xenlight/xenlight.go
+++ b/tools/golang/xenlight/xenlight.go
@@ -1041,7 +1041,7 @@ func (Ctx *Context) DomainShutdown(id Domid) (err error) {
return
}
- ret := C.libxl_domain_shutdown(Ctx.ctx, C.uint32_t(id))
+ ret := C.libxl_domain_shutdown(Ctx.ctx, C.uint32_t(id), nil)
if ret != 0 {
err = Error(-ret)
@@ -1056,7 +1056,7 @@ func (Ctx *Context) DomainReboot(id Domid) (err error) {
return
}
- ret := C.libxl_domain_reboot(Ctx.ctx, C.uint32_t(id))
+ ret := C.libxl_domain_reboot(Ctx.ctx, C.uint32_t(id), nil)
if ret != 0 {
err = Error(-ret)
--
2.19.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot
2019-11-14 22:44 [Xen-devel] [PATCH] golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot Nick Rosbrook
@ 2019-11-15 9:26 ` George Dunlap
2019-11-15 14:41 ` Nick Rosbrook
0 siblings, 1 reply; 3+ messages in thread
From: George Dunlap @ 2019-11-15 9:26 UTC (permalink / raw)
To: Nick Rosbrook, xen-devel; +Cc: Nick Rosbrook, Ian Jackson, Wei Liu
On 11/14/19 10:44 PM, Nick Rosbrook wrote:
> From: Nick Rosbrook <rosbrookn@ainfosec.com>
>
> These functions now have a third parameter of type const *libxl_asyncop_how.
>
> Pass nil for this argument to fix compilation and maintain the
> synchronous behavior.
>
> Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com>
Actually this has already been submitted and Release-acked here:
https://patchew.org/Xen/20191023162358.7222-1-george.dunlap@citrix.com/
It was just done during a commit moratorium, and then forgotten
afterwards. I'll check it in now.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot
2019-11-15 9:26 ` George Dunlap
@ 2019-11-15 14:41 ` Nick Rosbrook
0 siblings, 0 replies; 3+ messages in thread
From: Nick Rosbrook @ 2019-11-15 14:41 UTC (permalink / raw)
To: George Dunlap; +Cc: Nick Rosbrook, Xen-devel, Ian Jackson, Wei Liu
> Actually this has already been submitted and Release-acked here:
>
> https://patchew.org/Xen/20191023162358.7222-1-george.dunlap@citrix.com/
Ah thanks, I remember seeing that now but I confused it with the
*very* similar patch for libxl_domain_pause/unpause.
-NR
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 22:44 [Xen-devel] [PATCH] golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot Nick Rosbrook
2019-11-15 9:26 ` George Dunlap
2019-11-15 14:41 ` Nick Rosbrook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.