All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cmake.bbclass: avoid treating imports as system includes
@ 2016-09-06 21:41 Andreas Müller
  2016-09-07  9:56 ` Jack Mitchell
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Müller @ 2016-09-06 21:41 UTC (permalink / raw)
  To: openembedded-core

CMake sets all imported headers as system headers. This causes trouble for c++
projects [1].

Thanks to Jack Mitchell for pointing to the setting [2]. Build tested upon
meta-qt5-extra-world which had lots of fallout before.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
[2] http://lists.openembedded.org/pipermail/openembedded-core/2016-September/126067.html

Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta/classes/cmake.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index 5203d8a..7091f8b 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -120,6 +120,7 @@ cmake_do_configure() {
 	  -DCMAKE_INSTALL_SO_NO_EXE=0 \
 	  -DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
 	  -DCMAKE_VERBOSE_MAKEFILE=1 \
+	  -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
 	  ${EXTRA_OECMAKE} \
 	  -Wno-dev
 }
-- 
2.5.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cmake.bbclass: avoid treating imports as system includes
  2016-09-06 21:41 [PATCH] cmake.bbclass: avoid treating imports as system includes Andreas Müller
@ 2016-09-07  9:56 ` Jack Mitchell
  0 siblings, 0 replies; 2+ messages in thread
From: Jack Mitchell @ 2016-09-07  9:56 UTC (permalink / raw)
  To: openembedded-core

On 06/09/16 22:41, Andreas Müller wrote:
> CMake sets all imported headers as system headers. This causes trouble for c++
> projects [1].
>
> Thanks to Jack Mitchell for pointing to the setting [2]. Build tested upon
> meta-qt5-extra-world which had lots of fallout before.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> [2] http://lists.openembedded.org/pipermail/openembedded-core/2016-September/126067.html
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta/classes/cmake.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index 5203d8a..7091f8b 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -120,6 +120,7 @@ cmake_do_configure() {
>  	  -DCMAKE_INSTALL_SO_NO_EXE=0 \
>  	  -DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
>  	  -DCMAKE_VERBOSE_MAKEFILE=1 \
> +	  -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
>  	  ${EXTRA_OECMAKE} \
>  	  -Wno-dev
>  }
>

This is cleaner than my implementation.

Acked By: Jack Mitchell <jack@embed.me.uk>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-07  9:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 21:41 [PATCH] cmake.bbclass: avoid treating imports as system includes Andreas Müller
2016-09-07  9:56 ` Jack Mitchell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.