* [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
@ 2023-07-26 9:21 Dmitry Antipov
2023-07-26 18:31 ` Jeff Johnson
2023-08-02 11:52 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Antipov @ 2023-07-26 9:21 UTC (permalink / raw)
To: Kalle Valo; +Cc: Ziyang Huang, linux-wireless, Dmitry Antipov
In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
list is not altered so 'list_for_each_entry()' should be safe.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 8c77ade49437..2aadf2c387b6 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -8255,7 +8255,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
const struct cfg80211_bitrate_mask *mask)
{
bool he_fixed_rate = false, vht_fixed_rate = false;
- struct ath11k_peer *peer, *tmp;
+ struct ath11k_peer *peer;
const u16 *vht_mcs_mask, *he_mcs_mask;
struct ieee80211_link_sta *deflink;
u8 vht_nss, he_nss;
@@ -8278,7 +8278,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
rcu_read_lock();
spin_lock_bh(&ar->ab->base_lock);
- list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
+ list_for_each_entry(peer, &ar->ab->peers, list) {
if (peer->sta) {
deflink = &peer->sta->deflink;
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
2023-07-26 9:21 [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings() Dmitry Antipov
@ 2023-07-26 18:31 ` Jeff Johnson
2023-08-02 11:52 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2023-07-26 18:31 UTC (permalink / raw)
To: Dmitry Antipov, Kalle Valo; +Cc: Ziyang Huang, linux-wireless, ath11k
On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
> list is not altered so 'list_for_each_entry()' should be safe.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 8c77ade49437..2aadf2c387b6 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -8255,7 +8255,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
> const struct cfg80211_bitrate_mask *mask)
> {
> bool he_fixed_rate = false, vht_fixed_rate = false;
> - struct ath11k_peer *peer, *tmp;
> + struct ath11k_peer *peer;
> const u16 *vht_mcs_mask, *he_mcs_mask;
> struct ieee80211_link_sta *deflink;
> u8 vht_nss, he_nss;
> @@ -8278,7 +8278,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>
> rcu_read_lock();
> spin_lock_bh(&ar->ab->base_lock);
> - list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
> + list_for_each_entry(peer, &ar->ab->peers, list) {
> if (peer->sta) {
> deflink = &peer->sta->deflink;
>
In the future please make sure driver-specific mailing lists are
included in your patches when they exist in the MAINTAINERS file. Adding
ath11k@lists.infradead.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
@ 2023-07-26 18:31 ` Jeff Johnson
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Johnson @ 2023-07-26 18:31 UTC (permalink / raw)
To: Dmitry Antipov, Kalle Valo; +Cc: Ziyang Huang, linux-wireless, ath11k
On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
> list is not altered so 'list_for_each_entry()' should be safe.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 8c77ade49437..2aadf2c387b6 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -8255,7 +8255,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
> const struct cfg80211_bitrate_mask *mask)
> {
> bool he_fixed_rate = false, vht_fixed_rate = false;
> - struct ath11k_peer *peer, *tmp;
> + struct ath11k_peer *peer;
> const u16 *vht_mcs_mask, *he_mcs_mask;
> struct ieee80211_link_sta *deflink;
> u8 vht_nss, he_nss;
> @@ -8278,7 +8278,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>
> rcu_read_lock();
> spin_lock_bh(&ar->ab->base_lock);
> - list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
> + list_for_each_entry(peer, &ar->ab->peers, list) {
> if (peer->sta) {
> deflink = &peer->sta->deflink;
>
In the future please make sure driver-specific mailing lists are
included in your patches when they exist in the MAINTAINERS file. Adding
ath11k@lists.infradead.org
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
2023-07-26 18:31 ` Jeff Johnson
@ 2023-07-27 16:33 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2023-07-27 16:33 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Dmitry Antipov, Ziyang Huang, linux-wireless, ath11k
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
>
>> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
>> list is not altered so 'list_for_each_entry()' should be safe.
>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>
> In the future please make sure driver-specific mailing lists are
> included in your patches when they exist in the MAINTAINERS file.
> Adding ath11k@lists.infradead.org
And this is actually v2, there was already v1 sent earlier this month:
https://patchwork.kernel.org/project/linux-wireless/patch/20230704174753.76968-1-dmantipov@yandex.ru/
Dmitry, PLEASE read our documentation from the wiki below. You need to
always mark the patch as v2 and provide a changelog what changed since
v1.
And especially slow down with the rate of patches you are submitting and
instead use that time to learn the process first.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
@ 2023-07-27 16:33 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2023-07-27 16:33 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Dmitry Antipov, Ziyang Huang, linux-wireless, ath11k
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 7/26/2023 2:21 AM, Dmitry Antipov wrote:
>
>> In 'ath11k_mac_validate_vht_he_fixed_rate_settings()', 'ar->ab->peers'
>> list is not altered so 'list_for_each_entry()' should be safe.
>> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
>
> In the future please make sure driver-specific mailing lists are
> included in your patches when they exist in the MAINTAINERS file.
> Adding ath11k@lists.infradead.org
And this is actually v2, there was already v1 sent earlier this month:
https://patchwork.kernel.org/project/linux-wireless/patch/20230704174753.76968-1-dmantipov@yandex.ru/
Dmitry, PLEASE read our documentation from the wiki below. You need to
always mark the patch as v2 and provide a changelog what changed since
v1.
And especially slow down with the rate of patches you are submitting and
instead use that time to learn the process first.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
2023-07-26 9:21 [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings() Dmitry Antipov
2023-07-26 18:31 ` Jeff Johnson
@ 2023-08-02 11:52 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2023-08-02 11:52 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Ziyang Huang, linux-wireless, Dmitry Antipov
Dmitry Antipov <dmantipov@yandex.ru> wrote:
> In ath11k_mac_validate_vht_he_fixed_rate_settings() ar->ab->peers
> list is not altered so list_for_each_entry() should be safe.
>
> Compile tested only.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
6f092c98dcfa wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230726092113.78794-1-dmantipov@yandex.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-02 11:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 9:21 [PATCH] wifi: ath11k: simplify ath11k_mac_validate_vht_he_fixed_rate_settings() Dmitry Antipov
2023-07-26 18:31 ` Jeff Johnson
2023-07-26 18:31 ` Jeff Johnson
2023-07-27 16:33 ` Kalle Valo
2023-07-27 16:33 ` Kalle Valo
2023-08-02 11:52 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.