From: David Christensen <drc@linux.vnet.ibm.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>,
yipeng1.wang@intel.com, byron.marohn@intel.com
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter
Date: Tue, 28 Sep 2021 08:52:45 -0700 [thread overview]
Message-ID: <b25121e8-6ad3-398b-b515-776ab8fd0b0c@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210928135839.3778960-1-pablo.de.lara.guarch@intel.com>
On 9/28/21 6:58 AM, Pablo de Lara wrote:
> rte_efd_create() function was using uint8_t for a socket bitmask,
> for one of its parameters.
> This limits the maximum of NUMA sockets to be 8.
> Changing to to uint64_t increases it to 64, which should be
> more future-proof.
>
> Coverity issue: 366390
> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
>
> v4: Set socket id in EFD tests
>
> v3: Fixed commit message
>
> v2: Fixed EFD tests
Results with v4 on a non-consecutive NUMA system:
$ lscpu
Architecture: ppc64le
Byte Order: Little Endian
CPU(s): 128
On-line CPU(s) list: 0-127
Thread(s) per core: 4
Core(s) per socket: 16
Socket(s): 2
NUMA node(s): 6
Model: 2.3 (pvr 004e 1203)
Model name: POWER9, altivec supported
CPU max MHz: 3800.0000
CPU min MHz: 2300.0000
L1d cache: 32K
L1i cache: 32K
L2 cache: 512K
L3 cache: 10240K
NUMA node0 CPU(s): 0-63
NUMA node8 CPU(s): 64-127
NUMA node252 CPU(s):
NUMA node253 CPU(s):
NUMA node254 CPU(s):
NUMA node255 CPU(s):
$ sudo /home/drc/src/dpdk/build/app/test/dpdk-test -l 64-127 -n 4 --no-pci
EAL: Detected 128 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: No available 1048576 kB hugepages reported
EAL: VFIO support initialized
APP: HPET is not enabled, using TSC as default timer
RTE>>efd_autotest
Entering test_add_delete
Entering test_efd_find_existing
Entering test_add_update_delete
Entering test_five_keys
Entering test_efd_creation_with_bad_parameters, **Errors are expected **
EFD: Allocating key array on socket 8 failed
EFD: At least one CPU socket must be enabled in the bitmask
EFD: Allocating EFD table management structure on socket 255 failed
# Test successful. No more errors expected
Evaluating table utilization and correctness, please wait
Added 2097152 Succeeded 2097152 Lost 0
Added 2097152 Succeeded 2097152 Lost 0
Added 2097152 Succeeded 2097152 Lost 0
Average table utilization = 100.00% (2097152/2097152)
Test OK
RTE>>efd_perf_autotest
Measuring performance, please wait
..........
Results (in CPU cycles/operation)
-----------------------------------
Keysize Add Lookup Lookup_bulk
Delete
4 471 17 11 59
8 502 18 14 73
16 542 23 21 81
32 662 37 36 97
48 782 54 53 110
64 881 75 74 119
9 512 18 16 75
13 539 23 22 84
37 726 48 47 115
40 726 47 46 112
Test OK
next prev parent reply other threads:[~2021-09-28 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:53 [dpdk-dev] [PATCH] efd: change data type of parameter Pablo de Lara
2021-09-13 18:18 ` Mcnamara, John
2021-09-14 7:10 ` David Marchand
2021-09-14 10:49 ` Kinsella, Ray
2021-09-14 18:20 ` David Christensen
2021-09-17 12:56 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2021-09-20 19:30 ` David Christensen
2021-09-28 14:18 ` De Lara Guarch, Pablo
2021-09-28 13:58 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2021-09-28 15:52 ` David Christensen [this message]
2021-09-29 7:51 ` De Lara Guarch, Pablo
2021-09-29 17:41 ` David Christensen
2021-09-29 18:13 ` Wang, Yipeng1
2021-10-01 14:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25121e8-6ad3-398b-b515-776ab8fd0b0c@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.