Re: [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper

From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper
Date: Wed, 23 Aug 2017 09:48:45 +0200	[thread overview]
Message-ID: <b258e891-dbaf-4512-ae2e-d9a1fc234ff2@redhat.com> (raw)
In-Reply-To: <20170823044926.GB21343@lemon>

On 23/08/2017 06:49, Fam Zheng wrote:
>> +
>> +    /* A simple feature negotation protocol, even though there is
>> +     * no optional feature right now.
>> +     */
>> +    if (pr_manager_helper_read(pr_mgr, &flags, sizeof(flags), errp) < 0) {
> Not returning the return value of pr_manager_helper_read()?.
> 
>> +        return -EINVAL;
>> +    }
>> +
>> +    flags = 0;
>> +    if (pr_manager_helper_write(pr_mgr, -1, &flags, sizeof(flags), errp) < 0) {
>> +        return -EINVAL;
> Same here.
> 

Sorry, I forgot to answer these.  The QIOChannel functions (and thus
pr_manager_helper_read/write) only answer -1 or QIO_CHANNEL_ERROR_BLOCK.
 I'll change read/write to return -EINVAL instead.

Paolo