Re: [Qemu-devel] [PATCH 08/10] scsi: build qemu-pr-helper

From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 08/10] scsi: build qemu-pr-helper
Date: Tue, 22 Aug 2017 18:04:39 +0200	[thread overview]
Message-ID: <d506d1cf-ae97-6554-b3fc-1a2ef3ab24ca@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+CpgwqgMP262gg+UNqM_8WUXsTCKtTzTTsSrZt5Srzxw@mail.gmail.com>

On 22/08/2017 16:34, Marc-André Lureau wrote:
> Could this be handled by udisk? It seems at first the problem is not
> specific to qemu.

Yes, possibly.  In practice, everybody else who uses persistent
reservations seems to run as root. :)

>> +static void usage(const char *name)
>> +{
>> +    (printf) (
> Why '(printf)' ? I noticed qemu-nbd use this too.
> 

It lets you use #ifdef inside the argument list.

>>
>> +        /* Stash one file descriptor per request.  */
>> +        if (nfds) {
>> +            for (i = 0; i < nfds; i++) {
>> +                if (client->fd == -1) {
>> +                    client->fd = fds[i++];
>> +                } else {
>> +                    close(fds[i]);
> 
> Isn't this a condition to close the client?

Yes, though I still have to go through the descriptors and close them.

Paolo