All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: "wanghai (M)" <wanghai38@huawei.com>,
	fbarrat@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: mpe@ellerman.id.au, imunsie@au1.ibm.com,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: Fix kobject memleak
Date: Thu, 4 Jun 2020 10:08:52 +1000	[thread overview]
Message-ID: <b26f09cd-4114-fbbe-c782-3c72f6201d95@linux.ibm.com> (raw)
In-Reply-To: <a9ecd617-c541-aeb1-2e94-93abba475279@huawei.com>

On 3/6/20 9:57 pm, wanghai (M) wrote:
> kfree(cr) can be called when 
> kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release() 
> is called.  The kobj_type here is afu_config_record_type

Of course, I missed that.

In that case

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>

Thanks for the fix!

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: "wanghai (M)" <wanghai38@huawei.com>,
	fbarrat@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linuxppc-dev@lists.ozlabs.org, imunsie@au1.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: Fix kobject memleak
Date: Thu, 4 Jun 2020 10:08:52 +1000	[thread overview]
Message-ID: <b26f09cd-4114-fbbe-c782-3c72f6201d95@linux.ibm.com> (raw)
In-Reply-To: <a9ecd617-c541-aeb1-2e94-93abba475279@huawei.com>

On 3/6/20 9:57 pm, wanghai (M) wrote:
> kfree(cr) can be called when 
> kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release() 
> is called.  The kobj_type here is afu_config_record_type

Of course, I missed that.

In that case

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>

Thanks for the fix!

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited

  reply	other threads:[~2020-06-04  0:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 12:07 [PATCH] cxl: Fix kobject memleak Wang Hai
2020-06-02 12:07 ` Wang Hai
2020-06-02 16:21 ` Frederic Barrat
2020-06-02 16:21   ` Frederic Barrat
2020-06-03 11:33 ` Andrew Donnellan
2020-06-03 11:33   ` Andrew Donnellan
2020-06-03 11:57   ` wanghai (M)
2020-06-03 11:57     ` wanghai (M)
2020-06-04  0:08     ` Andrew Donnellan [this message]
2020-06-04  0:08       ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b26f09cd-4114-fbbe-c782-3c72f6201d95@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=fbarrat@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=wanghai38@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.