* [U-Boot] [PATCH v2 1/4] mmc: meson: add MMC nodes to Meson GXBB DT
@ 2017-01-25 19:52 Heiner Kallweit
2017-01-26 22:52 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2017-01-25 19:52 UTC (permalink / raw)
To: u-boot
Copied from amlogic/meson-gx.dtsi on Linux with the interrupt
definition removed.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- no changes
---
arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi
index e502c24..3f357b4 100644
--- a/arch/arm/dts/meson-gxbb.dtsi
+++ b/arch/arm/dts/meson-gxbb.dtsi
@@ -329,6 +329,24 @@
#address-cells = <2>;
#size-cells = <2>;
ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>;
+
+ sd_emmc_a: mmc at 70000 {
+ compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
+ reg = <0x0 0x70000 0x0 0x2000>;
+ status = "disabled";
+ };
+
+ sd_emmc_b: mmc at 72000 {
+ compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
+ reg = <0x0 0x72000 0x0 0x2000>;
+ status = "disabled";
+ };
+
+ sd_emmc_c: mmc at 74000 {
+ compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
+ reg = <0x0 0x74000 0x0 0x2000>;
+ status = "disabled";
+ };
};
ethmac: ethernet at c9410000 {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 1/4] mmc: meson: add MMC nodes to Meson GXBB DT
2017-01-25 19:52 [U-Boot] [PATCH v2 1/4] mmc: meson: add MMC nodes to Meson GXBB DT Heiner Kallweit
@ 2017-01-26 22:52 ` Andreas Färber
2017-01-27 6:54 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2017-01-26 22:52 UTC (permalink / raw)
To: u-boot
Hi,
Am 25.01.2017 um 20:52 schrieb Heiner Kallweit:
> Copied from amlogic/meson-gx.dtsi on Linux with the interrupt
> definition removed.
Is there any reason to not sync the full .dtsi file and its dependent
headers from Linux like I did in my recent forward-port of Carlo's series?
If there is a reason to remove the interrupt definitions, you should
explain that here please.
Regards,
Andreas
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - no changes
> ---
> arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi
> index e502c24..3f357b4 100644
> --- a/arch/arm/dts/meson-gxbb.dtsi
> +++ b/arch/arm/dts/meson-gxbb.dtsi
> @@ -329,6 +329,24 @@
> #address-cells = <2>;
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>;
> +
> + sd_emmc_a: mmc at 70000 {
> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
> + reg = <0x0 0x70000 0x0 0x2000>;
> + status = "disabled";
> + };
> +
> + sd_emmc_b: mmc at 72000 {
> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
> + reg = <0x0 0x72000 0x0 0x2000>;
> + status = "disabled";
> + };
> +
> + sd_emmc_c: mmc at 74000 {
> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
> + reg = <0x0 0x74000 0x0 0x2000>;
> + status = "disabled";
> + };
> };
>
> ethmac: ethernet at c9410000 {
>
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 1/4] mmc: meson: add MMC nodes to Meson GXBB DT
2017-01-26 22:52 ` Andreas Färber
@ 2017-01-27 6:54 ` Heiner Kallweit
0 siblings, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2017-01-27 6:54 UTC (permalink / raw)
To: u-boot
Am 26.01.2017 um 23:52 schrieb Andreas F?rber:
> Hi,
>
> Am 25.01.2017 um 20:52 schrieb Heiner Kallweit:
>> Copied from amlogic/meson-gx.dtsi on Linux with the interrupt
>> definition removed.
>
> Is there any reason to not sync the full .dtsi file and its dependent
> headers from Linux like I did in my recent forward-port of Carlo's series?
>
AFAICS there is no support for members of the Meson GX family other than
GXBB in mainline uboot yet. So I chose to extend what is available now.
IMHO this dts tree structure can be added once support for other
GX chips will be added. I tried to avoid adding unnecessary complexity
to the driver patches.
> If there is a reason to remove the interrupt definitions, you should
> explain that here please.
>
The driver in uboot uses polling, so there's no need for irq definitions.
> Regards,
> Andreas
>
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> v2:
>> - no changes
>> ---
>> arch/arm/dts/meson-gxbb.dtsi | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/dts/meson-gxbb.dtsi b/arch/arm/dts/meson-gxbb.dtsi
>> index e502c24..3f357b4 100644
>> --- a/arch/arm/dts/meson-gxbb.dtsi
>> +++ b/arch/arm/dts/meson-gxbb.dtsi
>> @@ -329,6 +329,24 @@
>> #address-cells = <2>;
>> #size-cells = <2>;
>> ranges = <0x0 0x0 0x0 0xd0000000 0x0 0x200000>;
>> +
>> + sd_emmc_a: mmc at 70000 {
>> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
>> + reg = <0x0 0x70000 0x0 0x2000>;
>> + status = "disabled";
>> + };
>> +
>> + sd_emmc_b: mmc at 72000 {
>> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
>> + reg = <0x0 0x72000 0x0 0x2000>;
>> + status = "disabled";
>> + };
>> +
>> + sd_emmc_c: mmc at 74000 {
>> + compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc";
>> + reg = <0x0 0x74000 0x0 0x2000>;
>> + status = "disabled";
>> + };
>> };
>>
>> ethmac: ethernet at c9410000 {
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-27 6:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-25 19:52 [U-Boot] [PATCH v2 1/4] mmc: meson: add MMC nodes to Meson GXBB DT Heiner Kallweit
2017-01-26 22:52 ` Andreas Färber
2017-01-27 6:54 ` Heiner Kallweit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.