All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bartłomiej Święcki" <bartlomiej.swiecki@corp.ovh.com>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Proposition - latency histogram
Date: Mon, 9 Jan 2017 12:27:01 +0100	[thread overview]
Message-ID: <b2b52f75-0e26-2dac-df6a-ea7bfd91a973@corp.ovh.com> (raw)
In-Reply-To: <69bf4eec-3959-f021-ad8f-d1b6d3e2ceaf@corp.ovh.com>

Hi,

I've made a simple implementation of performance histograms. 
Implementation is not very sophisticated
but I think it could be a good start for more detailed discussion.

Here's the PR: https://github.com/ceph/ceph/pull/12829


Regards,
Bartek


On 11/28/2016 05:22 PM, Bartłomiej Święcki wrote:
> Hi,
>
>
> Currently we can query OSD for op latency but it's given as an 
> average. Average may not give
> the bets information in this case - i.e. spikes can easily get hidden 
> there.
>
> Instead of an average we could easily do a simple histogram - quantize 
> the latency into
> predefined set of time intervals, for each of them have a simple 
> performance counter,
> at each op increase one of them. Since those are per OSD, we could 
> have pretty high resolution
> with fractional memory usage, performance impact should be negligible 
> since only one (two if split
> into read and write) of those counters would be incremented per one 
> osd op.
>
> In addition we could also do this in 2D - each counter matching given 
> latency range and op size range.
> having such 2D table would show both latency histogram, request size 
> histogram and combinations of those
> (i.e. latency histogram of ~4k ops only).
>
> What do you think about this idea? I can prepare some code - a simple 
> proof of concept looks really
> straightforward to implement.
>
>
> Bartek
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  parent reply	other threads:[~2017-01-09 11:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 16:22 Proposition - latency histogram Bartłomiej Święcki
2016-11-28 16:46 ` Allen Samuels
2016-11-28 23:05   ` Milosz Tanski
2016-11-28 16:51 ` Sage Weil
2016-11-28 17:43   ` John Spray
2016-11-29  2:43     ` Josh Durgin
2017-01-09 11:27 ` Bartłomiej Święcki [this message]
2017-01-31 15:22   ` Bartłomiej Święcki
2017-01-31 15:33     ` Bartłomiej Święcki
2017-02-06 11:54       ` John Spray
2017-02-07 16:30         ` Bartłomiej Święcki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2b52f75-0e26-2dac-df6a-ea7bfd91a973@corp.ovh.com \
    --to=bartlomiej.swiecki@corp.ovh.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.