From: YueHaibing <yuehaibing@huawei.com> To: Nikolay Borisov <nborisov@suse.com>, Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com> Cc: <linux-btrfs@vger.kernel.org>, <kernel-janitors@vger.kernel.org> Subject: Re: [PATCH -next] btrfs: Remove set but not used variable 'fs_info' Date: Thu, 18 Apr 2019 15:34:14 +0800 [thread overview] Message-ID: <b2b59b30-e1de-bea3-d25b-ff3a10796f7d@huawei.com> (raw) In-Reply-To: <0d280de4-9ef4-1531-5bad-22ea15cc150c@suse.com> On 2019/4/18 14:37, Nikolay Borisov wrote: > > > On 18.04.19 г. 9:43 ч., YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> fs/btrfs/free-space-tree.c: In function 'load_free_space_tree': >> fs/btrfs/free-space-tree.c:1535:24: warning: >> variable 'fs_info' set but not used [-Wunused-but-set-variable] >> >> It's not used since commit 05e9d3137d47 ("btrfs: get fs_info from block group >> in search_free_space_info"), so can be removed. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> fs/btrfs/free-space-tree.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c >> index cfe9dfb0ff05..f5dc115ebba0 100644 >> --- a/fs/btrfs/free-space-tree.c >> +++ b/fs/btrfs/free-space-tree.c >> @@ -1532,14 +1532,12 @@ static int load_free_space_extents(struct btrfs_caching_control *caching_ctl, >> int load_free_space_tree(struct btrfs_caching_control *caching_ctl) >> { >> struct btrfs_block_group_cache *block_group; >> - struct btrfs_fs_info *fs_info; >> struct btrfs_free_space_info *info; >> struct btrfs_path *path; >> u32 extent_count, flags; >> int ret; >> >> block_group = caching_ctl->block_group; >> - fs_info = block_group->fs_info; > > What version is this patch based on? In current misc-next ( on which new > patches ought to be based and can be found at: currently has: This patch based on linux-next tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=05e9d3137d47 > > fs_info = block_group->fs_info; > root = fs_info->free_space_root; > > ...... > > if (extent_count != expected_extent_count) { > btrfs_err(fs_info, > > "incorrect extent count for %llu; counted > %u, expected %u", > block_group->key.objectid, extent_count, > > expected_extent_count); > > In short: nack > >> >> path = btrfs_alloc_path(); >> if (!path) >> >> >> >> > >
WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com> To: Nikolay Borisov <nborisov@suse.com>, Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>, David Sterba <dsterba@suse.com> Cc: linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] btrfs: Remove set but not used variable 'fs_info' Date: Thu, 18 Apr 2019 07:34:14 +0000 [thread overview] Message-ID: <b2b59b30-e1de-bea3-d25b-ff3a10796f7d@huawei.com> (raw) In-Reply-To: <0d280de4-9ef4-1531-5bad-22ea15cc150c@suse.com> On 2019/4/18 14:37, Nikolay Borisov wrote: > > > On 18.04.19 г. 9:43 ч., YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> fs/btrfs/free-space-tree.c: In function 'load_free_space_tree': >> fs/btrfs/free-space-tree.c:1535:24: warning: >> variable 'fs_info' set but not used [-Wunused-but-set-variable] >> >> It's not used since commit 05e9d3137d47 ("btrfs: get fs_info from block group >> in search_free_space_info"), so can be removed. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> fs/btrfs/free-space-tree.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c >> index cfe9dfb0ff05..f5dc115ebba0 100644 >> --- a/fs/btrfs/free-space-tree.c >> +++ b/fs/btrfs/free-space-tree.c >> @@ -1532,14 +1532,12 @@ static int load_free_space_extents(struct btrfs_caching_control *caching_ctl, >> int load_free_space_tree(struct btrfs_caching_control *caching_ctl) >> { >> struct btrfs_block_group_cache *block_group; >> - struct btrfs_fs_info *fs_info; >> struct btrfs_free_space_info *info; >> struct btrfs_path *path; >> u32 extent_count, flags; >> int ret; >> >> block_group = caching_ctl->block_group; >> - fs_info = block_group->fs_info; > > What version is this patch based on? In current misc-next ( on which new > patches ought to be based and can be found at: currently has: This patch based on linux-next tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id\x05e9d3137d47 > > fs_info = block_group->fs_info; > root = fs_info->free_space_root; > > ...... > > if (extent_count != expected_extent_count) { > btrfs_err(fs_info, > > "incorrect extent count for %llu; counted > %u, expected %u", > block_group->key.objectid, extent_count, > > expected_extent_count); > > In short: nack > >> >> path = btrfs_alloc_path(); >> if (!path) >> >> >> >> > >
next prev parent reply other threads:[~2019-04-18 7:34 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-18 6:43 [PATCH -next] btrfs: Remove set but not used variable 'fs_info' YueHaibing 2019-04-18 6:43 ` YueHaibing 2019-04-18 6:37 ` Nikolay Borisov 2019-04-18 6:37 ` Nikolay Borisov 2019-04-18 7:34 ` YueHaibing [this message] 2019-04-18 7:34 ` YueHaibing 2019-04-18 13:43 ` David Sterba 2019-04-18 13:43 ` David Sterba -- strict thread matches above, loose matches on Subject: below -- 2019-03-27 3:20 [PATCH -next] btrfs: remove set but not used variable 'fs_devices' YueHaibing 2019-03-27 3:20 ` YueHaibing 2019-03-28 14:27 ` David Sterba 2019-03-28 14:27 ` David Sterba 2018-12-15 6:31 [PATCH -next] btrfs: remove set but not used variable 'num_pages' YueHaibing 2018-12-15 6:31 ` YueHaibing 2018-12-17 3:02 ` Anand Jain 2019-01-04 15:51 ` David Sterba 2019-01-04 15:51 ` David Sterba 2018-11-08 2:14 [PATCH -next] btrfs: remove set but not used variable 'tree' YueHaibing 2018-11-08 2:14 ` YueHaibing 2018-11-08 6:53 ` Nikolay Borisov 2018-11-08 6:53 ` Nikolay Borisov 2018-11-08 12:11 ` David Sterba 2018-11-08 12:11 ` David Sterba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b2b59b30-e1de-bea3-d25b-ff3a10796f7d@huawei.com \ --to=yuehaibing@huawei.com \ --cc=clm@fb.com \ --cc=dsterba@suse.com \ --cc=josef@toxicpanda.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=nborisov@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.