* [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
@ 2023-07-24 12:17 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2023-07-24 12:17 UTC (permalink / raw)
To: Neil Armstrong, David Airlie, Daniel Vetter, Sam Ravnborg, Paul Cercueil
Cc: dri-devel, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver now uses the backlight interface, which breaks when that
is disabled:
ld.lld: error: undefined symbol: devm_backlight_device_register
Enforce the necessary Kconfig dependency to avoid this.
Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index e8c9f4613a4b4..b097b2507ac5b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -300,6 +300,7 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
config DRM_PANEL_SAMSUNG_LD9040
tristate "Samsung LD9040 RGB/SPI panel"
depends on OF && SPI
+ depends on BACKLIGHT_CLASS_DEVICE
select VIDEOMODE_HELPERS
config DRM_PANEL_LG_LB035Q02
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
@ 2023-07-24 12:17 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2023-07-24 12:17 UTC (permalink / raw)
To: Neil Armstrong, David Airlie, Daniel Vetter, Sam Ravnborg, Paul Cercueil
Cc: Arnd Bergmann, Linus Walleij, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver now uses the backlight interface, which breaks when that
is disabled:
ld.lld: error: undefined symbol: devm_backlight_device_register
Enforce the necessary Kconfig dependency to avoid this.
Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index e8c9f4613a4b4..b097b2507ac5b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -300,6 +300,7 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
config DRM_PANEL_SAMSUNG_LD9040
tristate "Samsung LD9040 RGB/SPI panel"
depends on OF && SPI
+ depends on BACKLIGHT_CLASS_DEVICE
select VIDEOMODE_HELPERS
config DRM_PANEL_LG_LB035Q02
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
2023-07-24 12:17 ` Arnd Bergmann
@ 2023-07-24 17:11 ` Sam Ravnborg
-1 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2023-07-24 17:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neil Armstrong, David Airlie, Daniel Vetter, Paul Cercueil,
Arnd Bergmann, Linus Walleij, dri-devel, linux-kernel
On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver now uses the backlight interface, which breaks when that
> is disabled:
>
> ld.lld: error: undefined symbol: devm_backlight_device_register
>
> Enforce the necessary Kconfig dependency to avoid this.
>
> Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I expect that someone else with drm-misc rights apply the patch.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
@ 2023-07-24 17:11 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2023-07-24 17:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neil Armstrong, Arnd Bergmann, linux-kernel, dri-devel, Paul Cercueil
On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver now uses the backlight interface, which breaks when that
> is disabled:
>
> ld.lld: error: undefined symbol: devm_backlight_device_register
>
> Enforce the necessary Kconfig dependency to avoid this.
>
> Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I expect that someone else with drm-misc rights apply the patch.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
2023-07-24 17:11 ` Sam Ravnborg
@ 2023-07-24 22:45 ` Paul Cercueil
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Cercueil @ 2023-07-24 22:45 UTC (permalink / raw)
To: Sam Ravnborg, Arnd Bergmann
Cc: Neil Armstrong, David Airlie, Daniel Vetter, Arnd Bergmann,
Linus Walleij, dri-devel, linux-kernel
Hi,
Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit :
> On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The driver now uses the backlight interface, which breaks when that
> > is disabled:
> >
> > ld.lld: error: undefined symbol: devm_backlight_device_register
> >
> > Enforce the necessary Kconfig dependency to avoid this.
> >
> > Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight
> > device")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> I expect that someone else with drm-misc rights apply the patch.
Pushed to drm-misc-next.
Thanks,
-Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency
@ 2023-07-24 22:45 ` Paul Cercueil
0 siblings, 0 replies; 6+ messages in thread
From: Paul Cercueil @ 2023-07-24 22:45 UTC (permalink / raw)
To: Sam Ravnborg, Arnd Bergmann
Cc: Neil Armstrong, Arnd Bergmann, linux-kernel, dri-devel
Hi,
Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit :
> On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The driver now uses the backlight interface, which breaks when that
> > is disabled:
> >
> > ld.lld: error: undefined symbol: devm_backlight_device_register
> >
> > Enforce the necessary Kconfig dependency to avoid this.
> >
> > Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight
> > device")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> I expect that someone else with drm-misc rights apply the patch.
Pushed to drm-misc-next.
Thanks,
-Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-24 22:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 12:17 [PATCH] drm/panel: ld9040: add backlight Kconfig dependency Arnd Bergmann
2023-07-24 12:17 ` Arnd Bergmann
2023-07-24 17:11 ` Sam Ravnborg
2023-07-24 17:11 ` Sam Ravnborg
2023-07-24 22:45 ` Paul Cercueil
2023-07-24 22:45 ` Paul Cercueil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.