* [PATCH] scsi: ibmvscsi_tgt: convert sysfs snprintf to sysfs_emit
@ 2022-11-27 12:44 KaiLong Wang
2022-11-28 19:30 ` Chaitanya Kulkarni
0 siblings, 1 reply; 2+ messages in thread
From: KaiLong Wang @ 2022-11-27 12:44 UTC (permalink / raw)
To: mikecyr, jejb, martin.petersen; +Cc: linux-scsi, target-devel, linux-kernel
Fix the following coccicheck warning:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: use
scnprintf or sprintf
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: use
scnprintf or sprintf
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: use
scnprintf or sprintf
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index e8770310a64b..d9a615306949 100644
--- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
+++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
@@ -3616,13 +3616,13 @@ static void ibmvscsis_remove(struct vio_dev *vdev)
static ssize_t system_id_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%s\n", system_id);
+ return sysfs_emit(buf, "%s\n", system_id);
}
static ssize_t partition_number_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%x\n", partition_number);
+ return sysfs_emit(buf, "%x\n", partition_number);
}
static ssize_t unit_address_show(struct device *dev,
@@ -3630,7 +3630,7 @@ static ssize_t unit_address_show(struct device *dev,
{
struct scsi_info *vscsi = container_of(dev, struct scsi_info, dev);
- return snprintf(buf, PAGE_SIZE, "%x\n", vscsi->dma_dev->unit_address);
+ return sysfs_emit(buf, "%x\n", vscsi->dma_dev->unit_address);
}
static int ibmvscsis_get_system_info(void)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: ibmvscsi_tgt: convert sysfs snprintf to sysfs_emit
2022-11-27 12:44 [PATCH] scsi: ibmvscsi_tgt: convert sysfs snprintf to sysfs_emit KaiLong Wang
@ 2022-11-28 19:30 ` Chaitanya Kulkarni
0 siblings, 0 replies; 2+ messages in thread
From: Chaitanya Kulkarni @ 2022-11-28 19:30 UTC (permalink / raw)
To: KaiLong Wang, mikecyr, jejb, martin.petersen
Cc: linux-scsi, target-devel, linux-kernel
On 11/27/22 04:44, KaiLong Wang wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: use
> scnprintf or sprintf
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: use
> scnprintf or sprintf
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: use
> scnprintf or sprintf
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-28 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 12:44 [PATCH] scsi: ibmvscsi_tgt: convert sysfs snprintf to sysfs_emit KaiLong Wang
2022-11-28 19:30 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.