From: Dan Murphy <dmurphy@ti.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] power_supply: Add additional health properties to the header
Date: Mon, 21 Oct 2019 14:35:15 -0500 [thread overview]
Message-ID: <b354bd2e-3fd8-eef9-6609-75d09210e745@ti.com> (raw)
In-Reply-To: <20191020122510.4llflz7s2kogcdbf@earth.universe>
Sebastian
On 10/20/19 7:25 AM, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Sep 30, 2019 at 09:31:35AM -0500, Dan Murphy wrote:
>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> You used OVERHEAT instead of HOT in the implementation,
> which makes sense to me, so please drop HOT here. Also
> this needs to be documented in the ABI documentation:
Hmm. To me OVERHEAT and HOT can mean two different things. I will
check the implementation but I would
prefer to use HOT.
If a battery or charger is HOT that may be expected to be within the
heat limits of the device being monitored but that it is hot.
Overheating means the device is above the expected upper thermal limit.
Or over the heat limit.
The user may want to take action within the hot range to cool the device
or may expect the device to run hot without over heating.
> Documentation/ABI/testing/sysfs-class-power
ACK
Dan
next prev parent reply other threads:[~2019-10-21 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:31 [PATCH 1/3] power_supply: Add additional health properties to the header Dan Murphy
2019-09-30 14:31 ` [PATCH 2/3] dt: power: Add the bq2515x family dt bindings Dan Murphy
2019-10-20 12:30 ` Sebastian Reichel
2019-10-21 19:36 ` Dan Murphy
2019-09-30 14:31 ` [PATCH 3/3] power: supply: bq2515x: Introduce the bq2515x family Dan Murphy
2019-10-20 12:15 ` Sebastian Reichel
2019-10-23 19:02 ` Dan Murphy
2019-10-20 12:43 ` Sebastian Reichel
2019-10-20 12:25 ` [PATCH 1/3] power_supply: Add additional health properties to the header Sebastian Reichel
2019-10-21 19:35 ` Dan Murphy [this message]
2020-05-15 19:31 [PATCH 0/3] Add JEITA properties and introduce the bq2515x charger Dan Murphy
2020-05-15 19:31 ` [PATCH 1/3] power_supply: Add additional health properties to the header Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b354bd2e-3fd8-eef9-6609-75d09210e745@ti.com \
--to=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.