All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: WANG Xuerui <i.qemu@xen0n.name>, qemu-devel@nongnu.org
Cc: Alistair.Francis@wdc.com, f4bug@amsat.org
Subject: Re: [PATCH 7/8] target/mips: Support TCG_TARGET_SIGNED_ADDR32
Date: Wed, 13 Oct 2021 15:24:06 -0700	[thread overview]
Message-ID: <b35c12cc-3c11-d34e-52ae-13b9fe18ae53@linaro.org> (raw)
In-Reply-To: <768cf292-1393-2076-e10f-d0147ad325a6@xen0n.name>

On 10/10/21 9:20 PM, WANG Xuerui wrote:
>> +++ b/tcg/mips/tcg-target-sa32.h
>> @@ -1 +1,9 @@
>> +/*
>> + * Do not set TCG_TARGET_SIGNED_ADDR32 for mips32;
>> + * TCG expects this to only be set for 64-bit hosts.
>> + */
>> +#ifdef __mips64
>> +#define TCG_TARGET_SIGNED_ADDR32 1
>> +#else
>>   #define TCG_TARGET_SIGNED_ADDR32 0
>> +#endif
> It looks like we never want to set TCG_TARGET_SIGNED_ADDR32 on 32-bit
> hosts; maybe a compile-time assert could be added somewhere for
> statically guaranteeing this?

I've placed a build-time assert in tcg/tcg.c.

>> -    if (TCG_TARGET_REG_BITS > TARGET_LONG_BITS) {
>> +    if (TCG_TARGET_REG_BITS > TARGET_LONG_BITS && !guest_base_signed_addr32) {
> Is there precedent of extracting predicates like this into some header
> for reuse? However I agree that the current expression conveys enough
> meaning without being overly complicated.

Depends on the expected scope of the predicate, I guess.

If it's private to tcg-target.c.inc, I'd put it in tcg.c.
If it's private to tcg in general, I'd put it in tcg-internal.h.
Beyond that, I guess it depends.

For this, I don't know what I'd call it that isn't more verbose than the expression itself.

r~


  reply	other threads:[~2021-10-13 22:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 17:43 [PATCH 0/8] tcg: support 32-bit guest addresses as signed Richard Henderson
2021-10-10 17:43 ` [PATCH 1/8] tcg: Add TCG_TARGET_SIGNED_ADDR32 Richard Henderson
2021-10-11  4:21   ` WANG Xuerui
2021-10-11  9:55   ` Alex Bennée
2021-10-11 22:07   ` Philippe Mathieu-Daudé
2021-10-11 23:16   ` Alistair Francis
2021-10-10 17:43 ` [PATCH 2/8] accel/tcg: Split out g2h_tlbe Richard Henderson
2021-10-11  4:22   ` WANG Xuerui
2021-10-11  9:55   ` Alex Bennée
2021-10-11 21:48   ` Philippe Mathieu-Daudé
2021-10-11 23:19   ` Alistair Francis
2021-10-10 17:43 ` [PATCH 3/8] accel/tcg: Support TCG_TARGET_SIGNED_ADDR32 for softmmu Richard Henderson
2021-10-11  4:30   ` WANG Xuerui
2021-10-11 15:27     ` Richard Henderson
2021-10-10 17:43 ` [PATCH 4/8] accel/tcg: Add guest_base_signed_addr32 for user-only Richard Henderson
2021-10-11 22:06   ` Philippe Mathieu-Daudé
2021-10-13  7:07   ` Alistair Francis
2021-10-10 17:43 ` [PATCH 5/8] linux-user: Support TCG_TARGET_SIGNED_ADDR32 Richard Henderson
2021-10-11 10:22   ` Alex Bennée
2021-10-11 15:32     ` Richard Henderson
2021-10-10 17:43 ` [PATCH 6/8] tcg/aarch64: " Richard Henderson
2021-10-11 10:28   ` Alex Bennée
2021-10-11 15:24     ` Richard Henderson
2021-10-13 21:05     ` Richard Henderson
2021-10-10 17:44 ` [PATCH 7/8] target/mips: " Richard Henderson
2021-10-11  4:20   ` WANG Xuerui
2021-10-13 22:24     ` Richard Henderson [this message]
2021-10-10 17:44 ` [PATCH 8/8] target/riscv: " Richard Henderson
2021-10-11 22:00   ` Philippe Mathieu-Daudé
2021-10-13  7:08   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b35c12cc-3c11-d34e-52ae-13b9fe18ae53@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=f4bug@amsat.org \
    --cc=i.qemu@xen0n.name \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.