All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/x86: dell: Make DELL_WMI_PRIVACY depend on DELL_WMI
@ 2021-10-11 13:23 Hans de Goede
  2021-10-11 13:26 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2021-10-11 13:23 UTC (permalink / raw)
  To: Mark Gross, Andy Shevchenko, Dell.Client.Kernel
  Cc: Hans de Goede, platform-driver-x86, Randy Dunlap

DELL_WMI_PRIVACY is a feature toggle for the main dell-wmi driver,
so it must depend on the Kconfig option which enables the main
dell-wmi driver.

Fixes: 8af9fa37b8a3 ("platform/x86: dell-privacy: Add support for Dell hardware privacy")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/dell/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
index 42513eab1d06..2fffa57e596e 100644
--- a/drivers/platform/x86/dell/Kconfig
+++ b/drivers/platform/x86/dell/Kconfig
@@ -167,6 +167,7 @@ config DELL_WMI
 config DELL_WMI_PRIVACY
 	bool "Dell WMI Hardware Privacy Support"
 	depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO
+	depends on DELL_WMI
 	help
 	  This option adds integration with the "Dell Hardware Privacy"
 	  feature of Dell laptops to the dell-wmi driver.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: dell: Make DELL_WMI_PRIVACY depend on DELL_WMI
  2021-10-11 13:23 [PATCH] platform/x86: dell: Make DELL_WMI_PRIVACY depend on DELL_WMI Hans de Goede
@ 2021-10-11 13:26 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-10-11 13:26 UTC (permalink / raw)
  To: Mark Gross, Andy Shevchenko, Dell.Client.Kernel
  Cc: platform-driver-x86, Randy Dunlap

Hi all,

On 10/11/21 3:23 PM, Hans de Goede wrote:
> DELL_WMI_PRIVACY is a feature toggle for the main dell-wmi driver,
> so it must depend on the Kconfig option which enables the main
> dell-wmi driver.
> 
> Fixes: 8af9fa37b8a3 ("platform/x86: dell-privacy: Add support for Dell hardware privacy")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I've added this to my review-hans (soon to be for-next) and fixes branches now.

Regards,

Hans


> ---
>  drivers/platform/x86/dell/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig
> index 42513eab1d06..2fffa57e596e 100644
> --- a/drivers/platform/x86/dell/Kconfig
> +++ b/drivers/platform/x86/dell/Kconfig
> @@ -167,6 +167,7 @@ config DELL_WMI
>  config DELL_WMI_PRIVACY
>  	bool "Dell WMI Hardware Privacy Support"
>  	depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO
> +	depends on DELL_WMI
>  	help
>  	  This option adds integration with the "Dell Hardware Privacy"
>  	  feature of Dell laptops to the dell-wmi driver.
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-11 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 13:23 [PATCH] platform/x86: dell: Make DELL_WMI_PRIVACY depend on DELL_WMI Hans de Goede
2021-10-11 13:26 ` Hans de Goede

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.