From: Tudor Ambarus <tudor.ambarus@linaro.org> To: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Cc: greg.malysa@timesys.com, Tudor Ambarus <tudor.ambarus@microchip.com>, Pratyush Yadav <pratyush@kernel.org>, Michael Walle <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, "open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/3] mtd: spi-nor: Add additional octal-mode page program flags to be checked during SFDP 4BAIT parsing Date: Mon, 26 Dec 2022 10:14:22 +0200 [thread overview] Message-ID: <b35ef623-4914-7bb5-5dde-181f6fe5856e@linaro.org> (raw) In-Reply-To: <20221202135539.271936-3-nathan.morrison@timesys.com> On 02.12.2022 15:55, Nathan Barrett-Morrison wrote: > This adds some support for automatically searching a chip's SFDP table for: you can drop ":" > and this new line > program commands: 1S-1S-8S, 1S-8S-8S > > Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> > --- > drivers/mtd/spi-nor/sfdp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c > index e4e87815ba94..e1b7547bf81e 100644 > --- a/drivers/mtd/spi-nor/sfdp.c > +++ b/drivers/mtd/spi-nor/sfdp.c > @@ -1089,6 +1089,14 @@ static int spi_nor_parse_4bait(struct spi_nor *nor, > spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_4_4], > SPINOR_OP_PP_1_4_4_4B, > SNOR_PROTO_1_4_4); > + if (pp_hwcaps & SNOR_HWCAPS_PP_1_1_8) > + spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_1_8], > + SPINOR_OP_PP_1_1_8_4B, > + SNOR_PROTO_1_1_8); > + if (pp_hwcaps & SNOR_HWCAPS_PP_1_8_8) > + spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_8_8], > + SPINOR_OP_PP_1_8_8_4B, > + SNOR_PROTO_1_8_8); Why did you choose to not add support for reads as well? > > for (i = 0; i < SNOR_ERASE_TYPE_MAX; i++) { > if (erase_mask & BIT(i))
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org> To: Nathan Barrett-Morrison <nathan.morrison@timesys.com> Cc: greg.malysa@timesys.com, Tudor Ambarus <tudor.ambarus@microchip.com>, Pratyush Yadav <pratyush@kernel.org>, Michael Walle <michael@walle.cc>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, "open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/3] mtd: spi-nor: Add additional octal-mode page program flags to be checked during SFDP 4BAIT parsing Date: Mon, 26 Dec 2022 10:14:22 +0200 [thread overview] Message-ID: <b35ef623-4914-7bb5-5dde-181f6fe5856e@linaro.org> (raw) In-Reply-To: <20221202135539.271936-3-nathan.morrison@timesys.com> On 02.12.2022 15:55, Nathan Barrett-Morrison wrote: > This adds some support for automatically searching a chip's SFDP table for: you can drop ":" > and this new line > program commands: 1S-1S-8S, 1S-8S-8S > > Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com> > --- > drivers/mtd/spi-nor/sfdp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c > index e4e87815ba94..e1b7547bf81e 100644 > --- a/drivers/mtd/spi-nor/sfdp.c > +++ b/drivers/mtd/spi-nor/sfdp.c > @@ -1089,6 +1089,14 @@ static int spi_nor_parse_4bait(struct spi_nor *nor, > spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_4_4], > SPINOR_OP_PP_1_4_4_4B, > SNOR_PROTO_1_4_4); > + if (pp_hwcaps & SNOR_HWCAPS_PP_1_1_8) > + spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_1_8], > + SPINOR_OP_PP_1_1_8_4B, > + SNOR_PROTO_1_1_8); > + if (pp_hwcaps & SNOR_HWCAPS_PP_1_8_8) > + spi_nor_set_pp_settings(¶ms_pp[SNOR_CMD_PP_1_8_8], > + SPINOR_OP_PP_1_8_8_4B, > + SNOR_PROTO_1_8_8); Why did you choose to not add support for reads as well? > > for (i = 0; i < SNOR_ERASE_TYPE_MAX; i++) { > if (erase_mask & BIT(i)) ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-12-26 8:14 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-02 13:55 [PATCH v4 0/3] mtd: spi-nor: Extend SFDP to support additional octal modes as per latest JEDEC standard Nathan Barrett-Morrison 2022-12-02 13:55 ` Nathan Barrett-Morrison 2022-12-02 13:55 ` [PATCH v4 1/3] mtd: spi-nor: Extend SFDP 4byte address instruction lookup table with new octal modes as per JEDEC JESD216F Nathan Barrett-Morrison 2022-12-02 13:55 ` Nathan Barrett-Morrison 2022-12-02 15:13 ` Michael Walle 2022-12-02 15:13 ` Michael Walle 2022-12-26 8:12 ` Tudor Ambarus 2022-12-26 8:12 ` Tudor Ambarus 2022-12-02 13:55 ` [PATCH v4 2/3] mtd: spi-nor: Add additional octal-mode page program flags to be checked during SFDP 4BAIT parsing Nathan Barrett-Morrison 2022-12-02 13:55 ` Nathan Barrett-Morrison 2022-12-02 15:16 ` Michael Walle 2022-12-02 15:16 ` Michael Walle 2022-12-26 8:14 ` Tudor Ambarus [this message] 2022-12-26 8:14 ` Tudor Ambarus 2022-12-02 13:55 ` [PATCH v4 3/3] mtd: spi-nor: Add support for IS25LX256 operating in 1S-8S-8S octal read mode Nathan Barrett-Morrison 2022-12-02 13:55 ` Nathan Barrett-Morrison 2022-12-02 15:20 ` Michael Walle 2022-12-02 15:20 ` Michael Walle 2022-12-03 4:32 ` kernel test robot 2022-12-03 4:32 ` kernel test robot 2022-12-03 7:44 ` kernel test robot 2022-12-03 7:44 ` kernel test robot 2022-12-26 8:04 ` Tudor Ambarus 2022-12-26 8:04 ` Tudor Ambarus 2022-12-26 8:17 ` Tudor Ambarus 2022-12-26 8:17 ` Tudor Ambarus 2022-12-27 12:37 ` Michael Walle 2022-12-27 12:37 ` Michael Walle 2022-12-27 13:24 ` Tudor Ambarus 2022-12-27 13:24 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b35ef623-4914-7bb5-5dde-181f6fe5856e@linaro.org \ --to=tudor.ambarus@linaro.org \ --cc=greg.malysa@timesys.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=michael@walle.cc \ --cc=miquel.raynal@bootlin.com \ --cc=nathan.morrison@timesys.com \ --cc=pratyush@kernel.org \ --cc=richard@nod.at \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.