All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Petre Pircalabu <ppircalabu@bitdefender.com>,
	Tamas K Lengyel <tamas@tklengyel.com>
Subject: Re: [PATCH 2/5] xen/vm-event: Expand vm_event_* spinlock macros and rename the lock
Date: Mon, 3 Jun 2019 17:02:51 +0300	[thread overview]
Message-ID: <b36620b6-1936-0de9-9785-27808bfaf53e@bitdefender.com> (raw)
In-Reply-To: <1559564728-17167-3-git-send-email-andrew.cooper3@citrix.com>

On 6/3/19 3:25 PM, Andrew Cooper wrote:
> These serve no purpose, but to add to the congnitive load of following
> the code.  Remove the level of indirection.
> 
> Furthermore, the lock protects all data in vm_event_domain, making
> ring_lock a poor choice of name.
> 
> For vm_event_get_response() and vm_event_grab_slot(), fold the exit
> paths to have a single unlock, as the compiler can't make this
> optimisation itself.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Petre Pircalabu <ppircalabu@bitdefender.com>,
	Tamas K Lengyel <tamas@tklengyel.com>
Subject: Re: [Xen-devel] [PATCH 2/5] xen/vm-event: Expand vm_event_* spinlock macros and rename the lock
Date: Mon, 3 Jun 2019 17:02:51 +0300	[thread overview]
Message-ID: <b36620b6-1936-0de9-9785-27808bfaf53e@bitdefender.com> (raw)
Message-ID: <20190603140251.DB1y6wIXxkM0vFeEDYqTq7kzj3O5w1BhrmuDlexPjJo@z> (raw)
In-Reply-To: <1559564728-17167-3-git-send-email-andrew.cooper3@citrix.com>

On 6/3/19 3:25 PM, Andrew Cooper wrote:
> These serve no purpose, but to add to the congnitive load of following
> the code.  Remove the level of indirection.
> 
> Furthermore, the lock protects all data in vm_event_domain, making
> ring_lock a poor choice of name.
> 
> For vm_event_get_response() and vm_event_grab_slot(), fold the exit
> paths to have a single unlock, as the compiler can't make this
> optimisation itself.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-06-03 14:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 12:25 [PATCH 0/5] xen/vm-event: Cleanup Andrew Cooper
2019-06-03 12:25 ` [Xen-devel] " Andrew Cooper
2019-06-03 12:25 ` [PATCH 1/5] xen/vm-event: Drop unused u_domctl parameter from vm_event_domctl() Andrew Cooper
2019-06-03 12:25   ` [Xen-devel] " Andrew Cooper
2019-06-03 13:52   ` Razvan Cojocaru
2019-06-03 13:52     ` [Xen-devel] " Razvan Cojocaru
2019-06-03 13:52   ` Jan Beulich
2019-06-03 13:52     ` [Xen-devel] " Jan Beulich
2019-06-03 12:25 ` [PATCH 2/5] xen/vm-event: Expand vm_event_* spinlock macros and rename the lock Andrew Cooper
2019-06-03 12:25   ` [Xen-devel] " Andrew Cooper
2019-06-03 14:02   ` Razvan Cojocaru [this message]
2019-06-03 14:02     ` Razvan Cojocaru
2019-06-03 12:25 ` [PATCH 3/5] xen/vm-event: Remove unnecessary vm_event_domain indirection Andrew Cooper
2019-06-03 12:25   ` [Xen-devel] " Andrew Cooper
2019-06-03 14:31   ` Razvan Cojocaru
2019-06-03 14:31     ` [Xen-devel] " Razvan Cojocaru
2019-06-03 12:25 ` [PATCH 4/5] xen/vm-event: Fix interactions with the vcpu list Andrew Cooper
2019-06-03 12:25   ` [Xen-devel] " Andrew Cooper
2019-06-03 14:56   ` Razvan Cojocaru
2019-06-03 14:56     ` [Xen-devel] " Razvan Cojocaru
2019-06-03 12:25 ` [PATCH 5/5] xen/vm-event: Misc fixups Andrew Cooper
2019-06-03 12:25   ` [Xen-devel] " Andrew Cooper
2019-06-03 14:16   ` Razvan Cojocaru
2019-06-03 14:16     ` [Xen-devel] " Razvan Cojocaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b36620b6-1936-0de9-9785-27808bfaf53e@bitdefender.com \
    --to=rcojocaru@bitdefender.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ppircalabu@bitdefender.com \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.