From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net> Cc: <stable@vger.kernel.org> Subject: Re: [PATCH] f2fs: let fill_super handle roll-forward errors Date: Tue, 15 Aug 2017 09:44:24 +0800 [thread overview] Message-ID: <b3aea107-b582-6949-a558-a94558a1f253@huawei.com> (raw) In-Reply-To: <20170811004204.24078-1-jaegeuk@kernel.org> Hi Jaegeuk, On 2017/8/11 8:42, Jaegeuk Kim wrote: > If we set CP_ERROR_FLAG in roll-forward error, f2fs is no longer to proceed > any IOs due to f2fs_cp_error(). But, for example, if some stale data is involved > on roll-forward process, we're able to get -ENOENT, getting fs stuck. > If we get any error, let fill_super set SBI_NEED_FSCK and try to recover back > to stable point. Before that, we have cleaned up all node/meta page cache, so we will get back to last checkpoint status, means losing fsynced datas for ever. Would it be better to just leave message reminding user to mount with disable_roll_forward or run fsck offline. Thanks, > > Cc: <stable@vger.kernel.org> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/recovery.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index a3d02613934a..f707d810c87d 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -649,8 +649,6 @@ int recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > } > > clear_sbi_flag(sbi, SBI_POR_DOING); > - if (err) > - set_ckpt_flags(sbi, CP_ERROR_FLAG); > mutex_unlock(&sbi->cp_mutex); > > /* let's drop all the directory inodes for clean checkpoint */ >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: stable@vger.kernel.org Subject: Re: [PATCH] f2fs: let fill_super handle roll-forward errors Date: Tue, 15 Aug 2017 09:44:24 +0800 [thread overview] Message-ID: <b3aea107-b582-6949-a558-a94558a1f253@huawei.com> (raw) In-Reply-To: <20170811004204.24078-1-jaegeuk@kernel.org> Hi Jaegeuk, On 2017/8/11 8:42, Jaegeuk Kim wrote: > If we set CP_ERROR_FLAG in roll-forward error, f2fs is no longer to proceed > any IOs due to f2fs_cp_error(). But, for example, if some stale data is involved > on roll-forward process, we're able to get -ENOENT, getting fs stuck. > If we get any error, let fill_super set SBI_NEED_FSCK and try to recover back > to stable point. Before that, we have cleaned up all node/meta page cache, so we will get back to last checkpoint status, means losing fsynced datas for ever. Would it be better to just leave message reminding user to mount with disable_roll_forward or run fsck offline. Thanks, > > Cc: <stable@vger.kernel.org> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/recovery.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index a3d02613934a..f707d810c87d 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -649,8 +649,6 @@ int recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) > } > > clear_sbi_flag(sbi, SBI_POR_DOING); > - if (err) > - set_ckpt_flags(sbi, CP_ERROR_FLAG); > mutex_unlock(&sbi->cp_mutex); > > /* let's drop all the directory inodes for clean checkpoint */ >
next prev parent reply other threads:[~2017-08-15 1:44 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-11 0:42 [PATCH] f2fs: let fill_super handle roll-forward errors Jaegeuk Kim 2017-08-15 1:44 ` Chao Yu [this message] 2017-08-15 1:44 ` Chao Yu 2017-08-15 3:22 ` Jaegeuk Kim 2017-08-15 11:45 ` Chao Yu 2017-08-15 11:45 ` Chao Yu 2017-08-15 16:42 ` Jaegeuk Kim 2017-08-16 1:17 ` Chao Yu 2017-08-16 1:17 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b3aea107-b582-6949-a558-a94558a1f253@huawei.com \ --to=yuchao0@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.