All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/mlx4: fix rxq interrupt memory corruption
@ 2017-11-09 13:50 Shahaf Shuler
  2017-11-09 13:57 ` Adrien Mazarguil
  0 siblings, 1 reply; 3+ messages in thread
From: Shahaf Shuler @ 2017-11-09 13:50 UTC (permalink / raw)
  To: adrien.mazarguil; +Cc: dev, stable

intr_vec allocation size was wrong causing a memory corruption.

Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management")
Cc: adrien.mazarguil@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx4/mlx4_intr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx4/mlx4_intr.c b/drivers/net/mlx4/mlx4_intr.c
index b17d109a3..50d197698 100644
--- a/drivers/net/mlx4/mlx4_intr.c
+++ b/drivers/net/mlx4/mlx4_intr.c
@@ -98,7 +98,7 @@ mlx4_rx_intr_vec_enable(struct priv *priv)
 	struct rte_intr_handle *intr_handle = &priv->intr_handle;
 
 	mlx4_rx_intr_vec_disable(priv);
-	intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n]));
+	intr_handle->intr_vec = malloc(n * sizeof(intr_handle->intr_vec[0]));
 	if (intr_handle->intr_vec == NULL) {
 		rte_errno = ENOMEM;
 		ERROR("failed to allocate memory for interrupt vector,"
-- 
2.12.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/mlx4: fix rxq interrupt memory corruption
  2017-11-09 13:50 [PATCH] net/mlx4: fix rxq interrupt memory corruption Shahaf Shuler
@ 2017-11-09 13:57 ` Adrien Mazarguil
  2017-11-10  9:08   ` [dpdk-stable] " Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-11-09 13:57 UTC (permalink / raw)
  To: Shahaf Shuler; +Cc: dev, stable

On Thu, Nov 09, 2017 at 03:50:49PM +0200, Shahaf Shuler wrote:
> intr_vec allocation size was wrong causing a memory corruption.
> 
> Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management")
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Thanks!

-- 
Adrien Mazarguil
6WIND

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] net/mlx4: fix rxq interrupt memory corruption
  2017-11-09 13:57 ` Adrien Mazarguil
@ 2017-11-10  9:08   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-10  9:08 UTC (permalink / raw)
  To: Adrien Mazarguil, Shahaf Shuler; +Cc: dev, stable

On 11/9/2017 5:57 AM, Adrien Mazarguil wrote:
> On Thu, Nov 09, 2017 at 03:50:49PM +0200, Shahaf Shuler wrote:
>> intr_vec allocation size was wrong causing a memory corruption.
>>
>> Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management")
>> Cc: adrien.mazarguil@6wind.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-10  9:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 13:50 [PATCH] net/mlx4: fix rxq interrupt memory corruption Shahaf Shuler
2017-11-09 13:57 ` Adrien Mazarguil
2017-11-10  9:08   ` [dpdk-stable] " Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.