[git pull] Input updates for v4.15-rc8

[git pull] Input updates for v4.15-rc8

[Dmitry Torokhov]

Hi Linus,

Please pull from:

	git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus

to receive updates for the input subsystem. You will get:

- a fix for use-after-free in Synaptics RMI4 driver
- correction to multitouch contact tracking on certain ALPS touchpads
  (whicj got broken when we tried to fix the 2-finger scrolling)
- touchpad on Lenovo T640p is switched over to SMbus/RMI
- a few device node refcount fixes

Changelog:
---------

Arnd Bergmann (1):
      Input: of_touchscreen - add MODULE_LICENSE

Johan Hovold (3):
      Input: twl4030-vibra - fix sibling-node lookup
      Input: twl6040-vibra - fix child-node lookup
      Input: 88pm860x-ts - fix child-node lookup

Nick Desaulniers (1):
      Input: synaptics-rmi4 - prevent UAF reported by KASAN

Nir Perry (1):
      Input: ALPS - fix multi-touch decoding on SS4 plus touchpads

王振杰 (1):
      Input: synaptics - Lenovo Thinkpad T460p devices should use RMI

Diffstat:
--------

 drivers/input/misc/twl4030-vibra.c         |  6 ++++--
 drivers/input/misc/twl6040-vibra.c         |  3 +--
 drivers/input/mouse/alps.c                 | 23 +++++++++++++----------
 drivers/input/mouse/alps.h                 | 10 ++++++----
 drivers/input/mouse/synaptics.c            |  1 +
 drivers/input/rmi4/rmi_driver.c            |  4 +++-
 drivers/input/touchscreen/88pm860x-ts.c    | 16 ++++++++++++----
 drivers/input/touchscreen/of_touchscreen.c |  4 ++++
 8 files changed, 44 insertions(+), 23 deletions(-)

Thanks.


-- 
Dmitry

Re: [git pull] Input updates for v4.15-rc8

[Jiri Slaby]

On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
> Please pull from:
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> 
> to receive updates for the input subsystem. You will get:
> 
...
> - touchpad on Lenovo T640p is switched over to SMbus/RMI
...

> 王振杰 (1):
>       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI

Hi,

one of openSUSE users with T460p reports that the touchpad is defunct
after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
problem.

The problem is:
 kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
 kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
current IRQ mask.
 kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
 kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
 kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
 kernel: rmi4_smbus 8-002c: Failed to resume device: -16
 kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
TX register (-16).

The downstream bug is at:
https://bugzilla.suse.com/show_bug.cgi?id=1079862

Any ideas?

thanks,
-- 
js
suse labs

Re: [git pull] Input updates for v4.15-rc8

[Dmitry Torokhov]

On Thu, Feb 08, 2018 at 11:04:22AM +0100, Jiri Slaby wrote:
> On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
> > Please pull from:
> > 
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> > 
> > to receive updates for the input subsystem. You will get:
> > 
> ...
> > - touchpad on Lenovo T640p is switched over to SMbus/RMI
> ...
> 
> > 王振杰 (1):
> >       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI
> 
> Hi,
> 
> one of openSUSE users with T460p reports that the touchpad is defunct
> after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
> problem.
> 
> The problem is:
>  kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
>  kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
> current IRQ mask.
>  kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
>  kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
>  kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
>  kernel: rmi4_smbus 8-002c: Failed to resume device: -16
>  kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
> TX register (-16).
> 
> The downstream bug is at:
> https://bugzilla.suse.com/show_bug.cgi?id=1079862
> 
> Any ideas?

Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right
on resume on that box. Can you ask the reporter to:

echo 1 > /sys/power/pm_print_times
suspend/resume

and send dmesg?

Thanks.

-- 
Dmitry

rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

[Jiri Slaby]

On 02/09/2018, 02:39 AM, Dmitry Torokhov wrote:
> On Thu, Feb 08, 2018 at 11:04:22AM +0100, Jiri Slaby wrote:
>> On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
>>> Please pull from:
>>>
>>> 	git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>
>>> to receive updates for the input subsystem. You will get:
>>>
>> ...
>>> - touchpad on Lenovo T640p is switched over to SMbus/RMI
>> ...
>>
>>> 王振杰 (1):
>>>       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI
>>
>> Hi,
>>
>> one of openSUSE users with T460p reports that the touchpad is defunct
>> after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
>> problem.
>>
>> The problem is:
>>  kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
>>  kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
>> current IRQ mask.
>>  kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
>>  kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
>>  kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
>>  kernel: rmi4_smbus 8-002c: Failed to resume device: -16
>>  kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
>> TX register (-16).
>>
>> The downstream bug is at:
>> https://bugzilla.suse.com/show_bug.cgi?id=1079862
>>
>> Any ideas?
> 
> Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right
> on resume on that box. Can you ask the reporter to:
> 
> echo 1 > /sys/power/pm_print_times
> suspend/resume

He uploaded it here:
https://bugzilla.suse.com/attachment.cgi?id=759933

thanks,
-- 
js
suse labs

Re: rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

[Marc-André Lureau]

Hi

On Tue, Feb 13, 2018 at 9:22 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> On 02/09/2018, 02:39 AM, Dmitry Torokhov wrote:
>> On Thu, Feb 08, 2018 at 11:04:22AM +0100, Jiri Slaby wrote:
>>> On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
>>>> Please pull from:
>>>>
>>>>     git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
>>>>
>>>> to receive updates for the input subsystem. You will get:
>>>>
>>> ...
>>>> - touchpad on Lenovo T640p is switched over to SMbus/RMI
>>> ...
>>>
>>>> 王振杰 (1):
>>>>       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI
>>>
>>> Hi,
>>>
>>> one of openSUSE users with T460p reports that the touchpad is defunct
>>> after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
>>> problem.
>>>
>>> The problem is:
>>>  kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
>>>  kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
>>> current IRQ mask.
>>>  kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
>>>  kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
>>>  kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
>>>  kernel: rmi4_smbus 8-002c: Failed to resume device: -16
>>>  kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
>>> TX register (-16).
>>>
>>> The downstream bug is at:
>>> https://bugzilla.suse.com/show_bug.cgi?id=1079862
>>>
>>> Any ideas?
>>
>> Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right
>> on resume on that box. Can you ask the reporter to:
>>
>> echo 1 > /sys/power/pm_print_times
>> suspend/resume
>
> He uploaded it here:
> https://bugzilla.suse.com/attachment.cgi?id=759933
>

Same problem (with f27 and upstream kernel), is there anything else we
can do to help? Should we open a bug on http://bugzilla.kernel.org ?

thanks

-- 
Marc-André Lureau

Re: rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

[Arkadiusz Hiler]

On Thu, Mar 01, 2018 at 02:22:10PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Feb 13, 2018 at 9:22 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> > On 02/09/2018, 02:39 AM, Dmitry Torokhov wrote:
> >> On Thu, Feb 08, 2018 at 11:04:22AM +0100, Jiri Slaby wrote:
> >>> On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
> >>>> Please pull from:
> >>>>
> >>>>     git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >>>>
> >>>> to receive updates for the input subsystem. You will get:
> >>>>
> >>> ...
> >>>> - touchpad on Lenovo T640p is switched over to SMbus/RMI
> >>> ...
> >>>
> >>>> 王振杰 (1):
> >>>>       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI
> >>>
> >>> Hi,
> >>>
> >>> one of openSUSE users with T460p reports that the touchpad is defunct
> >>> after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
> >>> problem.
> >>>
> >>> The problem is:
> >>>  kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
> >>>  kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
> >>> current IRQ mask.
> >>>  kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
> >>>  kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
> >>>  kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
> >>>  kernel: rmi4_smbus 8-002c: Failed to resume device: -16
> >>>  kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
> >>> TX register (-16).
> >>>
> >>> The downstream bug is at:
> >>> https://bugzilla.suse.com/show_bug.cgi?id=1079862
> >>>
> >>> Any ideas?
> >>
> >> Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right
> >> on resume on that box. Can you ask the reporter to:
> >>
> >> echo 1 > /sys/power/pm_print_times
> >> suspend/resume
> >
> > He uploaded it here:
> > https://bugzilla.suse.com/attachment.cgi?id=759933
> >
> 
> Same problem (with f27 and upstream kernel), is there anything else we
> can do to help? Should we open a bug on http://bugzilla.kernel.org ?
> 
> thanks

There are already two reverts on this mailing list that fix the problem.

https://patchwork.kernel.org/patch/10239877/
and
https://patchwork.kernel.org/patch/10228565/

Since the regression made it to the stable kernel and this is not moving
I think it's appropiate to cc Greg here.

- Arek

Re: rmi4 defunct on T460p [was: [git pull] Input updates for v4.15-rc8]

[Arkadiusz Hiler]

On Thu, Mar 01, 2018 at 02:22:10PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Feb 13, 2018 at 9:22 AM, Jiri Slaby <jslaby@suse.cz> wrote:
> > On 02/09/2018, 02:39 AM, Dmitry Torokhov wrote:
> >> On Thu, Feb 08, 2018 at 11:04:22AM +0100, Jiri Slaby wrote:
> >>> On 01/19/2018, 06:42 PM, Dmitry Torokhov wrote:
> >>>> Please pull from:
> >>>>
> >>>>     git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
> >>>>
> >>>> to receive updates for the input subsystem. You will get:
> >>>>
> >>> ...
> >>>> - touchpad on Lenovo T640p is switched over to SMbus/RMI
> >>> ...
> >>>
> >>>> 王振杰 (1):
> >>>>       Input: synaptics - Lenovo Thinkpad T460p devices should use RMI
> >>>
> >>> Hi,
> >>>
> >>> one of openSUSE users with T460p reports that the touchpad is defunct
> >>> after resume in 4.15. psmouse.synaptics_intertouch=0 works around the
> >>> problem.
> >>>
> >>> The problem is:
> >>>  kernel: rmi4_smbus 8-002c: failed to get SMBus version number!
> >>>  kernel: rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed to read
> >>> current IRQ mask.
> >>>  kernel: rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
> >>>  kernel: rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
> >>>  kernel: rmi4_physical rmi4-00: Failed to suspend functions: -16
> >>>  kernel: rmi4_smbus 8-002c: Failed to resume device: -16
> >>>  kernel: rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to write to F03
> >>> TX register (-16).
> >>>
> >>> The downstream bug is at:
> >>> https://bugzilla.suse.com/show_bug.cgi?id=1079862
> >>>
> >>> Any ideas?
> >>
> >> Hmm, maybe the seuence between psmouse and rmi/smbus is not quite right
> >> on resume on that box. Can you ask the reporter to:
> >>
> >> echo 1 > /sys/power/pm_print_times
> >> suspend/resume
> >
> > He uploaded it here:
> > https://bugzilla.suse.com/attachment.cgi?id=759933
> >
> 
> Same problem (with f27 and upstream kernel), is there anything else we
> can do to help? Should we open a bug on http://bugzilla.kernel.org ?
> 
> thanks

There are already two reverts on this mailing list that fix the problem.

https://patchwork.kernel.org/patch/10239877/
and
https://patchwork.kernel.org/patch/10228565/

Since the regression made it to the stable kernel and this is not moving
I think it's appropiate to cc Greg here.

- Arek