* [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource'
@ 2022-07-18 17:31 kernel test robot
2022-07-19 8:23 ` Ben Dooks
2022-07-19 8:52 ` [PATCH] reset: reset-simple should depends on HAS_IOMEM Ben Dooks
0 siblings, 2 replies; 5+ messages in thread
From: kernel test robot @ 2022-07-18 17:31 UTC (permalink / raw)
To: Ben Dooks; +Cc: llvm, kbuild-all, Linux Memory Management List, Philipp Zabel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 036ad6daa8f0fd357af7f50f9da58539eaa6f68c
commit: 18d1909be3451e1a2e322e9035f03d0a18f7bee8 [8797/11208] reset: allow building of reset simple driver if expert config selected
config: s390-randconfig-r032-20220718 (https://download.01.org/0day-ci/archive/20220719/202207190150.mf4rb4VG-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d74b88c69dc2644bd0dc5d64e2d7413a0d4040e5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=18d1909be3451e1a2e322e9035f03d0a18f7bee8
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 18d1909be3451e1a2e322e9035f03d0a18f7bee8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
/opt/cross/gcc-12.1.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/reset/reset-simple.o: in function `reset_simple_probe':
>> reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource'
2022-07-18 17:31 [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource' kernel test robot
@ 2022-07-19 8:23 ` Ben Dooks
2022-07-19 8:52 ` [PATCH] reset: reset-simple should depends on HAS_IOMEM Ben Dooks
1 sibling, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2022-07-19 8:23 UTC (permalink / raw)
To: kernel test robot
Cc: llvm, kbuild-all, Linux Memory Management List, Philipp Zabel
On 18/07/2022 18:31, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 036ad6daa8f0fd357af7f50f9da58539eaa6f68c
> commit: 18d1909be3451e1a2e322e9035f03d0a18f7bee8 [8797/11208] reset: allow building of reset simple driver if expert config selected
> config: s390-randconfig-r032-20220718 (https://download.01.org/0day-ci/archive/20220719/202207190150.mf4rb4VG-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d74b88c69dc2644bd0dc5d64e2d7413a0d4040e5)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install s390 cross compiling tool for clang build
> # apt-get install binutils-s390x-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=18d1909be3451e1a2e322e9035f03d0a18f7bee8
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout 18d1909be3451e1a2e322e9035f03d0a18f7bee8
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> /opt/cross/gcc-12.1.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/reset/reset-simple.o: in function `reset_simple_probe':
>>> reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
>
I think the reset-simple may need to depend on CONFIG_HAS_IOMEM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource'
@ 2022-07-19 8:23 ` Ben Dooks
0 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2022-07-19 8:23 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]
On 18/07/2022 18:31, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 036ad6daa8f0fd357af7f50f9da58539eaa6f68c
> commit: 18d1909be3451e1a2e322e9035f03d0a18f7bee8 [8797/11208] reset: allow building of reset simple driver if expert config selected
> config: s390-randconfig-r032-20220718 (https://download.01.org/0day-ci/archive/20220719/202207190150.mf4rb4VG-lkp(a)intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d74b88c69dc2644bd0dc5d64e2d7413a0d4040e5)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install s390 cross compiling tool for clang build
> # apt-get install binutils-s390x-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=18d1909be3451e1a2e322e9035f03d0a18f7bee8
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout 18d1909be3451e1a2e322e9035f03d0a18f7bee8
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> /opt/cross/gcc-12.1.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/reset/reset-simple.o: in function `reset_simple_probe':
>>> reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
>
I think the reset-simple may need to depend on CONFIG_HAS_IOMEM
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] reset: reset-simple should depends on HAS_IOMEM
2022-07-18 17:31 [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource' kernel test robot
2022-07-19 8:23 ` Ben Dooks
@ 2022-07-19 8:52 ` Ben Dooks
2022-07-20 8:41 ` Philipp Zabel
1 sibling, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2022-07-19 8:52 UTC (permalink / raw)
To: Philipp Zabel
Cc: linux-kernel, Sudip Mukherjee, Jude Onyenegecha, Ben Dooks,
kernel test robot
The reset-simple driver does not build on all architecuters as it requires
devm_ioremap_resource() which is only built when CONFIG_HAS_IOMEM is enabled
in the kenrel. Fix the following error by depending on CONFIG_HAS_IOMEM:
drivers/reset/reset-simple.o: in function `reset_simple_probe':
reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
Fixes: e87998582b50 ("reset: allow building of reset simple driver if expert config selected")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
---
drivers/reset/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index f40d9bbb686a..26c81bddf950 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -202,6 +202,7 @@ config RESET_SCMI
config RESET_SIMPLE
bool "Simple Reset Controller Driver" if COMPILE_TEST || EXPERT
default ARCH_ASPEED || ARCH_BCM4908 || ARCH_BITMAIN || ARCH_REALTEK || ARCH_STM32 || (ARCH_INTEL_SOCFPGA && ARM64) || ARCH_SUNXI || ARC
+ depends on HAS_IOMEM
help
This enables a simple reset controller driver for reset lines that
that can be asserted and deasserted by toggling bits in a contiguous,
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] reset: reset-simple should depends on HAS_IOMEM
2022-07-19 8:52 ` [PATCH] reset: reset-simple should depends on HAS_IOMEM Ben Dooks
@ 2022-07-20 8:41 ` Philipp Zabel
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2022-07-20 8:41 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, Sudip Mukherjee, Jude Onyenegecha, kernel test robot
Hi Ben,
On Di, 2022-07-19 at 09:52 +0100, Ben Dooks wrote:
> The reset-simple driver does not build on all architecuters as it requires
> devm_ioremap_resource() which is only built when CONFIG_HAS_IOMEM is enabled
> in the kenrel. Fix the following error by depending on CONFIG_HAS_IOMEM:
>
> drivers/reset/reset-simple.o: in function `reset_simple_probe':
> reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
>
> Fixes: e87998582b50 ("reset: allow building of reset simple driver if expert config selected")
Thank you, I changed this to:
Fixes: 18d1909be345 ("reset: allow building of reset simple driver if expert config selected")
and applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-20 8:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 17:31 [linux-next:master 8797/11208] reset-simple.c:undefined reference to `devm_ioremap_resource' kernel test robot
2022-07-19 8:23 ` Ben Dooks
2022-07-19 8:23 ` Ben Dooks
2022-07-19 8:52 ` [PATCH] reset: reset-simple should depends on HAS_IOMEM Ben Dooks
2022-07-20 8:41 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.