* [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname
@ 2020-09-17 7:44 Qilong Zhang
2020-09-17 9:41 ` Peter Ujfalusi
2020-09-17 11:21 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Qilong Zhang @ 2020-09-17 7:44 UTC (permalink / raw)
To: vkoul, dan.j.williams; +Cc: dmaengine
From: Zhang Qilong <zhangqilong3@huawei.com>
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/dma/ti/k3-udma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index de7bfc02a2de..eb29fdc9ffc1 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -3157,13 +3157,11 @@ static const struct soc_device_attribute k3_soc_devices[] = {
static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud)
{
- struct resource *res;
int i;
for (i = 0; i < MMR_LAST; i++) {
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
- mmr_names[i]);
- ud->mmrs[i] = devm_ioremap_resource(&pdev->dev, res);
+ ud->mmrs[i] = devm_platform_ioremap_resource_byname(pdev,
+ mmr_names[i]);
if (IS_ERR(ud->mmrs[i]))
return PTR_ERR(ud->mmrs[i]);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname
2020-09-17 7:44 [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname Qilong Zhang
@ 2020-09-17 9:41 ` Peter Ujfalusi
2020-09-17 11:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2020-09-17 9:41 UTC (permalink / raw)
To: Qilong Zhang, vkoul, dan.j.williams; +Cc: dmaengine
On 17/09/2020 10.44, Qilong Zhang wrote:
> From: Zhang Qilong <zhangqilong3@huawei.com>
>
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/dma/ti/k3-udma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index de7bfc02a2de..eb29fdc9ffc1 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -3157,13 +3157,11 @@ static const struct soc_device_attribute k3_soc_devices[] = {
>
> static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud)
> {
> - struct resource *res;
> int i;
>
> for (i = 0; i < MMR_LAST; i++) {
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - mmr_names[i]);
> - ud->mmrs[i] = devm_ioremap_resource(&pdev->dev, res);
> + ud->mmrs[i] = devm_platform_ioremap_resource_byname(pdev,
> + mmr_names[i]);
> if (IS_ERR(ud->mmrs[i]))
> return PTR_ERR(ud->mmrs[i]);
> }
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname
2020-09-17 7:44 [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname Qilong Zhang
2020-09-17 9:41 ` Peter Ujfalusi
@ 2020-09-17 11:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-09-17 11:21 UTC (permalink / raw)
To: Qilong Zhang; +Cc: dan.j.williams, dmaengine
On 17-09-20, 15:44, Qilong Zhang wrote:
> From: Zhang Qilong <zhangqilong3@huawei.com>
>
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/dma/ti/k3-udma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index de7bfc02a2de..eb29fdc9ffc1 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -3157,13 +3157,11 @@ static const struct soc_device_attribute k3_soc_devices[] = {
>
> static int udma_get_mmrs(struct platform_device *pdev, struct udma_dev *ud)
> {
> - struct resource *res;
> int i;
>
> for (i = 0; i < MMR_LAST; i++) {
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - mmr_names[i]);
> - ud->mmrs[i] = devm_ioremap_resource(&pdev->dev, res);
> + ud->mmrs[i] = devm_platform_ioremap_resource_byname(pdev,
> + mmr_names[i]);
One line please ;)
> if (IS_ERR(ud->mmrs[i]))
> return PTR_ERR(ud->mmrs[i]);
> }
> --
> 2.17.1
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-17 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 7:44 [PATCH -next] dmaengine: ti: k3-udma: use devm_platform_ioremap_resource_byname Qilong Zhang
2020-09-17 9:41 ` Peter Ujfalusi
2020-09-17 11:21 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.