From: Kirti Wankhede <kwankhede@nvidia.com> To: Cornelia Huck <cohuck@redhat.com> Cc: <alex.williamson@redhat.com>, <cjia@nvidia.com>, <kevin.tian@intel.com>, <ziye.yang@intel.com>, <changpeng.liu@intel.com>, <yi.l.liu@intel.com>, <mlevitsk@redhat.com>, <eskultet@redhat.com>, <dgilbert@redhat.com>, <jonathan.davies@nutanix.com>, <eauger@redhat.com>, <aik@ozlabs.ru>, <pasic@linux.ibm.com>, <felipe@nutanix.com>, <Zhengxiao.zx@Alibaba-inc.com>, <shuangtai.tst@alibaba-inc.com>, <Ken.Xue@amd.com>, <zhi.a.wang@intel.com>, <yan.y.zhao@intel.com>, <qemu-devel@nongnu.org>, <kvm@vger.kernel.org> Subject: Re: [PATCH Kernel v22 3/8] vfio iommu: Cache pgsize_bitmap in struct vfio_iommu Date: Wed, 20 May 2020 20:16:16 +0530 [thread overview] Message-ID: <b43ac210-56da-26ea-7235-0416c7b7ff84@nvidia.com> (raw) In-Reply-To: <20200520120825.7d8144ba.cohuck@redhat.com> On 5/20/2020 3:38 PM, Cornelia Huck wrote: > On Mon, 18 May 2020 11:26:32 +0530 > Kirti Wankhede <kwankhede@nvidia.com> wrote: > >> Calculate and cache pgsize_bitmap when iommu->domain_list is updated >> and iommu->external_domain is set for mdev device. >> Add iommu->lock protection when cached pgsize_bitmap is accessed. >> >> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com> >> Reviewed-by: Neo Jia <cjia@nvidia.com> >> --- >> drivers/vfio/vfio_iommu_type1.c | 88 +++++++++++++++++++++++------------------ >> 1 file changed, 49 insertions(+), 39 deletions(-) >> > > (...) > >> @@ -805,15 +806,14 @@ static void vfio_remove_dma(struct vfio_iommu *iommu, struct vfio_dma *dma) >> iommu->dma_avail++; >> } >> >> -static unsigned long vfio_pgsize_bitmap(struct vfio_iommu *iommu) >> +static void vfio_pgsize_bitmap(struct vfio_iommu *iommu) > > Minor nit: I'd have renamed this function to > vfio_update_pgsize_bitmap(). > Done. >> { >> struct vfio_domain *domain; >> - unsigned long bitmap = ULONG_MAX; >> >> - mutex_lock(&iommu->lock); >> + iommu->pgsize_bitmap = ULONG_MAX; >> + >> list_for_each_entry(domain, &iommu->domain_list, next) >> - bitmap &= domain->domain->pgsize_bitmap; >> - mutex_unlock(&iommu->lock); >> + iommu->pgsize_bitmap &= domain->domain->pgsize_bitmap; >> >> /* >> * In case the IOMMU supports page sizes smaller than PAGE_SIZE > > (...) > > Reviewed-by: Cornelia Huck <cohuck@redhat.com> > Thanks. Kirti
WARNING: multiple messages have this Message-ID (diff)
From: Kirti Wankhede <kwankhede@nvidia.com> To: Cornelia Huck <cohuck@redhat.com> Cc: kevin.tian@intel.com, yi.l.liu@intel.com, cjia@nvidia.com, kvm@vger.kernel.org, eskultet@redhat.com, ziye.yang@intel.com, qemu-devel@nongnu.org, Zhengxiao.zx@Alibaba-inc.com, shuangtai.tst@alibaba-inc.com, dgilbert@redhat.com, zhi.a.wang@intel.com, mlevitsk@redhat.com, pasic@linux.ibm.com, aik@ozlabs.ru, alex.williamson@redhat.com, eauger@redhat.com, felipe@nutanix.com, jonathan.davies@nutanix.com, yan.y.zhao@intel.com, changpeng.liu@intel.com, Ken.Xue@amd.com Subject: Re: [PATCH Kernel v22 3/8] vfio iommu: Cache pgsize_bitmap in struct vfio_iommu Date: Wed, 20 May 2020 20:16:16 +0530 [thread overview] Message-ID: <b43ac210-56da-26ea-7235-0416c7b7ff84@nvidia.com> (raw) In-Reply-To: <20200520120825.7d8144ba.cohuck@redhat.com> On 5/20/2020 3:38 PM, Cornelia Huck wrote: > On Mon, 18 May 2020 11:26:32 +0530 > Kirti Wankhede <kwankhede@nvidia.com> wrote: > >> Calculate and cache pgsize_bitmap when iommu->domain_list is updated >> and iommu->external_domain is set for mdev device. >> Add iommu->lock protection when cached pgsize_bitmap is accessed. >> >> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com> >> Reviewed-by: Neo Jia <cjia@nvidia.com> >> --- >> drivers/vfio/vfio_iommu_type1.c | 88 +++++++++++++++++++++++------------------ >> 1 file changed, 49 insertions(+), 39 deletions(-) >> > > (...) > >> @@ -805,15 +806,14 @@ static void vfio_remove_dma(struct vfio_iommu *iommu, struct vfio_dma *dma) >> iommu->dma_avail++; >> } >> >> -static unsigned long vfio_pgsize_bitmap(struct vfio_iommu *iommu) >> +static void vfio_pgsize_bitmap(struct vfio_iommu *iommu) > > Minor nit: I'd have renamed this function to > vfio_update_pgsize_bitmap(). > Done. >> { >> struct vfio_domain *domain; >> - unsigned long bitmap = ULONG_MAX; >> >> - mutex_lock(&iommu->lock); >> + iommu->pgsize_bitmap = ULONG_MAX; >> + >> list_for_each_entry(domain, &iommu->domain_list, next) >> - bitmap &= domain->domain->pgsize_bitmap; >> - mutex_unlock(&iommu->lock); >> + iommu->pgsize_bitmap &= domain->domain->pgsize_bitmap; >> >> /* >> * In case the IOMMU supports page sizes smaller than PAGE_SIZE > > (...) > > Reviewed-by: Cornelia Huck <cohuck@redhat.com> > Thanks. Kirti
next prev parent reply other threads:[~2020-05-20 14:46 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-18 5:56 [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 1/8] vfio: UAPI for migration interface for device state Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 2/8] vfio iommu: Remove atomicity of ref_count of pinned pages Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 3/8] vfio iommu: Cache pgsize_bitmap in struct vfio_iommu Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-20 10:08 ` Cornelia Huck 2020-05-20 10:08 ` Cornelia Huck 2020-05-20 14:46 ` Kirti Wankhede [this message] 2020-05-20 14:46 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 4/8] vfio iommu: Add ioctl definition for dirty pages tracking Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 5/8] vfio iommu: Implementation of ioctl " Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-18 21:53 ` Alex Williamson 2020-05-18 21:53 ` Alex Williamson 2020-05-19 7:11 ` Kirti Wankhede 2020-05-19 7:11 ` Kirti Wankhede 2020-05-19 6:52 ` Kirti Wankhede 2020-05-19 6:52 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 6/8] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-19 6:54 ` Kirti Wankhede 2020-05-19 6:54 ` Kirti Wankhede 2020-05-20 10:27 ` Cornelia Huck 2020-05-20 10:27 ` Cornelia Huck 2020-05-20 15:16 ` Kirti Wankhede 2020-05-20 15:16 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 7/8] vfio iommu: Add migration capability to report supported features Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-20 10:42 ` Cornelia Huck 2020-05-20 10:42 ` Cornelia Huck 2020-05-20 15:23 ` Kirti Wankhede 2020-05-20 15:23 ` Kirti Wankhede 2020-05-18 5:56 ` [PATCH Kernel v22 8/8] vfio: Selective dirty page tracking if IOMMU backed device pins pages Kirti Wankhede 2020-05-18 5:56 ` Kirti Wankhede 2020-05-19 6:54 ` Kirti Wankhede 2020-05-19 6:54 ` Kirti Wankhede 2020-05-19 16:58 ` [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices Alex Williamson 2020-05-19 16:58 ` Alex Williamson 2020-05-20 2:55 ` Yan Zhao 2020-05-20 2:55 ` Yan Zhao 2020-05-20 13:40 ` Kirti Wankhede 2020-05-20 13:40 ` Kirti Wankhede 2020-05-20 16:46 ` Alex Williamson 2020-05-20 16:46 ` Alex Williamson 2020-05-21 5:08 ` Yan Zhao 2020-05-21 5:08 ` Yan Zhao 2020-05-21 7:09 ` Kirti Wankhede 2020-05-21 7:09 ` Kirti Wankhede 2020-05-21 7:04 ` Yan Zhao 2020-05-21 7:04 ` Yan Zhao 2020-05-21 7:28 ` Kirti Wankhede 2020-05-21 7:28 ` Kirti Wankhede 2020-05-21 7:32 ` Kirti Wankhede 2020-05-21 7:32 ` Kirti Wankhede 2020-05-25 6:59 ` Yan Zhao 2020-05-25 6:59 ` Yan Zhao 2020-05-25 13:20 ` Kirti Wankhede 2020-05-25 13:20 ` Kirti Wankhede 2020-05-26 20:19 ` Alex Williamson 2020-05-26 20:19 ` Alex Williamson 2020-05-27 6:23 ` Yan Zhao 2020-05-27 6:23 ` Yan Zhao 2020-05-27 8:48 ` Dr. David Alan Gilbert 2020-05-27 8:48 ` Dr. David Alan Gilbert 2020-05-28 8:01 ` Yan Zhao 2020-05-28 8:01 ` Yan Zhao 2020-05-28 22:53 ` Alex Williamson 2020-05-28 22:53 ` Alex Williamson 2020-05-29 11:12 ` Dr. David Alan Gilbert 2020-05-29 11:12 ` Dr. David Alan Gilbert 2020-05-28 22:59 ` Alex Williamson 2020-05-28 22:59 ` Alex Williamson 2020-05-29 4:15 ` Yan Zhao 2020-05-29 4:15 ` Yan Zhao 2020-05-29 17:57 ` Kirti Wankhede 2020-05-29 17:57 ` Kirti Wankhede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b43ac210-56da-26ea-7235-0416c7b7ff84@nvidia.com \ --to=kwankhede@nvidia.com \ --cc=Ken.Xue@amd.com \ --cc=Zhengxiao.zx@Alibaba-inc.com \ --cc=aik@ozlabs.ru \ --cc=alex.williamson@redhat.com \ --cc=changpeng.liu@intel.com \ --cc=cjia@nvidia.com \ --cc=cohuck@redhat.com \ --cc=dgilbert@redhat.com \ --cc=eauger@redhat.com \ --cc=eskultet@redhat.com \ --cc=felipe@nutanix.com \ --cc=jonathan.davies@nutanix.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=mlevitsk@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=qemu-devel@nongnu.org \ --cc=shuangtai.tst@alibaba-inc.com \ --cc=yan.y.zhao@intel.com \ --cc=yi.l.liu@intel.com \ --cc=zhi.a.wang@intel.com \ --cc=ziye.yang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.