[PATCH 1/1] huawei: use AT^SYSCFG for radio setting operations on 3G only modems

[PATCH 1/1] huawei: use AT^SYSCFG for radio setting operations on 3G only modems

[Christophe Ronco]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

AT^SYSCFGEX must be used on LTE Huawei modems to enable LTE support.
But some modems (or firmwares?) do not support this command and AT^SYSCFG
must be used to get/set radio settings.
This has been introduced in commit:
22adf6402c828f8b8cca1b65d8a46ba7792eb787

There is a bug in this commit and AT^SYSCFGEX commands are used even on
modems not supporting it.
---
 drivers/huaweimodem/radio-settings.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c
index 40431d3..20181d2 100644
--- a/drivers/huaweimodem/radio-settings.c
+++ b/drivers/huaweimodem/radio-settings.c
@@ -532,6 +532,7 @@ static void syscfgex_support_cb(gboolean ok, GAtResult *result,
 	if (!ok) {
 		g_at_chat_send(rsd->chat, "AT^SYSCFG=?", syscfg_prefix,
 					syscfg_support_cb, rs, NULL);
+		return;
 	}
 
 	rsd->syscfgex_cap = 1;
-- 
2.7.4

Re: [PATCH 1/1] huawei: use AT^SYSCFG for radio setting operations on 3G only modems

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi Christophe,

On 6/11/20 4:12 AM, Christophe Ronco wrote:
> AT^SYSCFGEX must be used on LTE Huawei modems to enable LTE support.
> But some modems (or firmwares?) do not support this command and AT^SYSCFG
> must be used to get/set radio settings.
> This has been introduced in commit:
> 22adf6402c828f8b8cca1b65d8a46ba7792eb787
> 
> There is a bug in this commit and AT^SYSCFGEX commands are used even on
> modems not supporting it.
> ---
>   drivers/huaweimodem/radio-settings.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Applied, thanks.

Regards,
-Denis