From: AngeloGioacchino Del Regno <kholk11@gmail.com> To: Marc Zyngier <marc.zyngier@arm.com>, Will Deacon <will.deacon@arm.com> Cc: Jens Axboe <axboe@kernel.dk>, Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] arm64/io: Don't use WZR in writel Date: Mon, 11 Feb 2019 17:15:45 +0100 [thread overview] Message-ID: <b45065a61ac79add6dfa9d63131faf6f3761cb6b.camel@gmail.com> (raw) In-Reply-To: <235d20ef-3054-69d9-975d-25aebf32aad3@arm.com> Il giorno lun, 11/02/2019 alle 14.59 +0000, Marc Zyngier ha scritto: > On 11/02/2019 14:29, AngeloGioacchino Del Regno wrote: > > [...] > > > Also, just one more thing: yes this thing is going ARM64-wide and > > - from my findings - it's targeting certain Qualcomm SoCs, but... > > I'm not sure that only QC is affected by that, others may as well > > have the same stupid bug. > > > > At the moment, only QC SoCs seem to be affected, probably because > everyone else has debugged their hypervisor (or most likely doesn't > bother with shipping one). > Between all the ARM SoCs, as far as I know, the only (?) ones using actual "smartphones", so actually provisioned SoCs, for upstream development are using Qualcomm SoCs.. of which, some development boards are not entirely security enabled, or have got newer firmwares which can't be used on production phones etc, so.. that's why I said that I'm not sure that only QC is affected. It's just relative to what we currently know, but looking at, for example, MediaTek, I'm not sure that the only bugged hypervisor is on QC (because MTK is very similar on certain aspects). I mean, it's highly possible that some other is affected and we don't know (and we possibly don't care...). > In all honesty, we need some information from QC here: which SoCs are > affected, what is the exact nature of the bug, can it be triggered > from It'd be wonderful if Qualcomm gives us some information about that. Would really be helpful and nice from them. > EL0. Randomly papering over symptoms is not something I really like > doing, and is likely to generate problems on unaffected systems. > > Thanks, > > M. I also don't like "randomly papering over symptoms", I totally agree with you on that... but this change potentially generating problems on unaffected systems is something I don't really agree on: this is a partial revert of a commit that was done purely to introduce some vmlinux (relatively small) size saving on ARM64 and no other reason (as far as I can read on the original commit), so I really don't think that my partial revert could ever harm anything. Though, this is a personal opinion, I can be right, but I can obviously be totally wrong on that. Though I have to make this clear: if there's another (better/cleaner) solution to this issue, I'd be totally happy (and, of course, curious too) to see it!
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <kholk11@gmail.com> To: Marc Zyngier <marc.zyngier@arm.com>, Will Deacon <will.deacon@arm.com> Cc: Jens Axboe <axboe@kernel.dk>, Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] arm64/io: Don't use WZR in writel Date: Mon, 11 Feb 2019 17:15:45 +0100 [thread overview] Message-ID: <b45065a61ac79add6dfa9d63131faf6f3761cb6b.camel@gmail.com> (raw) In-Reply-To: <235d20ef-3054-69d9-975d-25aebf32aad3@arm.com> Il giorno lun, 11/02/2019 alle 14.59 +0000, Marc Zyngier ha scritto: > On 11/02/2019 14:29, AngeloGioacchino Del Regno wrote: > > [...] > > > Also, just one more thing: yes this thing is going ARM64-wide and > > - from my findings - it's targeting certain Qualcomm SoCs, but... > > I'm not sure that only QC is affected by that, others may as well > > have the same stupid bug. > > > > At the moment, only QC SoCs seem to be affected, probably because > everyone else has debugged their hypervisor (or most likely doesn't > bother with shipping one). > Between all the ARM SoCs, as far as I know, the only (?) ones using actual "smartphones", so actually provisioned SoCs, for upstream development are using Qualcomm SoCs.. of which, some development boards are not entirely security enabled, or have got newer firmwares which can't be used on production phones etc, so.. that's why I said that I'm not sure that only QC is affected. It's just relative to what we currently know, but looking at, for example, MediaTek, I'm not sure that the only bugged hypervisor is on QC (because MTK is very similar on certain aspects). I mean, it's highly possible that some other is affected and we don't know (and we possibly don't care...). > In all honesty, we need some information from QC here: which SoCs are > affected, what is the exact nature of the bug, can it be triggered > from It'd be wonderful if Qualcomm gives us some information about that. Would really be helpful and nice from them. > EL0. Randomly papering over symptoms is not something I really like > doing, and is likely to generate problems on unaffected systems. > > Thanks, > > M. I also don't like "randomly papering over symptoms", I totally agree with you on that... but this change potentially generating problems on unaffected systems is something I don't really agree on: this is a partial revert of a commit that was done purely to introduce some vmlinux (relatively small) size saving on ARM64 and no other reason (as far as I can read on the original commit), so I really don't think that my partial revert could ever harm anything. Though, this is a personal opinion, I can be right, but I can obviously be totally wrong on that. Though I have to make this clear: if there's another (better/cleaner) solution to this issue, I'd be totally happy (and, of course, curious too) to see it! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 16:15 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-09 18:34 [PATCH] arm64/io: Don't use WZR in writel AngeloGioacchino Del Regno 2019-02-09 18:34 ` AngeloGioacchino Del Regno 2019-02-09 18:34 ` AngeloGioacchino Del Regno 2019-02-11 10:57 ` Will Deacon 2019-02-11 10:57 ` Will Deacon 2019-02-11 11:52 ` Marc Zyngier 2019-02-11 11:52 ` Marc Zyngier 2019-02-11 14:29 ` AngeloGioacchino Del Regno 2019-02-11 14:29 ` AngeloGioacchino Del Regno 2019-02-11 14:59 ` Marc Zyngier 2019-02-11 14:59 ` Marc Zyngier 2019-02-11 16:15 ` AngeloGioacchino Del Regno [this message] 2019-02-11 16:15 ` AngeloGioacchino Del Regno 2019-02-11 16:37 ` Robin Murphy 2019-02-11 16:37 ` Robin Murphy 2019-02-23 18:12 ` Bjorn Andersson 2019-02-23 18:12 ` Bjorn Andersson 2019-02-23 18:37 ` Marc Zyngier 2019-02-23 18:37 ` Marc Zyngier 2019-02-23 18:37 ` Marc Zyngier 2019-02-24 3:53 ` Bjorn Andersson 2019-02-24 3:53 ` Bjorn Andersson 2019-03-12 12:36 ` Marc Gonzalez 2019-03-12 12:36 ` Marc Gonzalez 2019-03-18 16:04 ` Robin Murphy 2019-03-18 16:04 ` Robin Murphy 2019-03-18 17:00 ` Russell King - ARM Linux admin 2019-03-18 17:00 ` Russell King - ARM Linux admin 2019-03-18 17:11 ` Ard Biesheuvel 2019-03-18 17:11 ` Ard Biesheuvel 2019-03-18 17:19 ` Robin Murphy 2019-03-18 17:19 ` Robin Murphy 2019-03-18 17:24 ` Robin Murphy 2019-03-18 17:24 ` Robin Murphy 2019-03-19 11:45 ` Robin Murphy 2019-03-19 11:45 ` Robin Murphy 2019-03-18 17:30 ` Marc Gonzalez 2019-03-18 17:30 ` Marc Gonzalez 2019-03-18 17:59 ` Robin Murphy 2019-03-18 17:59 ` Robin Murphy 2019-05-02 16:05 ` Marc Gonzalez 2019-05-02 16:05 ` Marc Gonzalez 2019-05-02 16:05 ` Marc Gonzalez 2019-05-02 16:33 ` Robin Murphy 2019-05-02 16:33 ` Robin Murphy 2019-05-02 16:33 ` Robin Murphy 2019-05-02 16:50 ` Marc Gonzalez 2019-05-02 16:50 ` Marc Gonzalez 2019-05-02 16:50 ` Marc Gonzalez 2019-05-03 11:36 ` Marc Gonzalez 2019-05-03 11:36 ` Marc Gonzalez 2019-05-03 11:36 ` Marc Gonzalez 2019-05-03 12:48 ` Robin Murphy 2019-05-03 12:48 ` Robin Murphy 2019-05-03 13:07 ` Marc Gonzalez 2019-05-03 13:07 ` Marc Gonzalez 2019-05-03 13:07 ` Marc Gonzalez 2019-05-04 13:35 ` AngeloGioacchino Del Regno 2019-05-04 13:35 ` AngeloGioacchino Del Regno 2019-05-04 13:35 ` AngeloGioacchino Del Regno 2019-05-05 18:05 ` AngeloGioacchino Del Regno 2019-05-05 18:05 ` AngeloGioacchino Del Regno 2019-05-05 18:05 ` AngeloGioacchino Del Regno 2019-05-20 15:05 ` Marc Gonzalez 2019-05-20 15:05 ` Marc Gonzalez 2019-05-02 17:27 ` Marc Gonzalez 2019-05-02 17:27 ` Marc Gonzalez 2019-05-02 17:27 ` Marc Gonzalez 2019-05-03 0:38 ` Bjorn Andersson 2019-05-03 0:38 ` Bjorn Andersson 2019-05-03 0:38 ` Bjorn Andersson -- strict thread matches above, loose matches on Subject: below -- 2019-02-09 18:30 AngeloGioacchino Del Regno 2019-02-09 18:30 ` AngeloGioacchino Del Regno 2019-02-09 18:30 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b45065a61ac79add6dfa9d63131faf6f3761cb6b.camel@gmail.com \ --to=kholk11@gmail.com \ --cc=axboe@kernel.dk \ --cc=catalin.marinas@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.