[igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Uma Shankar]

Unbinding the i915 driver on some Haswell and Broadwell platforms with
Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
wakelocks=1 on cleanup".  The issue can be worked around by manually
enabling runtime power management for the conflicting audio adapter.
Use that method but also display a warning to preserve visibility of
the issue. Also tag the workaround with a FIXME comment.

Suggested-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
 tests/device_reset.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/device_reset.c b/tests/device_reset.c
index b1181b3b..9cb59ee4 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -232,9 +232,20 @@ static void set_device_filter(const char* dev_path)
 
 static void unbind_reset_rebind(struct device_fds *dev)
 {
+	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
 	igt_debug("close the device\n");
 	close_if_opened(&dev->fds.dev);
 
+	/**
+	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
+	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
+	 * The below CI friendly user level workaround prevents the warning from
+	 * appearing. Drop this hack as soon as this is fixed in the kernel.
+	 */
+	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
+	    "Manually enabling audio PM to work around a kernel WARN\n"))
+		igt_pm_enable_audio_runtime_pm();
+
 	driver_unbind(dev);
 
 	initiate_device_reset(dev);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/device_reset: Work around for driver unbind issue with audio (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 6025 bytes --]

== Series Details ==

Series: tests/device_reset: Work around for driver unbind issue with audio (rev2)
URL   : https://patchwork.freedesktop.org/series/81650/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9005 -> IGTPW_4978
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html

Known issues
------------

  Here are the changes found in IGTPW_4978 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_tiled_fence_blits@basic:
    - fi-tgl-y:           [PASS][1] -> [DMESG-WARN][2] ([i915#402])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@gem_tiled_fence_blits@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@gem_tiled_fence_blits@basic.html

  * igt@i915_module_load@reload:
    - fi-tgl-y:           [PASS][3] -> [DMESG-WARN][4] ([i915#1982] / [i915#402])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@i915_module_load@reload.html

  * igt@kms_psr@sprite_plane_onoff:
    - fi-tgl-y:           [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@kms_psr@sprite_plane_onoff.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@kms_psr@sprite_plane_onoff.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-glk-dsi:         [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_sync@basic-each:
    - fi-tgl-y:           [DMESG-WARN][9] ([i915#402]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@gem_sync@basic-each.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@gem_sync@basic-each.html

  * igt@kms_addfb_basic@bad-pitch-128:
    - {fi-tgl-dsi}:       [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-dsi/igt@kms_addfb_basic@bad-pitch-128.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-dsi/igt@kms_addfb_basic@bad-pitch-128.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-kbl-7500u:       [DMESG-FAIL][13] ([i915#165]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-tgl-y:           [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@gem_exec_suspend@basic-s0:
    - fi-kbl-x1275:       [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-tgl-y:           [DMESG-WARN][19] ([i915#2411] / [i915#402]) -> [DMESG-WARN][20] ([i915#2411])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_pm_rpm@module-reload:
    - fi-kbl-x1275:       [DMESG-FAIL][21] ([i915#62] / [i915#95]) -> [DMESG-FAIL][22] ([i915#62])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-kbl-x1275:       [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (45 -> 39)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5781 -> IGTPW_4978

  CI-20190529: 20190529
  CI_DRM_9005: b51db36cb47d8c4da15146acf8adc1241617eba5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4978: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html
  IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html

[-- Attachment #1.2: Type: text/html, Size: 8099 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/device_reset: Work around for driver unbind issue with audio (rev2)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 13273 bytes --]

== Series Details ==

Series: tests/device_reset: Work around for driver unbind issue with audio (rev2)
URL   : https://patchwork.freedesktop.org/series/81650/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9005_full -> IGTPW_4978_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_4978_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4978_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4978_full:

### IGT changes ###

#### Warnings ####

  * igt@device_reset@unbind-reset-rebind:
    - shard-hsw:          [INCOMPLETE][1] ([i915#2283]) -> [WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-hsw6/igt@device_reset@unbind-reset-rebind.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-hsw8/igt@device_reset@unbind-reset-rebind.html

  
Known issues
------------

  Here are the changes found in IGTPW_4978_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-kbl3/igt@gem_exec_suspend@basic-s3.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-kbl7/igt@gem_exec_suspend@basic-s3.html

  * igt@gem_exec_whisper@basic-forked:
    - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-glk3/igt@gem_exec_whisper@basic-forked.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-glk7/igt@gem_exec_whisper@basic-forked.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-hsw:          [PASS][7] -> [WARN][8] ([i915#1519])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-hsw8/igt@i915_pm_rc6_residency@rc6-idle.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-hsw1/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_selftest@mock@contexts:
    - shard-apl:          [PASS][9] -> [INCOMPLETE][10] ([i915#1635] / [i915#2278])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-apl7/igt@i915_selftest@mock@contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-apl7/igt@i915_selftest@mock@contexts.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
    - shard-kbl:          [PASS][11] -> [FAIL][12] ([i915#54])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
    - shard-glk:          [PASS][13] -> [FAIL][14] ([i915#54])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-glk2/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-glk2/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
    - shard-apl:          [PASS][15] -> [FAIL][16] ([i915#1635] / [i915#54])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html

  * igt@kms_flip@flip-vs-expired-vblank@c-dp1:
    - shard-apl:          [PASS][17] -> [FAIL][18] ([i915#1635] / [i915#79])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-apl1/igt@kms_flip@flip-vs-expired-vblank@c-dp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1:
    - shard-hsw:          [PASS][19] -> [INCOMPLETE][20] ([i915#2055])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-hsw8/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html

  * igt@kms_frontbuffer_tracking@fbc-badstride:
    - shard-glk:          [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-glk5/igt@kms_frontbuffer_tracking@fbc-badstride.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-glk1/igt@kms_frontbuffer_tracking@fbc-badstride.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc:
    - shard-tglb:         [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +2 similar issues
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-wc.html

  * igt@kms_hdmi_inject@inject-audio:
    - shard-tglb:         [PASS][25] -> [SKIP][26] ([i915#433])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-tglb3/igt@kms_hdmi_inject@inject-audio.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-tglb8/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
    - shard-kbl:          [PASS][27] -> [INCOMPLETE][28] ([i915#155])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][29] -> [SKIP][30] ([fdo#109642] / [fdo#111068])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-iclb8/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_vblank@pipe-c-wait-forked-busy-hang:
    - shard-apl:          [PASS][33] -> [DMESG-WARN][34] ([i915#1635] / [i915#1982])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-apl8/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-apl7/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html

  
#### Possible fixes ####

  * igt@gem_exec_reloc@basic-many-active@rcs0:
    - shard-apl:          [FAIL][35] ([i915#1635] / [i915#2389]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-apl7/igt@gem_exec_reloc@basic-many-active@rcs0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-apl4/igt@gem_exec_reloc@basic-many-active@rcs0.html
    - shard-glk:          [FAIL][37] ([i915#2389]) -> [PASS][38] +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-glk6/igt@gem_exec_reloc@basic-many-active@rcs0.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html

  * igt@i915_hangman@error-state-capture@bcs0:
    - shard-hsw:          [INCOMPLETE][39] ([CI#80]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-hsw7/igt@i915_hangman@error-state-capture@bcs0.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-hsw8/igt@i915_hangman@error-state-capture@bcs0.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-iclb:         [FAIL][41] ([i915#1899]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-iclb3/igt@i915_pm_dc@dc5-psr.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-iclb3/igt@i915_pm_dc@dc5-psr.html

  * igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge:
    - shard-hsw:          [DMESG-WARN][43] ([i915#1982]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-hsw6/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-hsw1/igt@kms_cursor_edge_walk@pipe-b-128x128-bottom-edge.html

  * igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge:
    - shard-glk:          [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-glk5/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-glk1/igt@kms_cursor_edge_walk@pipe-c-128x128-top-edge.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-tglb:         [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-iclb:         [INCOMPLETE][49] ([i915#1185] / [i915#250]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-iclb7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][51] ([fdo#109441]) -> [PASS][52] +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][53] ([i915#31]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-kbl6/igt@kms_setmode@basic.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-kbl1/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +3 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9005/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  
  [CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
  [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1899]: https://gitlab.freedesktop.org/drm/intel/issues/1899
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
  [i915#2278]: https://gitlab.freedesktop.org/drm/intel/issues/2278
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
  [i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5781 -> IGTPW_4978
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_9005: b51db36cb47d8c4da15146acf8adc1241617eba5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4978: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html
  IGT_5781: 66766dd7cd99465d977ac07db8a2413dbbfe8d84 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4978/index.html

[-- Attachment #1.2: Type: text/html, Size: 15493 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Janusz Krzysztofik]

On Mon, 2020-09-14 at 19:06 +0530, Uma Shankar wrote:
> Unbinding the i915 driver on some Haswell and Broadwell platforms with
> Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> wakelocks=1 on cleanup".  The issue can be worked around by manually
> enabling runtime power management for the conflicting audio adapter.
> Use that method but also display a warning to preserve visibility of
> the issue. Also tag the workaround with a FIXME comment.
> 
> Suggested-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>

Pushed.

@Lakshmi, since kernel WARN has been replaced with an IGT warning but
the issue remains the same, please update the filter of the bug.

Thanks,
Janusz

> ---
>  tests/device_reset.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index b1181b3b..9cb59ee4 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -232,9 +232,20 @@ static void set_device_filter(const char* dev_path)
>  
>  static void unbind_reset_rebind(struct device_fds *dev)
>  {
> +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
>  	igt_debug("close the device\n");
>  	close_if_opened(&dev->fds.dev);
>  
> +	/**
> +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
> +	 * The below CI friendly user level workaround prevents the warning from
> +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> +	 */
> +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> +		igt_pm_enable_audio_runtime_pm();
> +
>  	driver_unbind(dev);
>  
>  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Vudum, Lakshminarayana]

@Janusz Krzysztofik Can you share the link to the failure that contains IGT warning? 

Thanks,
Lakshmi.
-----Original Message-----
From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> 
Sent: Monday, September 14, 2020 12:19 PM
To: Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
Cc: Bernatowicz, Marcin <marcin.bernatowicz@intel.com>; Deak, Imre <imre.deak@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

On Mon, 2020-09-14 at 19:06 +0530, Uma Shankar wrote:
> Unbinding the i915 driver on some Haswell and Broadwell platforms with 
> Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> wakelocks=1 on cleanup".  The issue can be worked around by manually 
> enabling runtime power management for the conflicting audio adapter.
> Use that method but also display a warning to preserve visibility of 
> the issue. Also tag the workaround with a FIXME comment.
> 
> Suggested-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>

Pushed.

@Lakshmi, since kernel WARN has been replaced with an IGT warning but the issue remains the same, please update the filter of the bug.

Thanks,
Janusz

> ---
>  tests/device_reset.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c index 
> b1181b3b..9cb59ee4 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -232,9 +232,20 @@ static void set_device_filter(const char* 
> dev_path)
>  
>  static void unbind_reset_rebind(struct device_fds *dev)  {
> +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
>  	igt_debug("close the device\n");
>  	close_if_opened(&dev->fds.dev);
>  
> +	/**
> +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
> +	 * The below CI friendly user level workaround prevents the warning from
> +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> +	 */
> +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> +		igt_pm_enable_audio_runtime_pm();
> +
>  	driver_unbind(dev);
>  
>  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Janusz Krzysztofik]

Hi Lakshmi,

On Mon, 2020-09-14 at 20:47 +0000, Vudum, Lakshminarayana wrote:
> @Janusz Krzysztofik Can you share the link to the failure that contains IGT warning?

Here it is:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw4/igt@device_reset@unbind-reset-rebind.html

and before the change for reference:
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5783/shard-hsw8/igt@device_reset@unbind-reset-rebind.html

Thanks,
Janusz

>  
> 
> Thanks,
> Lakshmi.
> -----Original Message-----
> From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> 
> Sent: Monday, September 14, 2020 12:19 PM
> To: Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Bernatowicz, Marcin <marcin.bernatowicz@intel.com>; Deak, Imre <imre.deak@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
> Subject: Re: [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio
> 
> On Mon, 2020-09-14 at 19:06 +0530, Uma Shankar wrote:
> > Unbinding the i915 driver on some Haswell and Broadwell platforms with 
> > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> > wakelocks=1 on cleanup".  The issue can be worked around by manually 
> > enabling runtime power management for the conflicting audio adapter.
> > Use that method but also display a warning to preserve visibility of 
> > the issue. Also tag the workaround with a FIXME comment.
> > 
> > Suggested-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> 
> Pushed.
> 
> @Lakshmi, since kernel WARN has been replaced with an IGT warning but the issue remains the same, please update the filter of the bug.
> 
> Thanks,
> Janusz
> 
> > ---
> >  tests/device_reset.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/tests/device_reset.c b/tests/device_reset.c index 
> > b1181b3b..9cb59ee4 100644
> > --- a/tests/device_reset.c
> > +++ b/tests/device_reset.c
> > @@ -232,9 +232,20 @@ static void set_device_filter(const char* 
> > dev_path)
> >  
> >  static void unbind_reset_rebind(struct device_fds *dev)  {
> > +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
> >  	igt_debug("close the device\n");
> >  	close_if_opened(&dev->fds.dev);
> >  
> > +	/**
> > +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> > +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
> > +	 * The below CI friendly user level workaround prevents the warning from
> > +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> > +	 */
> > +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> > +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> > +		igt_pm_enable_audio_runtime_pm();
> > +
> >  	driver_unbind(dev);
> >  
> >  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Janusz Krzysztofik]

On Tue, 2020-09-15 at 08:18 +0200, Janusz Krzysztofik wrote:
> Hi Lakshmi,
> 
> On Mon, 2020-09-14 at 20:47 +0000, Vudum, Lakshminarayana wrote:
> > @Janusz Krzysztofik Can you share the link to the failure that contains IGT warning?
> 
> Here it is:
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/shard-hsw4/igt@device_reset@unbind-reset-rebind.html

The same issue triggered by core_hotunplug@*bind*:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9008/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html

Thanks,
Janusz
> 
> and before the change for reference:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5783/shard-hsw8/igt@device_reset@unbind-reset-rebind.html
> 
> Thanks,
> Janusz
> 
> >  
> > 
> > Thanks,
> > Lakshmi.
> > -----Original Message-----
> > From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> 
> > Sent: Monday, September 14, 2020 12:19 PM
> > To: Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> > Cc: Bernatowicz, Marcin <marcin.bernatowicz@intel.com>; Deak, Imre <imre.deak@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
> > Subject: Re: [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio
> > 
> > On Mon, 2020-09-14 at 19:06 +0530, Uma Shankar wrote:
> > > Unbinding the i915 driver on some Haswell and Broadwell platforms with 
> > > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> > > wakelocks=1 on cleanup".  The issue can be worked around by manually 
> > > enabling runtime power management for the conflicting audio adapter.
> > > Use that method but also display a warning to preserve visibility of 
> > > the issue. Also tag the workaround with a FIXME comment.
> > > 
> > > Suggested-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > > Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > 
> > Pushed.
> > 
> > @Lakshmi, since kernel WARN has been replaced with an IGT warning but the issue remains the same, please update the filter of the bug.
> > 
> > Thanks,
> > Janusz
> > 
> > > ---
> > >  tests/device_reset.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/tests/device_reset.c b/tests/device_reset.c index 
> > > b1181b3b..9cb59ee4 100644
> > > --- a/tests/device_reset.c
> > > +++ b/tests/device_reset.c
> > > @@ -232,9 +232,20 @@ static void set_device_filter(const char* 
> > > dev_path)
> > >  
> > >  static void unbind_reset_rebind(struct device_fds *dev)  {
> > > +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
> > >  	igt_debug("close the device\n");
> > >  	close_if_opened(&dev->fds.dev);
> > >  
> > > +	/**
> > > +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> > > +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
> > > +	 * The below CI friendly user level workaround prevents the warning from
> > > +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> > > +	 */
> > > +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> > > +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> > > +		igt_pm_enable_audio_runtime_pm();
> > > +
> > >  	driver_unbind(dev);
> > >  
> > >  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Shankar, Uma]

> -----Original Message-----
> From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Sent: Monday, September 14, 2020 5:56 PM
> To: Shankar, Uma <uma.shankar@intel.com>; igt-dev@lists.freedesktop.org
> Cc: Bernatowicz, Marcin <marcin.bernatowicz@intel.com>; Deak, Imre
> <imre.deak@intel.com>
> Subject: Re: [PATCH i-g-t] tests/device_reset: Work around for driver unbind
> issue with audio
> 
> Hi Uma,
> 
> On Mon, 2020-09-14 at 18:18 +0530, Uma Shankar wrote:
> > Unbinding the i915 driver on some Haswell and Broadwell platforms with
> > Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> > wakelocks=1 on cleanup".  The issue can be worked around by manually
> > enabling runtime power management for the conflicting audio adapter.
> > Use that method but also display a warning to preserve visibility of
> > the issue. Also tag the workaround with a FIXME comment.
> >
> > Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> > Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> > ---
> 
> Even if the code looks the same as in my patch against core_hotunplug, this is a
> separate submission so I think you can drop drop my S-o-b, or replace it with a
> Suggested-by:, then add my
> 

Sure Janusz, will do the needful. Thanks for the pointers.

Regards,
Uma Shankar

> Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>

> Thanks,
> Janusz
> 
> 
> 
> >  tests/device_reset.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/tests/device_reset.c b/tests/device_reset.c index
> > b1181b3b..9cb59ee4 100644
> > --- a/tests/device_reset.c
> > +++ b/tests/device_reset.c
> > @@ -232,9 +232,20 @@ static void set_device_filter(const char*
> > dev_path)
> >
> >  static void unbind_reset_rebind(struct device_fds *dev)  {
> > +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
> >  	igt_debug("close the device\n");
> >  	close_if_opened(&dev->fds.dev);
> >
> > +	/**
> > +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> > +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on
> cleanup".
> > +	 * The below CI friendly user level workaround prevents the warning
> from
> > +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> > +	 */
> > +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> > +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> > +		igt_pm_enable_audio_runtime_pm();
> > +
> >  	driver_unbind(dev);
> >
> >  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Uma Shankar]

Unbinding the i915 driver on some Haswell and Broadwell platforms with
Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
wakelocks=1 on cleanup".  The issue can be worked around by manually
enabling runtime power management for the conflicting audio adapter.
Use that method but also display a warning to preserve visibility of
the issue. Also tag the workaround with a FIXME comment.

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
 tests/device_reset.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/device_reset.c b/tests/device_reset.c
index b1181b3b..9cb59ee4 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -232,9 +232,20 @@ static void set_device_filter(const char* dev_path)
 
 static void unbind_reset_rebind(struct device_fds *dev)
 {
+	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
 	igt_debug("close the device\n");
 	close_if_opened(&dev->fds.dev);
 
+	/**
+	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
+	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
+	 * The below CI friendly user level workaround prevents the warning from
+	 * appearing. Drop this hack as soon as this is fixed in the kernel.
+	 */
+	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
+	    "Manually enabling audio PM to work around a kernel WARN\n"))
+		igt_pm_enable_audio_runtime_pm();
+
 	driver_unbind(dev);
 
 	initiate_device_reset(dev);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio

[Janusz Krzysztofik]

Hi Uma,

On Mon, 2020-09-14 at 18:18 +0530, Uma Shankar wrote:
> Unbinding the i915 driver on some Haswell and Broadwell platforms with
> Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
> wakelocks=1 on cleanup".  The issue can be worked around by manually
> enabling runtime power management for the conflicting audio adapter.
> Use that method but also display a warning to preserve visibility of
> the issue. Also tag the workaround with a FIXME comment.
> 
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> ---

Even if the code looks the same as in my patch against core_hotunplug,
this is a separate submission so I think you can drop drop my S-o-b, or
replace it with a Suggested-by:, then add my

Reviewed-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>

Thanks,
Janusz



>  tests/device_reset.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index b1181b3b..9cb59ee4 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -232,9 +232,20 @@ static void set_device_filter(const char* dev_path)
>  
>  static void unbind_reset_rebind(struct device_fds *dev)
>  {
> +	uint32_t devid = intel_get_drm_devid(dev->fds.dev);
>  	igt_debug("close the device\n");
>  	close_if_opened(&dev->fds.dev);
>  
> +	/**
> +	 * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
> +	 * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
> +	 * The below CI friendly user level workaround prevents the warning from
> +	 * appearing. Drop this hack as soon as this is fixed in the kernel.
> +	 */
> +	if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
> +	    "Manually enabling audio PM to work around a kernel WARN\n"))
> +		igt_pm_enable_audio_runtime_pm();
> +
>  	driver_unbind(dev);
>  
>  	initiate_device_reset(dev);

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev