[Buildroot] [PATCH 1/1] package/libzip: fix build with musl-fts

[Buildroot] [PATCH 1/1] package/libzip: fix build with musl-fts

[Fabrice Fontaine]

Fixes:
 - http://autobuild.buildroot.org/results/89f5fc111bb8bcecbe05ab79d62ac809094b6ce1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libzip/Config.in | 1 +
 package/libzip/libzip.mk | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/package/libzip/Config.in b/package/libzip/Config.in
index f69dd0d4d5..c6ddabe6b5 100644
--- a/package/libzip/Config.in
+++ b/package/libzip/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBZIP
 	bool "libzip"
 	depends on !BR2_STATIC_LIBS # dlsym()
+	select BR2_PACKAGE_MUSL_FTS if !BR2_TOOLCHAIN_USES_GLIBC
 	select BR2_PACKAGE_ZLIB
 	help
 	  C library for reading, creating, and modifying zip archives.
diff --git a/package/libzip/libzip.mk b/package/libzip/libzip.mk
index 280ca6d8c7..a312dd90df 100644
--- a/package/libzip/libzip.mk
+++ b/package/libzip/libzip.mk
@@ -33,5 +33,10 @@ else
 LIBZIP_CONF_OPTS += -DENABLE_OPENSSL=OFF
 endif
 
+ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
+LIBZIP_DEPENDENCIES += musl-fts
+LIBZIP_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-lfts
+endif
+
 $(eval $(cmake-package))
 $(eval $(host-cmake-package))
-- 
2.23.0

[Buildroot] [PATCH 1/1] package/libzip: fix build with musl-fts

[Arnout Vandecappelle]

On 11/10/2019 19:26, Fabrice Fontaine wrote:
> Fixes:
>  - http://autobuild.buildroot.org/results/89f5fc111bb8bcecbe05ab79d62ac809094b6ce1

 Ha, we didn't think of that when adding musl-fts... Packages that check for
fts.h may now fail to build because they find fts.h but don't link with -lfts...

> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/libzip/Config.in | 1 +
>  package/libzip/libzip.mk | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/package/libzip/Config.in b/package/libzip/Config.in
> index f69dd0d4d5..c6ddabe6b5 100644
> --- a/package/libzip/Config.in
> +++ b/package/libzip/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_LIBZIP
>  	bool "libzip"
>  	depends on !BR2_STATIC_LIBS # dlsym()
> +	select BR2_PACKAGE_MUSL_FTS if !BR2_TOOLCHAIN_USES_GLIBC
>  	select BR2_PACKAGE_ZLIB
>  	help
>  	  C library for reading, creating, and modifying zip archives.
> diff --git a/package/libzip/libzip.mk b/package/libzip/libzip.mk
> index 280ca6d8c7..a312dd90df 100644
> --- a/package/libzip/libzip.mk
> +++ b/package/libzip/libzip.mk
> @@ -33,5 +33,10 @@ else
>  LIBZIP_CONF_OPTS += -DENABLE_OPENSSL=OFF
>  endif
>  
> +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
> +LIBZIP_DEPENDENCIES += musl-fts
> +LIBZIP_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-lfts
> +endif
> +
>  $(eval $(cmake-package))
>  $(eval $(host-cmake-package))
> 

[Buildroot] [PATCH 1/1] package/libzip: fix build with musl-fts

[Fabrice Fontaine]

Dear Arnout,

Le ven. 11 oct. 2019 ? 22:09, Arnout Vandecappelle <arnout@mind.be> a ?crit :
>
>
>
> On 11/10/2019 19:26, Fabrice Fontaine wrote:
> > Fixes:
> >  - http://autobuild.buildroot.org/results/89f5fc111bb8bcecbe05ab79d62ac809094b6ce1
>
>  Ha, we didn't think of that when adding musl-fts... Packages that check for
> fts.h may now fail to build because they find fts.h but don't link with -lfts...
There is another interesting issue due to musl-fts on elfutils
(http://autobuild.buildroot.org/results/ef3/ef3ec5aaef2b26c9947f403d2672b0f9beafd6db/build-end.log):

In file included from linux-kernel-modules.c:67:0:
/data/buildroot/buildroot-test/instance-0/output/host/m68k-buildroot-linux-uclibc/sysroot/usr/include/fts.h:149:6:
error: conflicting types for 'fts_set'
 int  fts_set(FTS *, FTSENT *, int);
      ^~~~~~~
>
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
>  Applied to master, thanks.
>
>  Regards,
>  Arnout
>
> > ---
> >  package/libzip/Config.in | 1 +
> >  package/libzip/libzip.mk | 5 +++++
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/package/libzip/Config.in b/package/libzip/Config.in
> > index f69dd0d4d5..c6ddabe6b5 100644
> > --- a/package/libzip/Config.in
> > +++ b/package/libzip/Config.in
> > @@ -1,6 +1,7 @@
> >  config BR2_PACKAGE_LIBZIP
> >       bool "libzip"
> >       depends on !BR2_STATIC_LIBS # dlsym()
> > +     select BR2_PACKAGE_MUSL_FTS if !BR2_TOOLCHAIN_USES_GLIBC
> >       select BR2_PACKAGE_ZLIB
> >       help
> >         C library for reading, creating, and modifying zip archives.
> > diff --git a/package/libzip/libzip.mk b/package/libzip/libzip.mk
> > index 280ca6d8c7..a312dd90df 100644
> > --- a/package/libzip/libzip.mk
> > +++ b/package/libzip/libzip.mk
> > @@ -33,5 +33,10 @@ else
> >  LIBZIP_CONF_OPTS += -DENABLE_OPENSSL=OFF
> >  endif
> >
> > +ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
> > +LIBZIP_DEPENDENCIES += musl-fts
> > +LIBZIP_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-lfts
> > +endif
> > +
> >  $(eval $(cmake-package))
> >  $(eval $(host-cmake-package))
> >
Best Regards,

Fabrice

[Buildroot] [PATCH 1/1] package/libzip: fix build with musl-fts

[Arnout Vandecappelle]

On 11/10/2019 23:59, Fabrice Fontaine wrote:
> Dear Arnout,
> 
> Le ven. 11 oct. 2019 ? 22:09, Arnout Vandecappelle <arnout@mind.be> a ?crit :
>>
>>
>>
>> On 11/10/2019 19:26, Fabrice Fontaine wrote:
>>> Fixes:
>>>  - http://autobuild.buildroot.org/results/89f5fc111bb8bcecbe05ab79d62ac809094b6ce1
>>
>>  Ha, we didn't think of that when adding musl-fts... Packages that check for
>> fts.h may now fail to build because they find fts.h but don't link with -lfts...
> There is another interesting issue due to musl-fts on elfutils
> (http://autobuild.buildroot.org/results/ef3/ef3ec5aaef2b26c9947f403d2672b0f9beafd6db/build-end.log):
> 
> In file included from linux-kernel-modules.c:67:0:
> /data/buildroot/buildroot-test/instance-0/output/host/m68k-buildroot-linux-uclibc/sysroot/usr/include/fts.h:149:6:
> error: conflicting types for 'fts_set'
>  int  fts_set(FTS *, FTSENT *, int);
>       ^~~~~~~

 We do that unto ourselves with patch 0002...

 Regards,
 Arnout