* [PATCH] net: dsa: felix: fix possible NULL pointer dereference
@ 2022-03-29 8:12 Zheng Yongjun
2022-03-29 8:59 ` Paolo Abeni
0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2022-03-29 8:12 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, davem, kuba, netdev, linux-kernel
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, UNGLinuxDriver
As the possible failure of the allocation, kzalloc() may return NULL
pointer.
Therefore, it should be better to check the 'sgi' in order to prevent
the dereference of NULL pointer.
Fixes: 23ae3a7877718 ("net: dsa: felix: add stream gate settings for psfpq").
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
index 33f0ceae381d..2875b5250856 100644
--- a/drivers/net/dsa/ocelot/felix_vsc9959.c
+++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
@@ -1940,6 +1940,10 @@ static int vsc9959_psfp_filter_add(struct ocelot *ocelot, int port,
case FLOW_ACTION_GATE:
size = struct_size(sgi, entries, a->gate.num_entries);
sgi = kzalloc(size, GFP_KERNEL);
+ if (!sgi) {
+ ret = -ENOMEM;
+ goto err;
+ }
vsc9959_psfp_parse_gate(a, sgi);
ret = vsc9959_psfp_sgi_table_add(ocelot, sgi);
if (ret) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: felix: fix possible NULL pointer dereference
2022-03-29 8:12 [PATCH] net: dsa: felix: fix possible NULL pointer dereference Zheng Yongjun
@ 2022-03-29 8:59 ` Paolo Abeni
2022-03-29 9:12 ` 答复: " zhengyongjun
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Abeni @ 2022-03-29 8:59 UTC (permalink / raw)
To: Zheng Yongjun, andrew, vivien.didelot, f.fainelli, davem, kuba,
netdev, linux-kernel
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, UNGLinuxDriver
Hello,
On Tue, 2022-03-29 at 08:12 +0000, Zheng Yongjun wrote:
> As the possible failure of the allocation, kzalloc() may return NULL
> pointer.
> Therefore, it should be better to check the 'sgi' in order to prevent
> the dereference of NULL pointer.
>
> Fixes: 23ae3a7877718 ("net: dsa: felix: add stream gate settings for psfpq").
It looks like the fixes tag has been corrupted (trailing 'q'). Would
you mind posting a v2 with that fixed ?
Thanks,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [PATCH] net: dsa: felix: fix possible NULL pointer dereference
2022-03-29 8:59 ` Paolo Abeni
@ 2022-03-29 9:12 ` zhengyongjun
0 siblings, 0 replies; 3+ messages in thread
From: zhengyongjun @ 2022-03-29 9:12 UTC (permalink / raw)
To: Paolo Abeni, andrew, vivien.didelot, f.fainelli, davem, kuba,
netdev, linux-kernel
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, UNGLinuxDriver
Thanks for point out my mistake :)
-----邮件原件-----
发件人: Paolo Abeni [mailto:pabeni@redhat.com]
发送时间: 2022年3月29日 17:00
收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; vivien.didelot@gmail.com; f.fainelli@gmail.com; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: vladimir.oltean@nxp.com; claudiu.manoil@nxp.com; alexandre.belloni@bootlin.com; UNGLinuxDriver@microchip.com
主题: Re: [PATCH] net: dsa: felix: fix possible NULL pointer dereference
Hello,
On Tue, 2022-03-29 at 08:12 +0000, Zheng Yongjun wrote:
> As the possible failure of the allocation, kzalloc() may return NULL
> pointer.
> Therefore, it should be better to check the 'sgi' in order to prevent
> the dereference of NULL pointer.
>
> Fixes: 23ae3a7877718 ("net: dsa: felix: add stream gate settings for psfpq").
It looks like the fixes tag has been corrupted (trailing 'q'). Would you mind posting a v2 with that fixed ?
Thanks,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-29 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29 8:12 [PATCH] net: dsa: felix: fix possible NULL pointer dereference Zheng Yongjun
2022-03-29 8:59 ` Paolo Abeni
2022-03-29 9:12 ` 答复: " zhengyongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.