* [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup
@ 2017-01-07 11:13 Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 1/4] Staging: comedi: comedi_fops: Remove unused kmod.h header Cheah Kok Cheong
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Cheah Kok Cheong @ 2017-01-07 11:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Cheah Kok Cheong
This series does trivial header cleanup for comedi_fops.c
Cheah Kok Cheong (4):
Staging: comedi: comedi_fops: Remove unused kmod.h header
Staging: comedi: comedi_fops: Remove redundant init.h header
Staging: comedi: comedi_fops: Remove unused vmalloc.h header
Staging: comedi: comedi_fops: Remove unused stat.h header
drivers/staging/comedi/comedi_fops.c | 4 ----
1 file changed, 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] Staging: comedi: comedi_fops: Remove unused kmod.h header
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
@ 2017-01-07 11:13 ` Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 2/4] Staging: comedi: comedi_fops: Remove redundant init.h header Cheah Kok Cheong
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Cheah Kok Cheong @ 2017-01-07 11:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Cheah Kok Cheong
Unused after commit f30f2c2d417b ("staging: comedi:
remove check for CONFIG_KMOD").
Anyway it's included in module.h
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 64b3966..7ad9092 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -28,7 +28,6 @@
#include <linux/delay.h>
#include <linux/mm.h>
#include <linux/slab.h>
-#include <linux/kmod.h>
#include <linux/poll.h>
#include <linux/init.h>
#include <linux/device.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] Staging: comedi: comedi_fops: Remove redundant init.h header
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 1/4] Staging: comedi: comedi_fops: Remove unused kmod.h header Cheah Kok Cheong
@ 2017-01-07 11:13 ` Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 3/4] Staging: comedi: comedi_fops: Remove unused vmalloc.h header Cheah Kok Cheong
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Cheah Kok Cheong @ 2017-01-07 11:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Cheah Kok Cheong
After commit 0fd972a7d91d ("module: relocate module_init
from init.h to module.h"), including module.h will do and
init.h is also thrown in.
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 7ad9092..8bcb1cc 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -29,7 +29,6 @@
#include <linux/mm.h>
#include <linux/slab.h>
#include <linux/poll.h>
-#include <linux/init.h>
#include <linux/device.h>
#include <linux/vmalloc.h>
#include <linux/fs.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] Staging: comedi: comedi_fops: Remove unused vmalloc.h header
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 1/4] Staging: comedi: comedi_fops: Remove unused kmod.h header Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 2/4] Staging: comedi: comedi_fops: Remove redundant init.h header Cheah Kok Cheong
@ 2017-01-07 11:13 ` Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 4/4] Staging: comedi: comedi_fops: Remove unused stat.h header Cheah Kok Cheong
2017-01-09 11:02 ` [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Ian Abbott
4 siblings, 0 replies; 6+ messages in thread
From: Cheah Kok Cheong @ 2017-01-07 11:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Cheah Kok Cheong
Unused after commit d18431325be0 ("staging: comedi:
deprecate loading firmware with comedi_config").
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 8bcb1cc..5c06ba6 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -30,7 +30,6 @@
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/device.h>
-#include <linux/vmalloc.h>
#include <linux/fs.h>
#include "comedidev.h"
#include <linux/cdev.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] Staging: comedi: comedi_fops: Remove unused stat.h header
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
` (2 preceding siblings ...)
2017-01-07 11:13 ` [PATCH 3/4] Staging: comedi: comedi_fops: Remove unused vmalloc.h header Cheah Kok Cheong
@ 2017-01-07 11:13 ` Cheah Kok Cheong
2017-01-09 11:02 ` [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Ian Abbott
4 siblings, 0 replies; 6+ messages in thread
From: Cheah Kok Cheong @ 2017-01-07 11:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Cheah Kok Cheong
Unused after commit 6e3029397698 ("staging: comedi: comedi_fops:
coding style fixes") - Fixed coding style in comedi_fops.c
Symbolic to octal permission.
Anyway it's included in module.h
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
drivers/staging/comedi/comedi_fops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 5c06ba6..2e8c6d9 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -33,7 +33,6 @@
#include <linux/fs.h>
#include "comedidev.h"
#include <linux/cdev.h>
-#include <linux/stat.h>
#include <linux/io.h>
#include <linux/uaccess.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
` (3 preceding siblings ...)
2017-01-07 11:13 ` [PATCH 4/4] Staging: comedi: comedi_fops: Remove unused stat.h header Cheah Kok Cheong
@ 2017-01-09 11:02 ` Ian Abbott
4 siblings, 0 replies; 6+ messages in thread
From: Ian Abbott @ 2017-01-09 11:02 UTC (permalink / raw)
To: Cheah Kok Cheong, hsweeten, gregkh; +Cc: devel, linux-kernel
On 07/01/17 11:13, Cheah Kok Cheong wrote:
> This series does trivial header cleanup for comedi_fops.c
>
> Cheah Kok Cheong (4):
> Staging: comedi: comedi_fops: Remove unused kmod.h header
> Staging: comedi: comedi_fops: Remove redundant init.h header
> Staging: comedi: comedi_fops: Remove unused vmalloc.h header
> Staging: comedi: comedi_fops: Remove unused stat.h header
>
> drivers/staging/comedi/comedi_fops.c | 4 ----
> 1 file changed, 4 deletions(-)
>
I wasn't sure about the removal of the #include <linux/init.h>, but it
seems to make sense. Thanks.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-09 11:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-07 11:13 [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 1/4] Staging: comedi: comedi_fops: Remove unused kmod.h header Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 2/4] Staging: comedi: comedi_fops: Remove redundant init.h header Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 3/4] Staging: comedi: comedi_fops: Remove unused vmalloc.h header Cheah Kok Cheong
2017-01-07 11:13 ` [PATCH 4/4] Staging: comedi: comedi_fops: Remove unused stat.h header Cheah Kok Cheong
2017-01-09 11:02 ` [PATCH 0/4] Staging: comedi: comedi_fops: Header cleanup Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.