All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
	Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 1/8] ib_mad: incoming sminfo SMPs gets discarded if no process_mad function is registered
Date: Fri, 16 Sep 2016 13:28:09 -0700	[thread overview]
Message-ID: <b57491e1-e36b-c331-8360-557310d15002@oracle.com> (raw)
In-Reply-To: <66d69383a3376018d99c025cd188150f6673b209.1474049924.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On 9/16/2016 11:31 AM, Knut Omang wrote:
> From: Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> The process_mad function is an optional IB driver entry point
> allows a driver to intercept or modify MAD traffic.
>
> This fix allows MAD traffic to flow down to the device also
> when MAD traffic is completely handled by the device and
> no process_mad function is provided.
>
> SIF, the new Oracle Infiniband HCA, is the first HCA
> where the device itself makes all decision wrt MAD processing.
> Up till now devices either supports MAD, and do then
> implement the process_mad entry point, or do not
> support MAD at all, and then do not implement process_mad.
>
> SIF introduces a 3rd case: Supports MAD
> but do not terminate any MAD requests in the driver.
> This case is not handled well by the current code.
>
> The problem is that the handle_outgoing_dr_smp function
> has an implicit assumption that some packets are handled
> by the process_mad function itself.
>
> There is no way to provide return values from the process_mad
> function that ensures that packets are always forwarded to the device,
> so the only viable solution without breaking the API
> seems to be to not implement process_mad.

No SOBs ?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Knut Omang <knut.omang@oracle.com>, Doug Ledford <dledford@redhat.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Ira Weiny <ira.weiny@intel.com>, Sagi Grimberg <sagi@grimberg.me>,
	Christoph Hellwig <hch@infradead.org>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Dag Moxnes <dag.moxnes@oracle.com>,
	Mark Bloch <markb@mellanox.com>,
	Dean Luick <dean.luick@intel.com>
Subject: Re: [PATCH v2 1/8] ib_mad: incoming sminfo SMPs gets discarded if no process_mad function is registered
Date: Fri, 16 Sep 2016 13:28:09 -0700	[thread overview]
Message-ID: <b57491e1-e36b-c331-8360-557310d15002@oracle.com> (raw)
In-Reply-To: <66d69383a3376018d99c025cd188150f6673b209.1474049924.git-series.knut.omang@oracle.com>

On 9/16/2016 11:31 AM, Knut Omang wrote:
> From: Dag Moxnes <dag.moxnes@oracle.com>
>
> The process_mad function is an optional IB driver entry point
> allows a driver to intercept or modify MAD traffic.
>
> This fix allows MAD traffic to flow down to the device also
> when MAD traffic is completely handled by the device and
> no process_mad function is provided.
>
> SIF, the new Oracle Infiniband HCA, is the first HCA
> where the device itself makes all decision wrt MAD processing.
> Up till now devices either supports MAD, and do then
> implement the process_mad entry point, or do not
> support MAD at all, and then do not implement process_mad.
>
> SIF introduces a 3rd case: Supports MAD
> but do not terminate any MAD requests in the driver.
> This case is not handled well by the current code.
>
> The problem is that the handle_outgoing_dr_smp function
> has an implicit assumption that some packets are handled
> by the process_mad function itself.
>
> There is no way to provide return values from the process_mad
> function that ensures that packets are always forwarded to the device,
> so the only viable solution without breaking the API
> seems to be to not implement process_mad.

No SOBs ?

  parent reply	other threads:[~2016-09-16 20:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 18:31 [PATCH v2 0/8] SIF related verbs patches Knut Omang
2016-09-16 18:31 ` [PATCH v2 1/8] ib_mad: incoming sminfo SMPs gets discarded if no process_mad function is registered Knut Omang
     [not found]   ` <66d69383a3376018d99c025cd188150f6673b209.1474049924.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-16 20:28     ` Santosh Shilimkar [this message]
2016-09-16 20:28       ` Santosh Shilimkar
     [not found]       ` <b57491e1-e36b-c331-8360-557310d15002-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-16 20:40         ` Knut Omang
2016-09-16 20:40           ` Knut Omang
     [not found] ` <cover.15d71ac2c57534f1170c2c48374d3841ed75e676.1474049924.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-16 18:31   ` [PATCH v2 2/8] ib_umem: Add a new, more generic ib_umem_get_attrs Knut Omang
2016-09-16 18:31     ` Knut Omang
     [not found]     ` <53550a232af32c5c97ba9fb70faacc2c64d8fceb.1474049924.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-04-05 15:20       ` Knut Omang
2017-04-05 15:20         ` Knut Omang
2016-09-16 18:31   ` [PATCH v2 3/8] ib_umem: With the new ib_umem_get_attrs, simplify ib_umem_get Knut Omang
2016-09-16 18:31     ` Knut Omang
2016-09-16 18:31   ` [PATCH v2 4/8] ib: Add udata argument to create_ah Knut Omang
2016-09-16 18:31     ` Knut Omang
2016-09-16 18:31   ` [PATCH v2 6/8] ib_uverbs: Avoid vendor specific masking of attributes in query_qp Knut Omang
2016-09-16 18:31     ` Knut Omang
2016-09-16 18:31   ` [PATCH v2 7/8] ib_{uverbs/core}: add new ib_create_qp_ex with udata arg Knut Omang
2016-09-16 18:31     ` Knut Omang
2016-09-16 20:30   ` [PATCH v2 0/8] SIF related verbs patches Santosh Shilimkar
2016-09-16 20:30     ` Santosh Shilimkar
2016-09-16 20:42     ` Knut Omang
2016-09-16 18:31 ` [PATCH v2 5/8] ib_uverbs: Add padding to end align ib_uverbs_reg_mr_resp Knut Omang
2016-09-20 10:45   ` Yishai Hadas
2016-09-20 11:02     ` Knut Omang
2016-09-16 18:31 ` [PATCH v2 8/8] ib_uverbs: Support for kernel implementation of XRC Knut Omang
     [not found]   ` <88ffb8c9407a71069b52e155dde308a36dfaf247.1474049924.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-09-16 19:31     ` Jason Gunthorpe
2016-09-16 19:31       ` Jason Gunthorpe
     [not found]       ` <20160916193102.GB28859-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-16 19:49         ` Knut Omang
2016-09-16 19:49           ` Knut Omang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b57491e1-e36b-c331-8360-557310d15002@oracle.com \
    --to=santosh.shilimkar-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.