From: Benjamin GAIGNARD <benjamin.gaignard@st.com> To: Ben Dooks <ben.dooks@codethink.co.uk>, "linux-kernel@lists.codethink.co.uk" <linux-kernel@lists.codethink.co.uk> Cc: Amit Kucheria <amit.kucheria@verdurent.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Maxime Coquelin" <mcoquelin.stm32@gmail.com>, Zhang Rui <rui.zhang@intel.com>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [Linux-stm32] [PATCH] thermal: stm32: make stm_thermal_pm_ops static Date: Tue, 15 Oct 2019 15:12:26 +0000 [thread overview] Message-ID: <b5e353bc-1171-1559-351f-2e54ef6749fe@st.com> (raw) In-Reply-To: <20191015141454.15402-1-ben.dooks@codethink.co.uk> On 10/15/19 4:14 PM, Ben Dooks wrote: > The stm_thermal_pm_ops struct is not exported to any > other units, so make it static to avoid the following > sparse warning: > > drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static? Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com> Thanks, Benjamin > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amit.kucheria@verdurent.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/thermal/st/stm_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c > index cf9ddc52f30e..40bc13c68fba 100644 > --- a/drivers/thermal/st/stm_thermal.c > +++ b/drivers/thermal/st/stm_thermal.c > @@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev) > } > #endif /* CONFIG_PM_SLEEP */ > > -SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume); > +static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume); > > static const struct thermal_zone_of_device_ops stm_tz_ops = { > .get_temp = stm_thermal_get_temp,
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin GAIGNARD <benjamin.gaignard@st.com> To: Ben Dooks <ben.dooks@codethink.co.uk>, "linux-kernel@lists.codethink.co.uk" <linux-kernel@lists.codethink.co.uk> Cc: Amit Kucheria <amit.kucheria@verdurent.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Zhang Rui <rui.zhang@intel.com>, "linux-stm32@st-md-mailman.stormreply.com" <linux-stm32@st-md-mailman.stormreply.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [Linux-stm32] [PATCH] thermal: stm32: make stm_thermal_pm_ops static Date: Tue, 15 Oct 2019 15:12:26 +0000 [thread overview] Message-ID: <b5e353bc-1171-1559-351f-2e54ef6749fe@st.com> (raw) In-Reply-To: <20191015141454.15402-1-ben.dooks@codethink.co.uk> On 10/15/19 4:14 PM, Ben Dooks wrote: > The stm_thermal_pm_ops struct is not exported to any > other units, so make it static to avoid the following > sparse warning: > > drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops' was not declared. Should it be static? Reviewed-by: Benjamin Gaignard <benjamin.gaignard@st.com> Thanks, Benjamin > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Amit Kucheria <amit.kucheria@verdurent.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: linux-pm@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/thermal/st/stm_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c > index cf9ddc52f30e..40bc13c68fba 100644 > --- a/drivers/thermal/st/stm_thermal.c > +++ b/drivers/thermal/st/stm_thermal.c > @@ -596,7 +596,7 @@ static int stm_thermal_resume(struct device *dev) > } > #endif /* CONFIG_PM_SLEEP */ > > -SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume); > +static SIMPLE_DEV_PM_OPS(stm_thermal_pm_ops, stm_thermal_suspend, stm_thermal_resume); > > static const struct thermal_zone_of_device_ops stm_tz_ops = { > .get_temp = stm_thermal_get_temp, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-15 15:12 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 14:14 [PATCH] thermal: stm32: make stm_thermal_pm_ops static Ben Dooks 2019-10-15 14:14 ` Ben Dooks 2019-10-15 15:12 ` Benjamin GAIGNARD [this message] 2019-10-15 15:12 ` [Linux-stm32] " Benjamin GAIGNARD
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b5e353bc-1171-1559-351f-2e54ef6749fe@st.com \ --to=benjamin.gaignard@st.com \ --cc=amit.kucheria@verdurent.com \ --cc=ben.dooks@codethink.co.uk \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@lists.codethink.co.uk \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.