All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-4.10] libevtchn: fix build on non-Linux hosts
@ 2017-11-08 12:52 Roger Pau Monne
  2017-11-08 12:56 ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monne @ 2017-11-08 12:52 UTC (permalink / raw)
  To: xen-devel; +Cc: Wei Liu, Julien Grall, Ian Jackson, Roger Pau Monne

Non-Linux hosts (where osdep_evtchn_restrict is not yet supported)
made use of errno without including errno.h, fix this by including the
header.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>
---
Build fix for 4.10: it only affects non-Linux, and without this fix
the tools cannot be build.
---
 tools/libs/evtchn/freebsd.c | 1 +
 tools/libs/evtchn/netbsd.c  | 1 +
 tools/libs/evtchn/solaris.c | 1 +
 3 files changed, 3 insertions(+)

diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c
index ba82f06311..6564ed4c44 100644
--- a/tools/libs/evtchn/freebsd.c
+++ b/tools/libs/evtchn/freebsd.c
@@ -19,6 +19,7 @@
  * Split off from xc_freebsd_osdep.c
  */
 
+#include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 
diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c
index 5ce3a35f80..8b8545d2f9 100644
--- a/tools/libs/evtchn/netbsd.c
+++ b/tools/libs/evtchn/netbsd.c
@@ -19,6 +19,7 @@
  * Split out from xc_netbsd.c
  */
 
+#include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 
diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c
index f718989450..dd41f62a24 100644
--- a/tools/libs/evtchn/solaris.c
+++ b/tools/libs/evtchn/solaris.c
@@ -19,6 +19,7 @@
  * Split out from xc_solaris.c
  */
 
+#include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
 
-- 
2.13.6 (Apple Git-96)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH for-4.10] libevtchn: fix build on non-Linux hosts
  2017-11-08 12:52 [PATCH for-4.10] libevtchn: fix build on non-Linux hosts Roger Pau Monne
@ 2017-11-08 12:56 ` Wei Liu
  2017-11-09 14:43   ` Julien Grall
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2017-11-08 12:56 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Julien Grall, Ian Jackson, Wei Liu

On Wed, Nov 08, 2017 at 12:52:57PM +0000, Roger Pau Monne wrote:
> Non-Linux hosts (where osdep_evtchn_restrict is not yet supported)
> made use of errno without including errno.h, fix this by including the
> header.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH for-4.10] libevtchn: fix build on non-Linux hosts
  2017-11-08 12:56 ` Wei Liu
@ 2017-11-09 14:43   ` Julien Grall
  0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2017-11-09 14:43 UTC (permalink / raw)
  To: Wei Liu, Roger Pau Monne; +Cc: xen-devel, Ian Jackson

Hi,

On 08/11/17 12:56, Wei Liu wrote:
> On Wed, Nov 08, 2017 at 12:52:57PM +0000, Roger Pau Monne wrote:
>> Non-Linux hosts (where osdep_evtchn_restrict is not yet supported)
>> made use of errno without including errno.h, fix this by including the
>> header.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Release-acked-by: Julien Grall <julien.grall@linaro.org>

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-09 14:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-08 12:52 [PATCH for-4.10] libevtchn: fix build on non-Linux hosts Roger Pau Monne
2017-11-08 12:56 ` Wei Liu
2017-11-09 14:43   ` Julien Grall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.