From: Jens Axboe <axboe@kernel.dk>
To: "hch@lst.de" <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>
Subject: Re: [GIT PULL] Block pull request for- 4.11-rc1
Date: Sat, 25 Feb 2017 11:22:27 -0700 [thread overview]
Message-ID: <b61661f6-209d-d482-df49-bfb7dcf351dd@kernel.dk> (raw)
In-Reply-To: <20170225181704.GB27774@lst.de>
On 02/25/2017 11:17 AM, hch@lst.de wrote:
> On Fri, Feb 24, 2017 at 01:22:42PM -0700, Jens Axboe wrote:
>> Bart, I pushed a fix here:
>>
>> http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=61febef40bfe8ab68259d8545257686e8a0d91d1
>
> Yeah, this looks fine to me. It was broken on blk-mq before, but
> basically impossible to hit. I wonder if we should have a debug mode
> where we set requests to a known pattern after they are freed to catch
> these sort of bugs.
tio/md would probably never change for the same set of requests, so
it worked by happy accident before. Some of the blk-mq state remains
valid after "freeing" a request, but we could selectively fill and
definitely fill the entire PDU area with free poison.
--
Jens Axboe
next prev parent reply other threads:[~2017-02-25 18:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 0:10 [GIT PULL] Block pull request for- 4.11-rc1 Jens Axboe
2017-02-20 1:09 ` Bart Van Assche
2017-02-20 1:09 ` Bart Van Assche
2017-02-20 1:15 ` Jens Axboe
2017-02-20 2:12 ` James Bottomley
2017-02-20 2:12 ` James Bottomley
2017-02-20 2:59 ` Jens Axboe
2017-02-20 3:02 ` Jens Axboe
2017-02-20 7:35 ` Christoph Hellwig
2017-02-20 16:16 ` Bart Van Assche
2017-02-20 16:16 ` Bart Van Assche
2017-02-20 16:32 ` Jens Axboe
2017-02-21 1:18 ` Bart Van Assche
2017-02-21 1:18 ` Bart Van Assche
2017-02-24 17:39 ` Bart Van Assche
2017-02-24 17:39 ` Bart Van Assche
2017-02-24 17:51 ` Jens Axboe
2017-02-24 19:43 ` Linus Torvalds
2017-02-24 20:00 ` Jens Axboe
2017-02-24 20:22 ` Jens Axboe
2017-02-24 21:15 ` Bart Van Assche
2017-02-24 21:15 ` Bart Van Assche
2017-02-25 18:17 ` hch
2017-02-25 18:22 ` Jens Axboe [this message]
2017-02-21 19:11 ` Linus Torvalds
2017-02-21 19:34 ` Jens Axboe
2017-02-21 23:02 ` Linus Torvalds
2017-02-21 23:15 ` Jens Axboe
2017-02-21 23:23 ` Linus Torvalds
2017-02-22 18:14 ` Jens Axboe
2017-02-22 18:26 ` Linus Torvalds
2017-02-22 18:41 ` Jens Axboe
2017-02-22 18:45 ` Linus Torvalds
2017-02-22 18:52 ` Jens Axboe
2017-02-22 18:56 ` Linus Torvalds
2017-02-22 18:58 ` Jens Axboe
2017-02-22 19:04 ` Linus Torvalds
2017-02-22 21:29 ` Jens Axboe
2017-02-22 18:42 ` Linus Torvalds
2017-02-22 18:44 ` Jens Axboe
2017-02-22 21:50 ` Markus Trippelsdorf
2017-02-22 21:55 ` Jens Axboe
2017-02-23 0:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b61661f6-209d-d482-df49-bfb7dcf351dd@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@sandisk.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.