From: Florian Fainelli <f.fainelli@gmail.com> To: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com>, gregkh@linuxfoundation.org Cc: Stephen Warren <swarren@wwwdotorg.org>, Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Michael Zoran <mzoran@crowfest.net>, devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] somedriver: remove the initialization of static pointers. Date: Tue, 7 Feb 2017 15:09:16 -0800 [thread overview] Message-ID: <b66303e8-7a25-6bc9-ba73-62dc8250c277@gmail.com> (raw) In-Reply-To: <1486504570-5811-1-git-send-email-abdallah.meziti.pro@gmail.com> On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote: > In C a static pointer will be initialized to NULL. > The §6.7.8 of the ISO/IEC 9899:1999 (E) document says that: > If an object that has static storage duration is not initialized > explicitly, then: > __ if it has pointer type, it is initialized to a null pointer. The commit subject should be based on previous submissions, if you do a git log --oneline drivers/staging/bcm2835-audio/bcm2835.c you will see that the most frequent subject used was: Staging: bcm2835-audio: So you should utilize the same subject prefix, and make your prefix be something like: Staging: bcm2835-audio: Remove the initialization of static pointers > > Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> > > v2: -fix the line-wrapping of the changelog. > -fix the ref. documentation: C99 standards release, > and not the draft. > -this patch is the Task 10 Eudyptula Challenge > that only fix one code style problem. > --- > drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c > index a84d74d..265fe55 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/bcm2835-audio/bcm2835.c > @@ -28,8 +28,8 @@ > * to debug if we run into issues > */ > > -static struct snd_card *g_card = NULL; > -static struct bcm2835_chip *g_chip = NULL; > +static struct snd_card *g_card; > +static struct bcm2835_chip *g_chip; > > static int snd_bcm2835_free(struct bcm2835_chip *chip) > { > -- Florian
WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] somedriver: remove the initialization of static pointers. Date: Tue, 7 Feb 2017 15:09:16 -0800 [thread overview] Message-ID: <b66303e8-7a25-6bc9-ba73-62dc8250c277@gmail.com> (raw) In-Reply-To: <1486504570-5811-1-git-send-email-abdallah.meziti.pro@gmail.com> On 02/07/2017 01:55 PM, AbdAllah-MEZITI wrote: > In C a static pointer will be initialized to NULL. > The ?6.7.8 of the ISO/IEC 9899:1999 (E) document says that: > If an object that has static storage duration is not initialized > explicitly, then: > __ if it has pointer type, it is initialized to a null pointer. The commit subject should be based on previous submissions, if you do a git log --oneline drivers/staging/bcm2835-audio/bcm2835.c you will see that the most frequent subject used was: Staging: bcm2835-audio: So you should utilize the same subject prefix, and make your prefix be something like: Staging: bcm2835-audio: Remove the initialization of static pointers > > Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@gmail.com> > > v2: -fix the line-wrapping of the changelog. > -fix the ref. documentation: C99 standards release, > and not the draft. > -this patch is the Task 10 Eudyptula Challenge > that only fix one code style problem. > --- > drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c > index a84d74d..265fe55 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/bcm2835-audio/bcm2835.c > @@ -28,8 +28,8 @@ > * to debug if we run into issues > */ > > -static struct snd_card *g_card = NULL; > -static struct bcm2835_chip *g_chip = NULL; > +static struct snd_card *g_card; > +static struct bcm2835_chip *g_chip; > > static int snd_bcm2835_free(struct bcm2835_chip *chip) > { > -- Florian
next prev parent reply other threads:[~2017-02-07 23:09 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-07 21:55 [PATCH v2] somedriver: remove the initialization of static pointers AbdAllah-MEZITI 2017-02-07 21:55 ` AbdAllah-MEZITI 2017-02-07 23:09 ` Florian Fainelli [this message] 2017-02-07 23:09 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b66303e8-7a25-6bc9-ba73-62dc8250c277@gmail.com \ --to=f.fainelli@gmail.com \ --cc=abdallah.meziti.pro@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devel@driverdev.osuosl.org \ --cc=eric@anholt.net \ --cc=gregkh@linuxfoundation.org \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=mzoran@crowfest.net \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.