From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> To: Jayesh Choudhary <j-choudhary@ti.com>, robh+dt@kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Tue, 7 Dec 2021 21:44:48 +0200 [thread overview] Message-ID: <b6af56f1-7e6b-81ca-7bae-8f2a2dfaf0eb@gmail.com> (raw) In-Reply-To: <20449d7b-0524-a8df-7852-a4c495157682@ti.com> Hi, On 12/7/21 07:03, Jayesh Choudhary wrote: >>> + tdm-slots: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: number of channels over one serializer >>> + maxItems: 1 >> >> and it has to be between 2 and 32, ignored in DIT mode (384 slots) >> > > Will add minimum and maximum. Should this be added as a conditional > property when op-mode is 0 (I2S mode) and mark it as required? That would make it much nicer, yes, thank you! >>> + port: >>> + description: connection for when McASP is used via graph card >>> + type: object >> >> I understand that it can be present under the mcasp node as it is part >> of the graph card binding (or a card binding using graph). >> I mean if a new card binding comes around then we need to document it >> here as well? >> > > Specific properties are not marked for the port. So it should not be an > issue. Other alternative is to mark the additional properties as true > but that is not preferred. If the McASP is used with simple-sound-card (as it is the case most of the time) then the port is not present under the node for this device as the card is not using graph. I consider the port (and the #sound-dai-cells if we are here) not part of the McASP hardware description as they are part of the graph or simple-card binding. I'm fine if the port remains here > Peter, > Any other changes I should make? Not much, this already looking good. I would fix the dts files which generates warning/error with this yaml as they are incorrect. -- Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> To: Jayesh Choudhary <j-choudhary@ti.com>, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Tue, 7 Dec 2021 21:44:48 +0200 [thread overview] Message-ID: <b6af56f1-7e6b-81ca-7bae-8f2a2dfaf0eb@gmail.com> (raw) In-Reply-To: <20449d7b-0524-a8df-7852-a4c495157682@ti.com> Hi, On 12/7/21 07:03, Jayesh Choudhary wrote: >>> + tdm-slots: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: number of channels over one serializer >>> + maxItems: 1 >> >> and it has to be between 2 and 32, ignored in DIT mode (384 slots) >> > > Will add minimum and maximum. Should this be added as a conditional > property when op-mode is 0 (I2S mode) and mark it as required? That would make it much nicer, yes, thank you! >>> + port: >>> + description: connection for when McASP is used via graph card >>> + type: object >> >> I understand that it can be present under the mcasp node as it is part >> of the graph card binding (or a card binding using graph). >> I mean if a new card binding comes around then we need to document it >> here as well? >> > > Specific properties are not marked for the port. So it should not be an > issue. Other alternative is to mark the additional properties as true > but that is not preferred. If the McASP is used with simple-sound-card (as it is the case most of the time) then the port is not present under the node for this device as the card is not using graph. I consider the port (and the #sound-dai-cells if we are here) not part of the McASP hardware description as they are part of the graph or simple-card binding. I'm fine if the port remains here > Peter, > Any other changes I should make? Not much, this already looking good. I would fix the dts files which generates warning/error with this yaml as they are incorrect. -- Péter
next prev parent reply other threads:[~2021-12-07 19:40 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-03 12:02 [PATCH v4] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Jayesh Choudhary 2021-12-03 12:02 ` Jayesh Choudhary 2021-12-03 23:34 ` Rob Herring 2021-12-03 23:34 ` Rob Herring 2021-12-04 8:20 ` Péter Ujfalusi 2021-12-04 8:20 ` Péter Ujfalusi 2021-12-07 5:03 ` Jayesh Choudhary 2021-12-07 5:03 ` Jayesh Choudhary 2021-12-07 19:44 ` Péter Ujfalusi [this message] 2021-12-07 19:44 ` Péter Ujfalusi 2021-12-09 5:49 ` Jayesh Choudhary 2021-12-09 5:49 ` Jayesh Choudhary 2021-12-10 21:24 ` Rob Herring 2021-12-10 21:24 ` Rob Herring 2021-12-14 4:57 ` Jayesh Choudhary 2021-12-14 4:57 ` Jayesh Choudhary
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b6af56f1-7e6b-81ca-7bae-8f2a2dfaf0eb@gmail.com \ --to=peter.ujfalusi@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=j-choudhary@ti.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.