* [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup
@ 2022-09-26 18:53 Kunal Joshi
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
` (7 more replies)
0 siblings, 8 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
-> Sanitize the state before starting the subtest
-> On test exit add missing igt_display_fini
-> close drm_fd wherever we haven't
Kunal Joshi (5):
tests/chamelium/kms_chamelium.c: test cleanup
tests/i915/kms_pipe_b_c_ivb.c: test cleanup
tests/i915/kms_pwrite_crc.c: cleanup
tests/kms_invalid_mode.c
tests/kms_hdmi_inject: test cleanup
tests/chamelium/kms_chamelium.c | 48 +++++++++++++++++++++++++++++++++
tests/i915/kms_pipe_b_c_ivb.c | 31 +++++++++++++++++++++
tests/i915/kms_pwrite_crc.c | 28 ++++++++++++-------
tests/kms_hdmi_inject.c | 2 ++
tests/kms_invalid_mode.c | 1 +
5 files changed, 100 insertions(+), 10 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
@ 2022-09-26 18:53 ` Kunal Joshi
2022-09-27 8:58 ` B, Jeevan
2022-09-27 13:50 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: " Kunal Joshi
` (6 subsequent siblings)
7 siblings, 2 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
-> Sanitize the state before starting the subtest
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/chamelium/kms_chamelium.c | 48 +++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/tests/chamelium/kms_chamelium.c b/tests/chamelium/kms_chamelium.c
index 1be1c41a..985a906c 100644
--- a/tests/chamelium/kms_chamelium.c
+++ b/tests/chamelium/kms_chamelium.c
@@ -756,6 +756,13 @@ static void test_display_one_mode(data_t *data, struct chamelium_port *port,
igt_output_t *output;
igt_plane_t *primary;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
+
igt_modeset_disable_all_outputs(&data->display);
chamelium_reset_state(&data->display, data->chamelium,
port, data->ports, data->port_count);
@@ -792,6 +799,12 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
if (check == CHAMELIUM_CHECK_ANALOG)
bridge = check_analog_bridge(data, port);
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
i = 0;
do {
igt_output_t *output;
@@ -847,6 +860,12 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
int i, count_modes;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
i = 0;
do {
igt_output_t *output;
@@ -986,6 +1005,12 @@ static void test_mode_timings(data_t *data, struct chamelium_port *port)
{
int i, count_modes;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
i = 0;
igt_require(chamelium_supports_get_video_params(data->chamelium));
do {
@@ -1104,6 +1129,11 @@ static void test_display_aspect_ratio(data_t *data, struct chamelium_port *port)
uint32_t aspect_ratio;
enum infoframe_avi_picture_aspect_ratio frame_ar;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
igt_require(chamelium_supports_get_last_infoframe(data->chamelium));
igt_modeset_disable_all_outputs(&data->display);
@@ -1835,6 +1865,12 @@ test_display_audio(data_t *data, struct chamelium_port *port,
* chamelium_get_audio_format support. */
igt_require(chamelium_has_audio_support(data->chamelium, port));
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
alsa = alsa_init();
igt_assert(alsa);
@@ -1921,6 +1957,12 @@ test_display_audio_edid(data_t *data, struct chamelium_port *port,
igt_require(eld_is_supported());
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
igt_modeset_disable_all_outputs(&data->display);
chamelium_reset_state(&data->display, data->chamelium,
port, data->ports, data->port_count);
@@ -2348,6 +2390,12 @@ static void test_display_planes_random(data_t *data,
unsigned int i;
unsigned int fb_id;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
switch (check) {
case CHAMELIUM_CHECK_CRC:
allow_scaling = false;
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
@ 2022-09-26 18:53 ` Kunal Joshi
2022-09-27 2:45 ` B, Jeevan
2022-09-27 13:53 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup Kunal Joshi
` (5 subsequent siblings)
7 siblings, 2 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
-> Sanitize the state before starting the subtest
-> close drm_fd
Cc: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/i915/kms_pipe_b_c_ivb.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
index 5823ae2a..4f49d7b2 100644
--- a/tests/i915/kms_pipe_b_c_ivb.c
+++ b/tests/i915/kms_pipe_b_c_ivb.c
@@ -142,6 +142,12 @@ test_dpms(data_t *data)
igt_output_t *output1, *output2;
int ret;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
find_outputs(data, &output1, &output2);
igt_info("Pipe %s will use connector %s\n",
@@ -164,6 +170,12 @@ test_lane_reduction(data_t *data)
igt_output_t *output1, *output2;
int ret;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
find_outputs(data, &output1, &output2);
igt_info("Pipe %s will use connector %s\n",
@@ -187,6 +199,12 @@ test_disable_pipe_B(data_t *data)
igt_output_t *output1, *output2;
int ret;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
find_outputs(data, &output1, &output2);
igt_info("Pipe %s will use connector %s\n",
@@ -213,6 +231,12 @@ test_from_C_to_B_with_3_lanes(data_t *data)
igt_output_t *output1, *output2;
int ret;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
find_outputs(data, &output1, &output2);
igt_info("Pipe %s will use connector %s\n",
@@ -236,6 +260,12 @@ test_fail_enable_pipe_C_while_B_has_3_lanes(data_t *data)
igt_output_t *output1, *output2;
int ret;
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
find_outputs(data, &output1, &output2);
igt_info("Pipe %s will use connector %s\n",
@@ -291,5 +321,6 @@ igt_main
igt_fixture {
igt_display_fini(&data.display);
+ close(data.drm_fd);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: " Kunal Joshi
@ 2022-09-26 18:53 ` Kunal Joshi
2022-09-27 8:56 ` B, Jeevan
2022-09-27 13:57 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c Kunal Joshi
` (4 subsequent siblings)
7 siblings, 2 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta, Kunal Joshi
-> Sanitize the state before starting the subtest
-> Kept all the test requirements in igt_fixture
-> clean state with igt_display_fini before exit
-> close drm_fd
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/i915/kms_pwrite_crc.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c
index 584e6a19..b116bd62 100644
--- a/tests/i915/kms_pwrite_crc.c
+++ b/tests/i915/kms_pwrite_crc.c
@@ -160,6 +160,13 @@ static void run_test(data_t *data)
enum pipe pipe;
for_each_pipe_with_valid_output(display, pipe, output) {
+
+ /*
+ * Reset basic pipes, connectors and planes on
+ * @display back to default values.
+ */
+ igt_display_reset(&data->display);
+
data->output = output;
data->pipe = pipe;
@@ -178,17 +185,18 @@ static data_t data;
igt_simple_main
{
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
-
- data.devid = intel_get_drm_devid(data.drm_fd);
-
- kmstest_set_vt_graphics_mode();
-
- igt_require_pipe_crc(data.drm_fd);
-
- igt_display_require(&data.display, data.drm_fd);
+ igt_fixture {
+ data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ data.devid = intel_get_drm_devid(data.drm_fd);
+ kmstest_set_vt_graphics_mode();
+ igt_require_pipe_crc(data.drm_fd);
+ igt_display_require(&data.display, data.drm_fd);
+ }
run_test(&data);
- igt_display_fini(&data.display);
+ igt_fixture {
+ igt_display_fini(&data.display);
+ close(data.drm_fd);
+ }
}
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
` (2 preceding siblings ...)
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup Kunal Joshi
@ 2022-09-26 18:53 ` Kunal Joshi
2022-09-27 8:54 ` B, Jeevan
2022-09-27 13:59 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup Kunal Joshi
` (3 subsequent siblings)
7 siblings, 2 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Kunal Joshi
-> close drm_fd
Cc: Karthik B S <karthik.b.s@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/kms_invalid_mode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 0ae98a31..f1c38669 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -306,5 +306,6 @@ igt_main
igt_fixture {
igt_display_fini(&data.display);
igt_reset_connectors();
+ close(data.drm_fd);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
` (3 preceding siblings ...)
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c Kunal Joshi
@ 2022-09-26 18:53 ` Kunal Joshi
2022-09-27 8:51 ` B, Jeevan
2022-09-27 14:00 ` Swati Sharma
2022-09-26 19:23 ` [igt-dev] ✗ GitLab.Pipeline: warning for IGT " Patchwork
` (2 subsequent siblings)
7 siblings, 2 replies; 21+ messages in thread
From: Kunal Joshi @ 2022-09-26 18:53 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta, Kunal Joshi
-> Free resources
-> close drm_fd
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/kms_hdmi_inject.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
index abae0ab4..0bb51165 100644
--- a/tests/kms_hdmi_inject.c
+++ b/tests/kms_hdmi_inject.c
@@ -219,5 +219,7 @@ igt_main
igt_fixture {
drmModeFreeConnector(connector);
+ drmModeFreeResources(res);
+ close(drm_fd);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for IGT test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
` (4 preceding siblings ...)
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup Kunal Joshi
@ 2022-09-26 19:23 ` Patchwork
2022-09-26 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-27 3:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2022-09-26 19:23 UTC (permalink / raw)
To: Joshi, Kunal1; +Cc: igt-dev
== Series Details ==
Series: IGT test cleanup
URL : https://patchwork.freedesktop.org/series/109075/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/698486 for the overview.
test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/29041747):
Ok: 22
Expected Fail: 3
Fail: 292
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
section_end:1664220066:step_script
section_start:1664220066:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1773 matching files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=29041747 responseStatus=201 Created token=AQNCGq6r
section_end:1664220081:upload_artifacts_on_failure
section_start:1664220081:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1664220081:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/698486
^ permalink raw reply [flat|nested] 21+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for IGT test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
` (5 preceding siblings ...)
2022-09-26 19:23 ` [igt-dev] ✗ GitLab.Pipeline: warning for IGT " Patchwork
@ 2022-09-26 19:47 ` Patchwork
2022-09-27 3:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2022-09-26 19:47 UTC (permalink / raw)
To: Joshi, Kunal1; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4956 bytes --]
== Series Details ==
Series: IGT test cleanup
URL : https://patchwork.freedesktop.org/series/109075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12185 -> IGTPW_7843
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
Participating hosts (46 -> 42)
------------------------------
Missing (4): fi-hsw-4770 fi-bxt-dsi bat-dg2-9 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7843:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-2:
- {bat-dg2-11}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-2.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-2.html
Known issues
------------
Here are the changes found in IGTPW_7843 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- {bat-adlm-1}: [DMESG-WARN][3] ([i915#2867]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-adlm-1/igt@gem_exec_suspend@basic-s3@smem.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/bat-adlm-1/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [DMESG-WARN][5] ([i915#5904]) -> [PASS][6] +30 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][7] ([i915#4983] / [i915#6257] / [i915#6380]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rpls-1/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- {bat-rplp-1}: [DMESG-FAIL][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/bat-rplp-1/igt@i915_selftest@live@slpc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/bat-rplp-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][11] ([i915#5904] / [i915#62]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][13] ([i915#62]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- fi-cfl-8109u: [DMESG-WARN][15] ([i915#62]) -> [PASS][16] +10 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/fi-cfl-8109u/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6663 -> IGTPW_7843
CI-20190529: 20190529
CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7843: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
[-- Attachment #2: Type: text/html, Size: 5880 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: " Kunal Joshi
@ 2022-09-27 2:45 ` B, Jeevan
2022-09-27 8:26 ` Joshi, Kunal1
2022-09-27 13:53 ` Swati Sharma
1 sibling, 1 reply; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 2:45 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev
Hi Kunal,
> -----Original Message-----
> From: Joshi, Kunal1 <kunal1.joshi@intel.com>
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi@intel.com>; B, Jeevan <jeevan.b@intel.com>
> Subject: [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
>
> -> Sanitize the state before starting the subtest close drm_fd
>
> Cc: Jeevan B <jeevan.b@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/i915/kms_pipe_b_c_ivb.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> index 5823ae2a..4f49d7b2 100644
> --- a/tests/i915/kms_pipe_b_c_ivb.c
> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> @@ -142,6 +142,12 @@ test_dpms(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
Can we call this inside fixture ?
Thanks
Jeevan B
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n", @@ -164,6 +170,12 @@
> test_lane_reduction(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n", @@ -187,6 +199,12 @@
> test_disable_pipe_B(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n", @@ -213,6 +231,12 @@
> test_from_C_to_B_with_3_lanes(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n", @@ -236,6 +260,12 @@
> test_fail_enable_pipe_C_while_B_has_3_lanes(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n", @@ -291,5 +321,6 @@
> igt_main
>
> igt_fixture {
> igt_display_fini(&data.display);
> + close(data.drm_fd);
> }
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for IGT test cleanup
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
` (6 preceding siblings ...)
2022-09-26 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-27 3:51 ` Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2022-09-27 3:51 UTC (permalink / raw)
To: Joshi, Kunal1; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 32234 bytes --]
== Series Details ==
Series: IGT test cleanup
URL : https://patchwork.freedesktop.org/series/109075/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12185_full -> IGTPW_7843_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_7843_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_7843_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
Participating hosts (12 -> 6)
------------------------------
Missing (6): pig-kbl-iris shard-tglu pig-glk-j5005 pig-skl-6260u shard-rkl shard-dg1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7843_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_pwrite_crc:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl2/igt@kms_pwrite_crc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl1/igt@kms_pwrite_crc.html
- shard-snb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-snb6/igt@kms_pwrite_crc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-snb7/igt@kms_pwrite_crc.html
- shard-tglb: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb5/igt@kms_pwrite_crc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb2/igt@kms_pwrite_crc.html
- shard-glk: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk2/igt@kms_pwrite_crc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk8/igt@kms_pwrite_crc.html
- shard-iclb: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb6/igt@kms_pwrite_crc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@kms_pwrite_crc.html
* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][11] +46 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb1/igt@nouveau_crc@pipe-b-source-outp-inactive.html
* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-iclb: NOTRUN -> [SKIP][12] +46 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@prime_nv_test@i915_blt_fill_nv_read.html
Known issues
------------
Here are the changes found in IGTPW_7843_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-3x:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#1839])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@feature_discovery@display-3x.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: NOTRUN -> [FAIL][16] ([i915#2410])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_ctx_sseu@invalid-sseu:
- shard-tglb: NOTRUN -> [SKIP][17] ([i915#280])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb3/igt@gem_ctx_sseu@invalid-sseu.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][18] -> [SKIP][19] ([i915#4525])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_capture@capture-recoverable:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#6344])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@gem_exec_capture@capture-recoverable.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl7/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-snb: [PASS][25] -> [INCOMPLETE][26] ([i915#5161])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-snb6/igt@gem_mmap_gtt@fault-concurrent-y.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#4270]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb3/igt@gem_pxp@create-valid-protected-context.html
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#4270])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb3/igt@gem_pxp@create-valid-protected-context.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#768]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb3/igt@gem_userptr_blits@unsync-unmap-after-close.html
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#3297])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gen3_render_linear_blits:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109289]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@gen3_render_linear_blits.html
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#109289]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb1/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][34] -> [DMESG-WARN][35] ([i915#5566] / [i915#716])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/igt@gen9_exec_parse@allowed-all.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk9/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][36] -> [DMESG-WARN][37] ([i915#5566] / [i915#716])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-out:
- shard-iclb: NOTRUN -> [SKIP][38] ([i915#2856])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@gen9_exec_parse@bb-start-out.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#5286])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb4/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][40] -> [FAIL][41] ([i915#1888] / [i915#5138])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk7/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110723])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb3/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3689] / [i915#6095])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl2/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk5/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#3886]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111615] / [i915#3689])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb3/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#6095]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb1/igt@kms_ccs@pipe-c-random-ccs-data-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278]) +12 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb3/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_color_chamelium@ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109284] / [fdo#111827]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_color_chamelium@ctm-negative.html
* igt@kms_content_protection@uevent:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109300] / [fdo#111066])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_content_protection@uevent.html
- shard-apl: NOTRUN -> [FAIL][54] ([i915#2105])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl1/igt@kms_content_protection@uevent.html
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#1063])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb5/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@cursor-offscreen-512x170:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109279] / [i915#3359])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_cursor_crc@cursor-offscreen-512x170.html
* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-iclb: NOTRUN -> [SKIP][57] ([i915#3359])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_cursor_crc@cursor-sliding-512x170.html
* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-iclb: [PASS][58] -> [FAIL][59] ([i915#2346]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
* igt@kms_flip@2x-busy-flip:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb8/igt@kms_flip@2x-busy-flip.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-iclb: [PASS][61] -> [DMESG-WARN][62] ([i915#2867])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb8/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#2587] / [i915#2672]) +5 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][64] -> [SKIP][65] ([i915#3555])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#2587] / [i915#2672]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#2672]) +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#1888] / [i915#2546])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#6497])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109280]) +14 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109280] / [fdo#111825]) +5 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3555]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb1/igt@kms_hdr@bpc-switch-dpms.html
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#3555]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#5176]) +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#5176]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-edp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][77] -> [SKIP][78] ([i915#5235]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb8/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#5235]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#2920])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#111068] / [i915#658])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109441])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271]) +76 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk6/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#112283])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@perf_pmu@event-wait@rcs0.html
* igt@prime_nv_pcopy@test3_4:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271]) +80 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl3/igt@prime_nv_pcopy@test3_4.html
* igt@prime_nv_pcopy@test3_5:
- shard-snb: NOTRUN -> [SKIP][89] ([fdo#109271]) +104 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-snb5/igt@prime_nv_pcopy@test3_5.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][90] ([i915#4525]) -> [PASS][91] +4 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb6/igt@gem_exec_balancer@parallel-keep-in-fence.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][92] ([i915#2842]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][94] ([i915#2842]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@gem_exec_suspend@basic-s3@smem.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl8/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-iclb: [INCOMPLETE][98] ([i915#6453]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb7/igt@gem_exec_whisper@basic-contexts-forked.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][100] ([i915#4281]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@i915_pm_dc@dc9-dpms.html
- shard-apl: [SKIP][102] ([fdo#109271]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-180:
- shard-glk: [FAIL][104] ([i915#1888] / [i915#5138]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk5/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk6/igt@kms_big_fb@y-tiled-8bpp-rotate-180.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][106] ([i915#5235]) -> [PASS][107] +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb1/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][108] ([fdo#109441]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][110] ([i915#6117]) -> [SKIP][111] ([i915#4525])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb4/igt@gem_exec_balancer@parallel-ordering.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb8/igt@gem_exec_balancer@parallel-ordering.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][112] ([i915#1888] / [i915#2842]) -> [FAIL][113] ([i915#2842])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-glk3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][114] ([i915#588]) -> [SKIP][115] ([i915#658])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][116] ([i915#658]) -> [SKIP][117] ([i915#2920])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb1/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][118] ([i915#2920]) -> [SKIP][119] ([i915#658])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb4/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][120] ([i915#2920]) -> [SKIP][121] ([fdo#111068] / [i915#658])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [FAIL][122] ([i915#5939]) -> [SKIP][123] ([fdo#109642] / [fdo#111068] / [i915#658])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-iclb8/igt@kms_psr2_su@page_flip-p010.html
* igt@runner@aborted:
- shard-apl: ([FAIL][124], [FAIL][125], [FAIL][126]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl8/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl1/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12185/shard-apl2/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl8/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl8/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/shard-apl7/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5161]: https://gitlab.freedesktop.org/drm/intel/issues/5161
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6663 -> IGTPW_7843
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12185: ae6a4bb62f9524823ef5b00552e27231f7936da3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7843: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7843/index.html
[-- Attachment #2: Type: text/html, Size: 39387 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
2022-09-27 2:45 ` B, Jeevan
@ 2022-09-27 8:26 ` Joshi, Kunal1
2022-09-27 8:34 ` B, Jeevan
0 siblings, 1 reply; 21+ messages in thread
From: Joshi, Kunal1 @ 2022-09-27 8:26 UTC (permalink / raw)
To: B, Jeevan, igt-dev
>> + /*
>> + * Reset basic pipes, connectors and planes on
>> + * @display back to default values.
>> + */
>> + igt_display_reset(&data->display);
>>
>> Can we call this inside fixture ?
>>
>> Thanks
>> Jeevan B
Hello Jeevan,
Idea was to reset the state before starting the test
Since this reset is inside the subtest igt_fixture isn't required.
Thanks and Regards
Kunal Joshi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
2022-09-27 8:26 ` Joshi, Kunal1
@ 2022-09-27 8:34 ` B, Jeevan
0 siblings, 0 replies; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 8:34 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev
Ok got it.
LGTM.
Reviewed-by: Jeevan B <jeevan.b@intel.com>
> -----Original Message-----
> From: Joshi, Kunal1 <kunal1.joshi@intel.com>
> Sent: Tuesday, September 27, 2022 1:56 PM
> To: B, Jeevan <jeevan.b@intel.com>; igt-dev@lists.freedesktop.org
> Subject: RE: [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
>
> >> + /*
> >> + * Reset basic pipes, connectors and planes on
> >> + * @display back to default values.
> >> + */
> >> + igt_display_reset(&data->display);
> >>
> >> Can we call this inside fixture ?
> >>
> >> Thanks
> >> Jeevan B
>
> Hello Jeevan,
>
> Idea was to reset the state before starting the test Since this reset is inside
> the subtest igt_fixture isn't required.
>
> Thanks and Regards
> Kunal Joshi
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup Kunal Joshi
@ 2022-09-27 8:51 ` B, Jeevan
2022-09-27 14:00 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 8:51 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev; +Cc: Gupta, Nidhi1, Joshi, Kunal1
LGTM
Reviewed-by: Jeevan B <jeevan.b@intel.com>
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>; Joshi, Kunal1
> <kunal1.joshi@intel.com>
> Subject: [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup
>
> -> Free resources
> -> close drm_fd
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/kms_hdmi_inject.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c index
> abae0ab4..0bb51165 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -219,5 +219,7 @@ igt_main
>
> igt_fixture {
> drmModeFreeConnector(connector);
> + drmModeFreeResources(res);
> + close(drm_fd);
> }
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c Kunal Joshi
@ 2022-09-27 8:54 ` B, Jeevan
2022-09-27 13:59 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 8:54 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev; +Cc: Joshi, Kunal1
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi@intel.com>
Hi Kunal,
Correct subject.
Thanks
Jeevan B
> Subject: [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c
>
> -> close drm_fd
>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/kms_invalid_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c index
> 0ae98a31..f1c38669 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -306,5 +306,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + close(data.drm_fd);
> }
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup Kunal Joshi
@ 2022-09-27 8:56 ` B, Jeevan
2022-09-27 13:57 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 8:56 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev; +Cc: Gupta, Nidhi1, Joshi, Kunal1
This test is failing please check.
Possible regressions
igt@kms_pwrite_crc:
shard-apl: PASS -> FAIL
shard-snb: PASS -> FAIL
shard-tglb: PASS -> FAIL
shard-glk: PASS -> FAIL
shard-iclb: PASS -> FAIL
Thanks
Jeevan B
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>; Joshi, Kunal1
> <kunal1.joshi@intel.com>
> Subject: [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup
>
> -> Sanitize the state before starting the subtest Kept all the test
> -> requirements in igt_fixture clean state with igt_display_fini before
> -> exit close drm_fd
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/i915/kms_pwrite_crc.c | 28 ++++++++++++++++++----------
> 1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c index
> 584e6a19..b116bd62 100644
> --- a/tests/i915/kms_pwrite_crc.c
> +++ b/tests/i915/kms_pwrite_crc.c
> @@ -160,6 +160,13 @@ static void run_test(data_t *data)
> enum pipe pipe;
>
> for_each_pipe_with_valid_output(display, pipe, output) {
> +
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> data->output = output;
> data->pipe = pipe;
>
> @@ -178,17 +185,18 @@ static data_t data;
>
> igt_simple_main
> {
> - data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> -
> - data.devid = intel_get_drm_devid(data.drm_fd);
> -
> - kmstest_set_vt_graphics_mode();
> -
> - igt_require_pipe_crc(data.drm_fd);
> -
> - igt_display_require(&data.display, data.drm_fd);
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> + data.devid = intel_get_drm_devid(data.drm_fd);
> + kmstest_set_vt_graphics_mode();
> + igt_require_pipe_crc(data.drm_fd);
> + igt_display_require(&data.display, data.drm_fd);
> + }
>
> run_test(&data);
>
> - igt_display_fini(&data.display);
> + igt_fixture {
> + igt_display_fini(&data.display);
> + close(data.drm_fd);
> + }
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
@ 2022-09-27 8:58 ` B, Jeevan
2022-09-27 13:50 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: B, Jeevan @ 2022-09-27 8:58 UTC (permalink / raw)
To: Joshi, Kunal1, igt-dev; +Cc: Joshi, Kunal1
LGTM
Reviewed-by: Jeevan B <jeevan.b@intel.com>
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Kunal
> Joshi
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev@lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi@intel.com>
> Subject: [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c:
> test cleanup
>
> -> Sanitize the state before starting the subtest
>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/chamelium/kms_chamelium.c | 48
> +++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/tests/chamelium/kms_chamelium.c
> b/tests/chamelium/kms_chamelium.c index 1be1c41a..985a906c 100644
> --- a/tests/chamelium/kms_chamelium.c
> +++ b/tests/chamelium/kms_chamelium.c
> @@ -756,6 +756,13 @@ static void test_display_one_mode(data_t *data,
> struct chamelium_port *port,
> igt_output_t *output;
> igt_plane_t *primary;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> +
> igt_modeset_disable_all_outputs(&data->display);
> chamelium_reset_state(&data->display, data->chamelium,
> port, data->ports, data->port_count); @@ -792,6
> +799,12 @@ static void test_display_all_modes(data_t *data, struct
> chamelium_port *port,
> if (check == CHAMELIUM_CHECK_ANALOG)
> bridge = check_analog_bridge(data, port);
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> do {
> igt_output_t *output;
> @@ -847,6 +860,12 @@ test_display_frame_dump(data_t *data, struct
> chamelium_port *port)
>
> int i, count_modes;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> do {
> igt_output_t *output;
> @@ -986,6 +1005,12 @@ static void test_mode_timings(data_t *data, struct
> chamelium_port *port) {
> int i, count_modes;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> igt_require(chamelium_supports_get_video_params(data-
> >chamelium));
> do {
> @@ -1104,6 +1129,11 @@ static void test_display_aspect_ratio(data_t
> *data, struct chamelium_port *port)
> uint32_t aspect_ratio;
> enum infoframe_avi_picture_aspect_ratio frame_ar;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> igt_require(chamelium_supports_get_last_infoframe(data-
> >chamelium));
>
> igt_modeset_disable_all_outputs(&data->display);
> @@ -1835,6 +1865,12 @@ test_display_audio(data_t *data, struct
> chamelium_port *port,
> * chamelium_get_audio_format support. */
> igt_require(chamelium_has_audio_support(data->chamelium, port));
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> alsa = alsa_init();
> igt_assert(alsa);
>
> @@ -1921,6 +1957,12 @@ test_display_audio_edid(data_t *data, struct
> chamelium_port *port,
>
> igt_require(eld_is_supported());
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> igt_modeset_disable_all_outputs(&data->display);
> chamelium_reset_state(&data->display, data->chamelium,
> port, data->ports, data->port_count); @@ -
> 2348,6 +2390,12 @@ static void test_display_planes_random(data_t *data,
> unsigned int i;
> unsigned int fb_id;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> switch (check) {
> case CHAMELIUM_CHECK_CRC:
> allow_scaling = false;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
2022-09-27 8:58 ` B, Jeevan
@ 2022-09-27 13:50 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: Swati Sharma @ 2022-09-27 13:50 UTC (permalink / raw)
To: Kunal Joshi, igt-dev
Hi Kunal,
Please don't add .c in subj.
On 27-Sep-22 12:23 AM, Kunal Joshi wrote:
> -> Sanitize the state before starting the subtest
>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/chamelium/kms_chamelium.c | 48 +++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/tests/chamelium/kms_chamelium.c b/tests/chamelium/kms_chamelium.c
> index 1be1c41a..985a906c 100644
> --- a/tests/chamelium/kms_chamelium.c
> +++ b/tests/chamelium/kms_chamelium.c
> @@ -756,6 +756,13 @@ static void test_display_one_mode(data_t *data, struct chamelium_port *port,
> igt_output_t *output;
> igt_plane_t *primary;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
>> No need of this comment. igt_display_reset() already has its
description in lib.
Please remove other comments too.
> + igt_display_reset(&data->display);
> +
> +
> igt_modeset_disable_all_outputs(&data->display);
> chamelium_reset_state(&data->display, data->chamelium,
> port, data->ports, data->port_count);
> @@ -792,6 +799,12 @@ static void test_display_all_modes(data_t *data, struct chamelium_port *port,
> if (check == CHAMELIUM_CHECK_ANALOG)
> bridge = check_analog_bridge(data, port);
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> do {
> igt_output_t *output;
> @@ -847,6 +860,12 @@ test_display_frame_dump(data_t *data, struct chamelium_port *port)
>
> int i, count_modes;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> do {
> igt_output_t *output;
> @@ -986,6 +1005,12 @@ static void test_mode_timings(data_t *data, struct chamelium_port *port)
> {
> int i, count_modes;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> i = 0;
> igt_require(chamelium_supports_get_video_params(data->chamelium));
> do {
> @@ -1104,6 +1129,11 @@ static void test_display_aspect_ratio(data_t *data, struct chamelium_port *port)
> uint32_t aspect_ratio;
> enum infoframe_avi_picture_aspect_ratio frame_ar;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> igt_require(chamelium_supports_get_last_infoframe(data->chamelium));
>
> igt_modeset_disable_all_outputs(&data->display);
> @@ -1835,6 +1865,12 @@ test_display_audio(data_t *data, struct chamelium_port *port,
> * chamelium_get_audio_format support. */
> igt_require(chamelium_has_audio_support(data->chamelium, port));
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> alsa = alsa_init();
> igt_assert(alsa);
>
> @@ -1921,6 +1957,12 @@ test_display_audio_edid(data_t *data, struct chamelium_port *port,
>
> igt_require(eld_is_supported());
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> igt_modeset_disable_all_outputs(&data->display);
> chamelium_reset_state(&data->display, data->chamelium,
> port, data->ports, data->port_count);
> @@ -2348,6 +2390,12 @@ static void test_display_planes_random(data_t *data,
> unsigned int i;
> unsigned int fb_id;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> switch (check) {
> case CHAMELIUM_CHECK_CRC:
> allow_scaling = false;
--
~Swati Sharma
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: " Kunal Joshi
2022-09-27 2:45 ` B, Jeevan
@ 2022-09-27 13:53 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: Swati Sharma @ 2022-09-27 13:53 UTC (permalink / raw)
To: Kunal Joshi, igt-dev
Hi Kunal,
Same comments here too.
.c should not be there in subj.
On 27-Sep-22 12:23 AM, Kunal Joshi wrote:
> -> Sanitize the state before starting the subtest
> -> close drm_fd
>
> Cc: Jeevan B <jeevan.b@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/i915/kms_pipe_b_c_ivb.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> index 5823ae2a..4f49d7b2 100644
> --- a/tests/i915/kms_pipe_b_c_ivb.c
> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> @@ -142,6 +142,12 @@ test_dpms(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
>> Comment not required at all.
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n",
> @@ -164,6 +170,12 @@ test_lane_reduction(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n",
> @@ -187,6 +199,12 @@ test_disable_pipe_B(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n",
> @@ -213,6 +231,12 @@ test_from_C_to_B_with_3_lanes(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n",
> @@ -236,6 +260,12 @@ test_fail_enable_pipe_C_while_B_has_3_lanes(data_t *data)
> igt_output_t *output1, *output2;
> int ret;
>
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> find_outputs(data, &output1, &output2);
>
> igt_info("Pipe %s will use connector %s\n",
> @@ -291,5 +321,6 @@ igt_main
>
> igt_fixture {
> igt_display_fini(&data.display);
> + close(data.drm_fd);
> }
> }
--
~Swati Sharma
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup Kunal Joshi
2022-09-27 8:56 ` B, Jeevan
@ 2022-09-27 13:57 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: Swati Sharma @ 2022-09-27 13:57 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Nidhi Gupta
Hi Kunal,
Few comments below:
-Drop .c from subj.
-Remove comments those are unnecessary.
-Improve your commit message.
On 27-Sep-22 12:23 AM, Kunal Joshi wrote:
> -> Sanitize the state before starting the subtest
> -> Kept all the test requirements in igt_fixture
> -> clean state with igt_display_fini before exit
> -> close drm_fd
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/i915/kms_pwrite_crc.c | 28 ++++++++++++++++++----------
> 1 file changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/tests/i915/kms_pwrite_crc.c b/tests/i915/kms_pwrite_crc.c
> index 584e6a19..b116bd62 100644
> --- a/tests/i915/kms_pwrite_crc.c
> +++ b/tests/i915/kms_pwrite_crc.c
> @@ -160,6 +160,13 @@ static void run_test(data_t *data)
> enum pipe pipe;
>
> for_each_pipe_with_valid_output(display, pipe, output) {
> +
> + /*
> + * Reset basic pipes, connectors and planes on
> + * @display back to default values.
> + */
> + igt_display_reset(&data->display);
> +
> data->output = output;
> data->pipe = pipe;
>
> @@ -178,17 +185,18 @@ static data_t data;
>
> igt_simple_main
> {
> - data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> -
> - data.devid = intel_get_drm_devid(data.drm_fd);
> -
> - kmstest_set_vt_graphics_mode();
> -
> - igt_require_pipe_crc(data.drm_fd);
> -
> - igt_display_require(&data.display, data.drm_fd);
> + igt_fixture {
> + data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> + data.devid = intel_get_drm_devid(data.drm_fd);
> + kmstest_set_vt_graphics_mode();
> + igt_require_pipe_crc(data.drm_fd);
> + igt_display_require(&data.display, data.drm_fd);
> + }
>
> run_test(&data);
>
> - igt_display_fini(&data.display);
> + igt_fixture {
> + igt_display_fini(&data.display);
> + close(data.drm_fd);
> + }
> }
--
~Swati Sharma
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c Kunal Joshi
2022-09-27 8:54 ` B, Jeevan
@ 2022-09-27 13:59 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: Swati Sharma @ 2022-09-27 13:59 UTC (permalink / raw)
To: Kunal Joshi, igt-dev
Hi Kunal,
Drop .c from subj. Complete your subj and add commit message.
On 27-Sep-22 12:23 AM, Kunal Joshi wrote:
> -> close drm_fd
>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/kms_invalid_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 0ae98a31..f1c38669 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -306,5 +306,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + close(data.drm_fd);
> }
> }
--
~Swati Sharma
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup Kunal Joshi
2022-09-27 8:51 ` B, Jeevan
@ 2022-09-27 14:00 ` Swati Sharma
1 sibling, 0 replies; 21+ messages in thread
From: Swati Sharma @ 2022-09-27 14:00 UTC (permalink / raw)
To: Kunal Joshi, igt-dev; +Cc: Nidhi Gupta
Hi Kunal,
Please improve your commit message.
We don't write commit message as points.
On 27-Sep-22 12:23 AM, Kunal Joshi wrote:
> -> Free resources
> -> close drm_fd
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/kms_hdmi_inject.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c
> index abae0ab4..0bb51165 100644
> --- a/tests/kms_hdmi_inject.c
> +++ b/tests/kms_hdmi_inject.c
> @@ -219,5 +219,7 @@ igt_main
>
> igt_fixture {
> drmModeFreeConnector(connector);
> + drmModeFreeResources(res);
> + close(drm_fd);
> }
> }
--
~Swati Sharma
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2022-09-27 14:00 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 18:53 [igt-dev] [PATCH i-g-t v1 0/5] IGT test cleanup Kunal Joshi
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 1/5] tests/chamelium/kms_chamelium.c: " Kunal Joshi
2022-09-27 8:58 ` B, Jeevan
2022-09-27 13:50 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: " Kunal Joshi
2022-09-27 2:45 ` B, Jeevan
2022-09-27 8:26 ` Joshi, Kunal1
2022-09-27 8:34 ` B, Jeevan
2022-09-27 13:53 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 3/5] tests/i915/kms_pwrite_crc.c: cleanup Kunal Joshi
2022-09-27 8:56 ` B, Jeevan
2022-09-27 13:57 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 4/5] tests/kms_invalid_mode.c Kunal Joshi
2022-09-27 8:54 ` B, Jeevan
2022-09-27 13:59 ` Swati Sharma
2022-09-26 18:53 ` [igt-dev] [PATCH i-g-t v1 5/5] tests/kms_hdmi_inject: test cleanup Kunal Joshi
2022-09-27 8:51 ` B, Jeevan
2022-09-27 14:00 ` Swati Sharma
2022-09-26 19:23 ` [igt-dev] ✗ GitLab.Pipeline: warning for IGT " Patchwork
2022-09-26 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-27 3:51 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.