All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Lin Ming <ming.m.lin@intel.com>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	yakui_zhao <yakui.zhao@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>
Subject: Re: [BISECTED] Was Re: acpi/suspend - irq 9: nobody cared
Date: Wed, 13 May 2009 11:30:02 -0400	[thread overview]
Message-ID: <b6c5339f0905130830k3549095dv3eee08d7d3155a37@mail.gmail.com> (raw)
In-Reply-To: <200905131015.45635.rjw@sisk.pl>

2009/5/13 Rafael J. Wysocki <rjw@sisk.pl>:
>> So we preserve SCI_EN bit per spec.
>
> In fact we do set SCI_EN directly in drivers/acpi/sleep.c in a couple of
> places exactly because the hardware is _known_ to wrong things here.  So, we
> don't really preserve it, _exactly_ because at least some pieces of hardware
> out there don't follow the spec.  Including Macs, IIRC.
>
> Bob, can you please verify if the Lin Ming's patch helps?

Yes, my laptop is one of those pieces of hardware.  I can confirm that Lin
Ming's patch works on my system.

-- 
Bob Copeland %% www.bobcopeland.com
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Lin Ming <ming.m.lin@intel.com>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	yakui_zhao <yakui.zhao@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Moore, Robert" <robert.moore@intel.com>
Subject: Re: [BISECTED] Was Re: acpi/suspend - irq 9: nobody cared
Date: Wed, 13 May 2009 11:30:02 -0400	[thread overview]
Message-ID: <b6c5339f0905130830k3549095dv3eee08d7d3155a37@mail.gmail.com> (raw)
In-Reply-To: <200905131015.45635.rjw@sisk.pl>

2009/5/13 Rafael J. Wysocki <rjw@sisk.pl>:
>> So we preserve SCI_EN bit per spec.
>
> In fact we do set SCI_EN directly in drivers/acpi/sleep.c in a couple of
> places exactly because the hardware is _known_ to wrong things here.  So, we
> don't really preserve it, _exactly_ because at least some pieces of hardware
> out there don't follow the spec.  Including Macs, IIRC.
>
> Bob, can you please verify if the Lin Ming's patch helps?

Yes, my laptop is one of those pieces of hardware.  I can confirm that Lin
Ming's patch works on my system.

-- 
Bob Copeland %% www.bobcopeland.com

  reply	other threads:[~2009-05-13 15:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 10:58 acpi/suspend - irq 9: nobody cared Bob Copeland
2009-05-08  1:53 ` yakui_zhao
2009-05-12 19:01   ` Bjorn Helgaas
2009-05-12 19:26     ` Bob Copeland
2009-05-12 19:26       ` Bob Copeland
2009-05-13  4:05     ` [BISECTED] Was " Bob Copeland
     [not found]       ` <d3f22a0905122245h15786220g31ad0dcb8caa3a38@mail.gmail.com>
2009-05-13  5:36         ` Lin Ming
2009-05-13  8:15           ` Rafael J. Wysocki
2009-05-13 15:30             ` Bob Copeland [this message]
2009-05-13 15:30               ` Bob Copeland
2009-05-16  2:34               ` [PATCH] ACPI: resume: re-enable SCI-enable workaround Len Brown
2009-05-16  3:30                 ` Moore, Robert
2009-05-16  5:49                   ` Len Brown
2009-05-16  6:50                     ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6c5339f0905130830k3549095dv3eee08d7d3155a37@mail.gmail.com \
    --to=me@bobcopeland.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.