From: Bob Copeland <bcopeland@gmail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, devel@linuxdriverproject.org
Subject: Re: [PATCH 3/4] ath5k: define ath_common ops
Date: Thu, 10 Sep 2009 21:42:03 -0400 [thread overview]
Message-ID: <b6c5339f0909101842t74479b34heaf0628d1a3b7edb@mail.gmail.com> (raw)
In-Reply-To: <1252632895-11914-4-git-send-email-lrodriguez@atheros.com>
On Thu, Sep 10, 2009 at 9:34 PM, Luis R. Rodriguez
<lrodriguez@atheros.com> wrote:
> static inline u32 ath5k_hw_reg_read(struct ath5k_hw *ah, u16 reg)
> {
> - return ioread32(ah->ah_iobase + reg);
> + return ath5k_hw_common(ah)->ops->read(ah, reg);
> }
Is there any way we can do this without two pointer dereferences for every
read and write? I have a feeling this is going to make certain operations
(e.g. loading initvals during reset) really suck.
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <bcopeland@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 3/4] ath5k: define ath_common ops
Date: Thu, 10 Sep 2009 21:42:03 -0400 [thread overview]
Message-ID: <b6c5339f0909101842t74479b34heaf0628d1a3b7edb@mail.gmail.com> (raw)
In-Reply-To: <1252632895-11914-4-git-send-email-lrodriguez@atheros.com>
On Thu, Sep 10, 2009 at 9:34 PM, Luis R. Rodriguez
<lrodriguez@atheros.com> wrote:
> ?static inline u32 ath5k_hw_reg_read(struct ath5k_hw *ah, u16 reg)
> ?{
> - ? ? ? return ioread32(ah->ah_iobase + reg);
> + ? ? ? return ath5k_hw_common(ah)->ops->read(ah, reg);
> ?}
Is there any way we can do this without two pointer dereferences for every
read and write? I have a feeling this is going to make certain operations
(e.g. loading initvals during reset) really suck.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-09-11 1:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 1:34 [PATCH 0/4] atheros: implement common read/write ops Luis R. Rodriguez
2009-09-11 1:34 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 1/4] atheros/ath9k: add common read/write ops and port ath9k to use it Luis R. Rodriguez
2009-09-11 1:34 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 2/4] ath5k: allocate ath5k_hw prior to initializing hw Luis R. Rodriguez
2009-09-11 1:34 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 3/4] ath5k: define ath_common ops Luis R. Rodriguez
2009-09-11 1:34 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 1:42 ` Bob Copeland [this message]
2009-09-11 1:42 ` Bob Copeland
2009-09-11 1:46 ` Luis R. Rodriguez
2009-09-11 1:46 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 6:16 ` Nick Kossifidis
2009-09-11 6:16 ` [ath9k-devel] " Nick Kossifidis
2009-09-11 6:46 ` Jiri Slaby
2009-09-11 6:46 ` [ath9k-devel] " Jiri Slaby
2009-09-11 7:23 ` Luis R. Rodriguez
2009-09-11 7:23 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 11:35 ` Bob Copeland
2009-09-11 11:35 ` [ath9k-devel] " Bob Copeland
2009-09-11 17:53 ` Luis R. Rodriguez
2009-09-11 17:53 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 14:24 ` Linus Torvalds
2009-09-11 14:24 ` [ath9k-devel] " Linus Torvalds
2009-09-11 17:43 ` Luis R. Rodriguez
2009-09-11 17:43 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 20:11 ` Linus Torvalds
2009-09-11 20:11 ` [ath9k-devel] " Linus Torvalds
2009-09-12 11:53 ` Jiri Slaby
2009-09-12 11:53 ` [ath9k-devel] " Jiri Slaby
2009-09-13 0:56 ` Luis R. Rodriguez
2009-09-13 0:56 ` [ath9k-devel] " Luis R. Rodriguez
2009-09-11 1:34 ` [PATCH 4/4] atheros: define shared bssidmask setting Luis R. Rodriguez
2009-09-11 1:34 ` [ath9k-devel] " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f0909101842t74479b34heaf0628d1a3b7edb@mail.gmail.com \
--to=bcopeland@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=devel@linuxdriverproject.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.