* [PATCH] nvmet: remove unused variable
@ 2020-04-25 19:39 Chaitanya Kulkarni
2020-04-29 0:04 ` Sagi Grimberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-04-25 19:39 UTC (permalink / raw)
To: linux-nvme; +Cc: Chaitanya Kulkarni
nvmet_file_ns_enable() now uses nvmet_file_ns_revalidate() to read
the size of the file. Remove variable stat which also fixes the
following compilation warning:-
drivers/nvme//target/io-cmd-file.c: In function ‘nvmet_file_ns_enable’:
drivers/nvme//target/io-cmd-file.c:45:15: warning: unused variable ‘stat’ [-Wunused-variable]
struct kstat stat;
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/nvme/target/io-cmd-file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c
index 8ece9cab5114..f0bd08d86ac0 100644
--- a/drivers/nvme/target/io-cmd-file.c
+++ b/drivers/nvme/target/io-cmd-file.c
@@ -42,7 +42,6 @@ void nvmet_file_ns_disable(struct nvmet_ns *ns)
int nvmet_file_ns_enable(struct nvmet_ns *ns)
{
int flags = O_RDWR | O_LARGEFILE;
- struct kstat stat;
int ret;
if (!ns->buffered_io)
--
2.22.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: remove unused variable
2020-04-25 19:39 [PATCH] nvmet: remove unused variable Chaitanya Kulkarni
@ 2020-04-29 0:04 ` Sagi Grimberg
2020-04-29 11:18 ` Max Gurtovoy
2020-05-01 12:40 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-04-29 0:04 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: remove unused variable
2020-04-25 19:39 [PATCH] nvmet: remove unused variable Chaitanya Kulkarni
2020-04-29 0:04 ` Sagi Grimberg
@ 2020-04-29 11:18 ` Max Gurtovoy
2020-05-01 12:40 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Max Gurtovoy @ 2020-04-29 11:18 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-nvme
On 4/25/2020 10:39 PM, Chaitanya Kulkarni wrote:
> nvmet_file_ns_enable() now uses nvmet_file_ns_revalidate() to read
> the size of the file. Remove variable stat which also fixes the
> following compilation warning:-
>
> drivers/nvme//target/io-cmd-file.c: In function ‘nvmet_file_ns_enable’:
> drivers/nvme//target/io-cmd-file.c:45:15: warning: unused variable ‘stat’ [-Wunused-variable]
> struct kstat stat;
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> drivers/nvme/target/io-cmd-file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c
> index 8ece9cab5114..f0bd08d86ac0 100644
> --- a/drivers/nvme/target/io-cmd-file.c
> +++ b/drivers/nvme/target/io-cmd-file.c
> @@ -42,7 +42,6 @@ void nvmet_file_ns_disable(struct nvmet_ns *ns)
> int nvmet_file_ns_enable(struct nvmet_ns *ns)
> {
> int flags = O_RDWR | O_LARGEFILE;
> - struct kstat stat;
> int ret;
>
> if (!ns->buffered_io)
wanted to send same fix:
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: remove unused variable
2020-04-25 19:39 [PATCH] nvmet: remove unused variable Chaitanya Kulkarni
2020-04-29 0:04 ` Sagi Grimberg
2020-04-29 11:18 ` Max Gurtovoy
@ 2020-05-01 12:40 ` Christoph Hellwig
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-05-01 12:40 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-nvme
Thanks, folded into the original patch.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-01 12:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-25 19:39 [PATCH] nvmet: remove unused variable Chaitanya Kulkarni
2020-04-29 0:04 ` Sagi Grimberg
2020-04-29 11:18 ` Max Gurtovoy
2020-05-01 12:40 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.