* [PATCH] media: v4l2-ctrls: Fix typo in VP8 comment
@ 2022-08-11 20:37 Deborah Brouwer
2022-08-16 14:39 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Deborah Brouwer @ 2022-08-11 20:37 UTC (permalink / raw)
To: linux-media; +Cc: ezequiel, daniel.almeida, Deborah Brouwer
The comment for the VP8 loop filter flags uses the partially wrong name
for the flags. Unlike the other VP8 flag names, the loop filter flag names
don't have "_FLAG" in them. Change the comment so that it matches the
actual flag definitions in the header.
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
---
include/uapi/linux/v4l2-controls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
index 5f46bf4a570c..a1363c59902d 100644
--- a/include/uapi/linux/v4l2-controls.h
+++ b/include/uapi/linux/v4l2-controls.h
@@ -1730,7 +1730,7 @@ struct v4l2_vp8_segment {
* @sharpness_level: matches sharpness_level syntax element.
* @level: matches loop_filter_level syntax element.
* @padding: padding field. Should be zeroed by applications.
- * @flags: see V4L2_VP8_LF_FLAG_{}.
+ * @flags: see V4L2_VP8_LF_{}.
*
* This structure contains loop filter related parameters.
* See the 'mb_lf_adjustments()' part of the frame header syntax,
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: v4l2-ctrls: Fix typo in VP8 comment
2022-08-11 20:37 [PATCH] media: v4l2-ctrls: Fix typo in VP8 comment Deborah Brouwer
@ 2022-08-16 14:39 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2022-08-16 14:39 UTC (permalink / raw)
To: Deborah Brouwer, linux-media; +Cc: ezequiel, daniel.almeida
Le jeudi 11 août 2022 à 13:37 -0700, Deborah Brouwer a écrit :
> The comment for the VP8 loop filter flags uses the partially wrong name
> for the flags. Unlike the other VP8 flag names, the loop filter flag names
> don't have "_FLAG" in them. Change the comment so that it matches the
> actual flag definitions in the header.
oops, perhaps it should have had that, but can't change it anymore.
Nice catch!
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Fixes: 363240ce1c08 ("media: uapi: move VP8 stateless controls out of staging")
>
> Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
> ---
> include/uapi/linux/v4l2-controls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 5f46bf4a570c..a1363c59902d 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/
>
> include/uapi/linux/v4l2-controls.h
> @@ -1730,7 +1730,7 @@ struct v4l2_vp8_segment {
> * @sharpness_level: matches sharpness_level syntax element.
> * @level: matches loop_filter_level syntax element.
> * @padding: padding field. Should be zeroed by applications.
> - * @flags: see V4L2_VP8_LF_FLAG_{}.
> + * @flags: see V4L2_VP8_LF_{}.
> *
> * This structure contains loop filter related parameters.
> * See the 'mb_lf_adjustments()' part of the frame header syntax,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 20:37 [PATCH] media: v4l2-ctrls: Fix typo in VP8 comment Deborah Brouwer
2022-08-16 14:39 ` Nicolas Dufresne
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.