* [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh
@ 2017-09-28 3:41 David Ahern
2017-09-29 5:20 ` David Miller
2017-10-01 10:44 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2017-09-28 3:41 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
fib_check_nh does not use the fib_info arg; remove t.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv4/fib_semantics.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 57a5d48acee8..79989124607e 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -774,8 +774,8 @@ bool fib_metrics_match(struct fib_config *cfg, struct fib_info *fi)
* |
* |-> {local prefix} (terminal node)
*/
-static int fib_check_nh(struct fib_config *cfg, struct fib_info *fi,
- struct fib_nh *nh, struct netlink_ext_ack *extack)
+static int fib_check_nh(struct fib_config *cfg, struct fib_nh *nh,
+ struct netlink_ext_ack *extack)
{
int err = 0;
struct net *net;
@@ -1258,7 +1258,7 @@ struct fib_info *fib_create_info(struct fib_config *cfg,
int linkdown = 0;
change_nexthops(fi) {
- err = fib_check_nh(cfg, fi, nexthop_nh, extack);
+ err = fib_check_nh(cfg, nexthop_nh, extack);
if (err != 0)
goto failure;
if (nexthop_nh->nh_flags & RTNH_F_LINKDOWN)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh
2017-09-28 3:41 [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh David Ahern
@ 2017-09-29 5:20 ` David Miller
2017-10-01 10:44 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-09-29 5:20 UTC (permalink / raw)
To: dsahern; +Cc: netdev
From: David Ahern <dsahern@gmail.com>
Date: Wed, 27 Sep 2017 20:41:59 -0700
> fib_check_nh does not use the fib_info arg; remove t.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh
2017-09-28 3:41 [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh David Ahern
2017-09-29 5:20 ` David Miller
@ 2017-10-01 10:44 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2017-10-01 10:44 UTC (permalink / raw)
To: David Ahern, netdev
Hello!
On 9/28/2017 6:41 AM, David Ahern wrote:
> fib_check_nh does not use the fib_info arg; remove t.
s/t/it/. :-)
> Signed-off-by: David Ahern <dsahern@gmail.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-01 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 3:41 [PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh David Ahern
2017-09-29 5:20 ` David Miller
2017-10-01 10:44 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.