From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: allison@lohutok.net, baohua@kernel.org,
bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
festevam@gmail.com, gregkh@linuxfoundation.org, info@metux.net,
kernel@pengutronix.de, kgene@kernel.org, khilman@baylibre.com,
krzk@kernel.org, kstewart@linuxfoundation.org,
linus.walleij@linaro.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux@prisktech.co.nz, nsaenzjulienne@suse.de, rjui@broadcom.com,
s.hauer@pengutronix.de, sbranden@broadcom.com,
shawnguo@kernel.org, tglx@linutronix.de,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id
Date: Thu, 12 Mar 2020 19:23:41 +0100 [thread overview]
Message-ID: <b7541667-05e1-6a54-165f-7d8ad66f5b33@linaro.org> (raw)
In-Reply-To: <20200312064817.19000-1-afzal.mohd.ma@gmail.com>
On 12/03/2020 07:48, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> request_irq() does a few sanity checks that were not done in
> setup_irq(), if they fail irq registration will fail. One of the check
> is to ensure that non-NULL dev_id is passed in the case of shared irq.
>
> Fix it by passing non-NULL dev_id while registering the shared irq.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
>
> Hi Daniel,
>
> i have assumed that you would not rebase your drivers/next tree & put the
> SHA-id in Fixes tag.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: kstewart@linuxfoundation.org, linus.walleij@linaro.org,
shawnguo@kernel.org, festevam@gmail.com, f.fainelli@gmail.com,
khilman@baylibre.com, krzk@kernel.org, kgene@kernel.org,
bcm-kernel-feedback-list@broadcom.com, allison@lohutok.net,
u.kleine-koenig@pengutronix.de, linux-imx@nxp.com,
rjui@broadcom.com, s.hauer@pengutronix.de,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, baohua@kernel.org,
sbranden@broadcom.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux@prisktech.co.nz,
kernel@pengutronix.de, info@metux.net, nsaenzjulienne@suse.de
Subject: Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id
Date: Thu, 12 Mar 2020 19:23:41 +0100 [thread overview]
Message-ID: <b7541667-05e1-6a54-165f-7d8ad66f5b33@linaro.org> (raw)
In-Reply-To: <20200312064817.19000-1-afzal.mohd.ma@gmail.com>
On 12/03/2020 07:48, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> request_irq() does a few sanity checks that were not done in
> setup_irq(), if they fail irq registration will fail. One of the check
> is to ensure that non-NULL dev_id is passed in the case of shared irq.
>
> Fix it by passing non-NULL dev_id while registering the shared irq.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
>
> Hi Daniel,
>
> i have assumed that you would not rebase your drivers/next tree & put the
> SHA-id in Fixes tag.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: kstewart@linuxfoundation.org, linus.walleij@linaro.org,
shawnguo@kernel.org, festevam@gmail.com, f.fainelli@gmail.com,
khilman@baylibre.com, krzk@kernel.org, kgene@kernel.org,
bcm-kernel-feedback-list@broadcom.com, allison@lohutok.net,
u.kleine-koenig@pengutronix.de, linux-imx@nxp.com,
rjui@broadcom.com, s.hauer@pengutronix.de,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, baohua@kernel.org,
sbranden@broadcom.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux@prisktech.co.nz,
kernel@pengutronix.de, info@metux.net, nsaenzjulienne@suse.de
Subject: Re: [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id
Date: Thu, 12 Mar 2020 19:23:41 +0100 [thread overview]
Message-ID: <b7541667-05e1-6a54-165f-7d8ad66f5b33@linaro.org> (raw)
In-Reply-To: <20200312064817.19000-1-afzal.mohd.ma@gmail.com>
On 12/03/2020 07:48, afzal mohammed wrote:
> Recently all usages of setup_irq() was replaced by request_irq().
> request_irq() does a few sanity checks that were not done in
> setup_irq(), if they fail irq registration will fail. One of the check
> is to ensure that non-NULL dev_id is passed in the case of shared irq.
>
> Fix it by passing non-NULL dev_id while registering the shared irq.
>
> Fixes: cc2550b421aa ("clocksource: Replace setup_irq() by request_irq()")
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
>
> Hi Daniel,
>
> i have assumed that you would not rebase your drivers/next tree & put the
> SHA-id in Fixes tag.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-03-12 18:23 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 0:47 [PATCH v2 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-24 0:59 ` afzal mohammed
2020-02-24 0:47 ` afzal mohammed
2020-02-24 0:48 ` [PATCH v2 01/18] alpha: replace setup_irq() by request_irq() afzal mohammed
2020-02-24 0:49 ` [PATCH v2 02/18] ARM: " afzal mohammed
2020-02-24 0:49 ` afzal mohammed
2020-02-24 10:13 ` Lubomir Rintel
2020-02-24 10:13 ` Lubomir Rintel
2020-02-26 16:31 ` Tony Lindgren
2020-02-26 16:31 ` Tony Lindgren
2020-02-24 0:49 ` [PATCH v2 03/18] c6x: " afzal mohammed
2020-02-24 0:49 ` [PATCH v2 04/18] hexagon: " afzal mohammed
2020-02-24 0:49 ` [PATCH v2 05/18] ia64: " afzal mohammed
2020-02-24 0:49 ` afzal mohammed
2020-02-24 0:50 ` [PATCH v2 06/18] m68k: Replace " afzal mohammed
2020-02-26 0:42 ` Greg Ungerer
2020-02-26 1:11 ` Finn Thain
2020-02-26 2:11 ` Greg Ungerer
2020-02-26 6:39 ` Finn Thain
2020-02-26 12:26 ` Greg Ungerer
2020-02-26 22:31 ` Finn Thain
2020-02-27 6:37 ` Greg Ungerer
2020-02-27 22:19 ` Finn Thain
2020-02-27 8:18 ` afzal mohammed
2020-02-27 8:32 ` Geert Uytterhoeven
2020-02-27 12:06 ` afzal mohammed
2020-02-27 22:38 ` Finn Thain
2020-02-29 12:41 ` afzal mohammed
2020-02-28 7:05 ` Greg Ungerer
2020-02-29 12:47 ` afzal mohammed
2020-02-29 13:15 ` afzal mohammed
2020-02-29 23:11 ` Finn Thain
2020-03-01 1:05 ` afzal mohammed
2020-03-01 3:26 ` Finn Thain
2020-03-01 6:13 ` afzal mohammed
2020-03-02 6:26 ` Finn Thain
2020-03-04 1:24 ` afzal mohammed
2020-02-24 0:50 ` [PATCH v2 07/18] microblaze: " afzal mohammed
2020-02-24 0:50 ` [PATCH v2 08/18] MIPS: " afzal mohammed
2020-02-24 0:50 ` afzal mohammed
2020-02-24 0:51 ` [PATCH v2 09/18] parisc: " afzal mohammed
2020-02-24 0:51 ` [PATCH v2 10/18] powerpc: " afzal mohammed
2020-02-24 0:51 ` afzal mohammed
2020-02-24 0:51 ` [PATCH v2 11/18] s390: replace " afzal mohammed
2020-02-24 0:51 ` [PATCH v2 12/18] sh: " afzal mohammed
2020-02-24 0:51 ` afzal mohammed
2020-02-24 0:52 ` [PATCH v2 13/18] unicore32: " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 14/18] x86: Replace " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 15/18] xtensa: replace " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 16/18] clocksource: Replace " afzal mohammed
2020-02-24 0:52 ` afzal mohammed
2020-02-24 0:52 ` afzal mohammed
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 2:52 ` kbuild test robot
2020-02-25 7:51 ` afzal mohammed
2020-02-25 7:51 ` afzal mohammed
2020-02-25 7:51 ` afzal mohammed
2020-02-27 10:59 ` [PATCH v3 " afzal mohammed
2020-02-27 10:59 ` afzal mohammed
2020-02-27 10:59 ` afzal mohammed
2020-02-27 11:18 ` Daniel Lezcano
2020-02-27 11:18 ` Daniel Lezcano
2020-02-27 11:18 ` Daniel Lezcano
2020-03-12 6:48 ` [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id afzal mohammed
2020-03-12 6:48 ` afzal mohammed
2020-03-12 6:48 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 18:23 ` Daniel Lezcano [this message]
2020-03-12 18:23 ` Daniel Lezcano
2020-03-12 18:23 ` Daniel Lezcano
2020-03-19 8:47 ` [tip: timers/core] clocksource/drivers/timer-cs5535: Request " tip-bot2 for afzal mohammed
2020-04-16 16:08 ` [PATCH v4] clocksource/drivers/timer-cs5535: request " patchwork-bot+linux-amlogic
2020-02-24 0:53 ` [PATCH v2 17/18] irqchip: Replace setup_irq() by request_irq() afzal mohammed
2020-02-24 0:53 ` [PATCH v2 18/18] genirq: Remove setup_irq() and remove_irq() afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7541667-05e1-6a54-165f-7d8ad66f5b33@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=afzal.mohd.ma@gmail.com \
--cc=allison@lohutok.net \
--cc=baohua@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.